* [PATCH] virtio: make virtio_bus const
@ 2024-02-04 20:52 Ricardo B. Marliere
2024-02-05 12:46 ` Greg Kroah-Hartman
2024-02-06 2:48 ` Jason Wang
0 siblings, 2 replies; 3+ messages in thread
From: Ricardo B. Marliere @ 2024-02-04 20:52 UTC (permalink / raw)
To: Michael S. Tsirkin, Jason Wang, Xuan Zhuo
Cc: virtualization, linux-kernel, Greg Kroah-Hartman,
Ricardo B. Marliere
Now that the driver core can properly handle constant struct bus_type,
move the virtio_bus variable to be a constant structure as well,
placing it into read-only memory which can not be modified at runtime.
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Suggested-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Ricardo B. Marliere <ricardo@marliere.net>
---
drivers/virtio/virtio.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/virtio/virtio.c b/drivers/virtio/virtio.c
index f4080692b351..a68e6556f71b 100644
--- a/drivers/virtio/virtio.c
+++ b/drivers/virtio/virtio.c
@@ -353,7 +353,7 @@ static void virtio_dev_remove(struct device *_d)
of_node_put(dev->dev.of_node);
}
-static struct bus_type virtio_bus = {
+static const struct bus_type virtio_bus = {
.name = "virtio",
.match = virtio_dev_match,
.dev_groups = virtio_dev_groups,
---
base-commit: 41b9fb381a486360b2daaec0c7480f8e3ff72bc7
change-id: 20240204-bus_cleanup-virtio-9f076c3cb068
Best regards,
--
Ricardo B. Marliere <ricardo@marliere.net>
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] virtio: make virtio_bus const
2024-02-04 20:52 [PATCH] virtio: make virtio_bus const Ricardo B. Marliere
@ 2024-02-05 12:46 ` Greg Kroah-Hartman
2024-02-06 2:48 ` Jason Wang
1 sibling, 0 replies; 3+ messages in thread
From: Greg Kroah-Hartman @ 2024-02-05 12:46 UTC (permalink / raw)
To: Ricardo B. Marliere
Cc: Michael S. Tsirkin, Jason Wang, Xuan Zhuo, virtualization,
linux-kernel
On Sun, Feb 04, 2024 at 05:52:51PM -0300, Ricardo B. Marliere wrote:
> Now that the driver core can properly handle constant struct bus_type,
> move the virtio_bus variable to be a constant structure as well,
> placing it into read-only memory which can not be modified at runtime.
>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Suggested-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Signed-off-by: Ricardo B. Marliere <ricardo@marliere.net>
Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] virtio: make virtio_bus const
2024-02-04 20:52 [PATCH] virtio: make virtio_bus const Ricardo B. Marliere
2024-02-05 12:46 ` Greg Kroah-Hartman
@ 2024-02-06 2:48 ` Jason Wang
1 sibling, 0 replies; 3+ messages in thread
From: Jason Wang @ 2024-02-06 2:48 UTC (permalink / raw)
To: Ricardo B. Marliere
Cc: Michael S. Tsirkin, Xuan Zhuo, virtualization, linux-kernel,
Greg Kroah-Hartman
On Mon, Feb 5, 2024 at 4:52 AM Ricardo B. Marliere <ricardo@marliere.net> wrote:
>
> Now that the driver core can properly handle constant struct bus_type,
> move the virtio_bus variable to be a constant structure as well,
> placing it into read-only memory which can not be modified at runtime.
>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Suggested-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Signed-off-by: Ricardo B. Marliere <ricardo@marliere.net>
> ---
Acked-by: Jason Wang <jasowang@redhat.com>
Thanks
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-02-06 2:48 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-02-04 20:52 [PATCH] virtio: make virtio_bus const Ricardo B. Marliere
2024-02-05 12:46 ` Greg Kroah-Hartman
2024-02-06 2:48 ` Jason Wang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox