* Re: [PATCH v2] docs/gpu: ci: update flake tests requirements
2024-09-26 7:06 [PATCH v2] docs/gpu: ci: update flake tests requirements Vignesh Raman
@ 2024-09-26 7:26 ` Maxime Ripard
2024-09-26 8:47 ` Vignesh Raman
2024-09-26 7:29 ` Dmitry Baryshkov
2024-09-26 23:01 ` Abhinav Kumar
2 siblings, 1 reply; 5+ messages in thread
From: Maxime Ripard @ 2024-09-26 7:26 UTC (permalink / raw)
To: Vignesh Raman
Cc: dri-devel, daniels, helen.koike, airlied, daniel, robdclark,
guilherme.gallo, sergi.blanch.torne, deborah.brouwer,
dmitry.baryshkov, rodrigo.vivi, linux-mediatek, linux-amlogic,
linux-rockchip, amd-gfx, linux-arm-msm, intel-gfx, virtualization,
linux-kernel
[-- Attachment #1: Type: text/plain, Size: 2391 bytes --]
On Thu, Sep 26, 2024 at 12:36:49PM GMT, Vignesh Raman wrote:
> Update the documentation to require linking to a relevant GitLab
> issue for each new flake entry instead of an email report. Added
> specific GitLab issue URLs for i915, xe and other drivers.
>
> Signed-off-by: Vignesh Raman <vignesh.raman@collabora.com>
> ---
>
> v2:
> - Add gitlab issue link for msm driver.
>
> ---
> Documentation/gpu/automated_testing.rst | 16 +++++++++++-----
> 1 file changed, 11 insertions(+), 5 deletions(-)
>
> diff --git a/Documentation/gpu/automated_testing.rst b/Documentation/gpu/automated_testing.rst
> index 2d5a28866afe..f918fe56f2b0 100644
> --- a/Documentation/gpu/automated_testing.rst
> +++ b/Documentation/gpu/automated_testing.rst
> @@ -67,20 +67,26 @@ Lists the tests that for a given driver on a specific hardware revision are
> known to behave unreliably. These tests won't cause a job to fail regardless of
> the result. They will still be run.
>
> -Each new flake entry must be associated with a link to the email reporting the
> -bug to the author of the affected driver, the board name or Device Tree name of
> -the board, the first kernel version affected, the IGT version used for tests,
> -and an approximation of the failure rate.
> +Each new flake entry must include a link to the relevant GitLab issue, the board
> +name or Device Tree name, the first kernel version affected, the IGT version used
> +for tests and an approximation of the failure rate.
>
> They should be provided under the following format::
>
> - # Bug Report: $LORE_OR_PATCHWORK_URL
> + # Bug Report: $GITLAB_ISSUE
> # Board Name: broken-board.dtb
> # Linux Version: 6.6-rc1
> # IGT Version: 1.28-gd2af13d9f
> # Failure Rate: 100
> flaky-test
>
> +The GitLab issue must include the logs and the pipeline link. Use the appropriate
> +link below to create an issue.
> +https://gitlab.freedesktop.org/drm/i915/kernel/-/issues for i915 driver
> +https://gitlab.freedesktop.org/drm/xe/kernel/-/issues for xe driver
> +https://gitlab.freedesktop.org/drm/msm/-/issues for msm driver
> +https://gitlab.freedesktop.org/drm/misc/kernel/-/issues for other drivers
> +
I can't comment for the others, but drm-misc at least still requires
reporting issues by mail, so, no, sorry, we can't switch to gitlab only
for now.
Maxime
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 273 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2] docs/gpu: ci: update flake tests requirements
2024-09-26 7:26 ` Maxime Ripard
@ 2024-09-26 8:47 ` Vignesh Raman
0 siblings, 0 replies; 5+ messages in thread
From: Vignesh Raman @ 2024-09-26 8:47 UTC (permalink / raw)
To: Maxime Ripard
Cc: dri-devel, daniels, helen.koike, airlied, daniel, robdclark,
guilherme.gallo, sergi.blanch.torne, deborah.brouwer,
dmitry.baryshkov, rodrigo.vivi, linux-mediatek, linux-amlogic,
linux-rockchip, amd-gfx, linux-arm-msm, intel-gfx, virtualization,
linux-kernel
Hi Maxime,
On 26/09/24 12:56, Maxime Ripard wrote:
> On Thu, Sep 26, 2024 at 12:36:49PM GMT, Vignesh Raman wrote:
>> Update the documentation to require linking to a relevant GitLab
>> issue for each new flake entry instead of an email report. Added
>> specific GitLab issue URLs for i915, xe and other drivers.
>>
>> Signed-off-by: Vignesh Raman <vignesh.raman@collabora.com>
>> ---
>>
>> v2:
>> - Add gitlab issue link for msm driver.
>>
>> ---
>> Documentation/gpu/automated_testing.rst | 16 +++++++++++-----
>> 1 file changed, 11 insertions(+), 5 deletions(-)
>>
>> diff --git a/Documentation/gpu/automated_testing.rst b/Documentation/gpu/automated_testing.rst
>> index 2d5a28866afe..f918fe56f2b0 100644
>> --- a/Documentation/gpu/automated_testing.rst
>> +++ b/Documentation/gpu/automated_testing.rst
>> @@ -67,20 +67,26 @@ Lists the tests that for a given driver on a specific hardware revision are
>> known to behave unreliably. These tests won't cause a job to fail regardless of
>> the result. They will still be run.
>>
>> -Each new flake entry must be associated with a link to the email reporting the
>> -bug to the author of the affected driver, the board name or Device Tree name of
>> -the board, the first kernel version affected, the IGT version used for tests,
>> -and an approximation of the failure rate.
>> +Each new flake entry must include a link to the relevant GitLab issue, the board
>> +name or Device Tree name, the first kernel version affected, the IGT version used
>> +for tests and an approximation of the failure rate.
>>
>> They should be provided under the following format::
>>
>> - # Bug Report: $LORE_OR_PATCHWORK_URL
>> + # Bug Report: $GITLAB_ISSUE
>> # Board Name: broken-board.dtb
>> # Linux Version: 6.6-rc1
>> # IGT Version: 1.28-gd2af13d9f
>> # Failure Rate: 100
>> flaky-test
>>
>> +The GitLab issue must include the logs and the pipeline link. Use the appropriate
>> +link below to create an issue.
>> +https://gitlab.freedesktop.org/drm/i915/kernel/-/issues for i915 driver
>> +https://gitlab.freedesktop.org/drm/xe/kernel/-/issues for xe driver
>> +https://gitlab.freedesktop.org/drm/msm/-/issues for msm driver
>> +https://gitlab.freedesktop.org/drm/misc/kernel/-/issues for other drivers
>> +
>
> I can't comment for the others, but drm-misc at least still requires
> reporting issues by mail, so, no, sorry, we can't switch to gitlab only
> for now.
In https://gitlab.freedesktop.org/drm/ we have xe, i915, msm, nouveau,
and amd (only for issues). In drm-ci we test i915, msm and amd.
So I will add GitLab links for these and for other drivers use email
reporting. I will reword this section. Thanks.
Regards,
Vignesh
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2] docs/gpu: ci: update flake tests requirements
2024-09-26 7:06 [PATCH v2] docs/gpu: ci: update flake tests requirements Vignesh Raman
2024-09-26 7:26 ` Maxime Ripard
@ 2024-09-26 7:29 ` Dmitry Baryshkov
2024-09-26 23:01 ` Abhinav Kumar
2 siblings, 0 replies; 5+ messages in thread
From: Dmitry Baryshkov @ 2024-09-26 7:29 UTC (permalink / raw)
To: Vignesh Raman
Cc: dri-devel, daniels, helen.koike, airlied, daniel, robdclark,
guilherme.gallo, sergi.blanch.torne, deborah.brouwer, mripard,
rodrigo.vivi, linux-mediatek, linux-amlogic, linux-rockchip,
amd-gfx, linux-arm-msm, intel-gfx, virtualization, linux-kernel
On Thu, Sep 26, 2024 at 12:36:49PM GMT, Vignesh Raman wrote:
> Update the documentation to require linking to a relevant GitLab
> issue for each new flake entry instead of an email report. Added
> specific GitLab issue URLs for i915, xe and other drivers.
>
> Signed-off-by: Vignesh Raman <vignesh.raman@collabora.com>
> ---
>
> v2:
> - Add gitlab issue link for msm driver.
>
> ---
> Documentation/gpu/automated_testing.rst | 16 +++++++++++-----
> 1 file changed, 11 insertions(+), 5 deletions(-)
>
> diff --git a/Documentation/gpu/automated_testing.rst b/Documentation/gpu/automated_testing.rst
> index 2d5a28866afe..f918fe56f2b0 100644
> --- a/Documentation/gpu/automated_testing.rst
> +++ b/Documentation/gpu/automated_testing.rst
> @@ -67,20 +67,26 @@ Lists the tests that for a given driver on a specific hardware revision are
> known to behave unreliably. These tests won't cause a job to fail regardless of
> the result. They will still be run.
>
> -Each new flake entry must be associated with a link to the email reporting the
> -bug to the author of the affected driver, the board name or Device Tree name of
> -the board, the first kernel version affected, the IGT version used for tests,
> -and an approximation of the failure rate.
> +Each new flake entry must include a link to the relevant GitLab issue, the board
> +name or Device Tree name, the first kernel version affected, the IGT version used
> +for tests and an approximation of the failure rate.
>
> They should be provided under the following format::
>
> - # Bug Report: $LORE_OR_PATCHWORK_URL
> + # Bug Report: $GITLAB_ISSUE
> # Board Name: broken-board.dtb
> # Linux Version: 6.6-rc1
> # IGT Version: 1.28-gd2af13d9f
> # Failure Rate: 100
> flaky-test
>
> +The GitLab issue must include the logs and the pipeline link. Use the appropriate
> +link below to create an issue.
> +https://gitlab.freedesktop.org/drm/i915/kernel/-/issues for i915 driver
> +https://gitlab.freedesktop.org/drm/xe/kernel/-/issues for xe driver
> +https://gitlab.freedesktop.org/drm/msm/-/issues for msm driver
Ack for the MSM part.
> +https://gitlab.freedesktop.org/drm/misc/kernel/-/issues for other drivers
--
With best wishes
Dmitry
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2] docs/gpu: ci: update flake tests requirements
2024-09-26 7:06 [PATCH v2] docs/gpu: ci: update flake tests requirements Vignesh Raman
2024-09-26 7:26 ` Maxime Ripard
2024-09-26 7:29 ` Dmitry Baryshkov
@ 2024-09-26 23:01 ` Abhinav Kumar
2 siblings, 0 replies; 5+ messages in thread
From: Abhinav Kumar @ 2024-09-26 23:01 UTC (permalink / raw)
To: Vignesh Raman, dri-devel
Cc: daniels, helen.koike, airlied, daniel, robdclark, guilherme.gallo,
sergi.blanch.torne, deborah.brouwer, dmitry.baryshkov, mripard,
rodrigo.vivi, linux-mediatek, linux-amlogic, linux-rockchip,
amd-gfx, linux-arm-msm, intel-gfx, virtualization, linux-kernel
On 9/26/2024 12:06 AM, Vignesh Raman wrote:
> Update the documentation to require linking to a relevant GitLab
> issue for each new flake entry instead of an email report. Added
> specific GitLab issue URLs for i915, xe and other drivers.
>
> Signed-off-by: Vignesh Raman <vignesh.raman@collabora.com>
> ---
>
> v2:
> - Add gitlab issue link for msm driver.
>
> ---
> Documentation/gpu/automated_testing.rst | 16 +++++++++++-----
> 1 file changed, 11 insertions(+), 5 deletions(-)
>
> diff --git a/Documentation/gpu/automated_testing.rst b/Documentation/gpu/automated_testing.rst
> index 2d5a28866afe..f918fe56f2b0 100644
> --- a/Documentation/gpu/automated_testing.rst
> +++ b/Documentation/gpu/automated_testing.rst
> @@ -67,20 +67,26 @@ Lists the tests that for a given driver on a specific hardware revision are
> known to behave unreliably. These tests won't cause a job to fail regardless of
> the result. They will still be run.
>
> -Each new flake entry must be associated with a link to the email reporting the
> -bug to the author of the affected driver, the board name or Device Tree name of
> -the board, the first kernel version affected, the IGT version used for tests,
> -and an approximation of the failure rate.
> +Each new flake entry must include a link to the relevant GitLab issue, the board
> +name or Device Tree name, the first kernel version affected, the IGT version used
> +for tests and an approximation of the failure rate.
>
> They should be provided under the following format::
>
> - # Bug Report: $LORE_OR_PATCHWORK_URL
> + # Bug Report: $GITLAB_ISSUE
> # Board Name: broken-board.dtb
> # Linux Version: 6.6-rc1
> # IGT Version: 1.28-gd2af13d9f
> # Failure Rate: 100
> flaky-test
>
> +The GitLab issue must include the logs and the pipeline link. Use the appropriate
> +link below to create an issue.
> +https://gitlab.freedesktop.org/drm/i915/kernel/-/issues for i915 driver
> +https://gitlab.freedesktop.org/drm/xe/kernel/-/issues for xe driver
> +https://gitlab.freedesktop.org/drm/msm/-/issues for msm driver
> +https://gitlab.freedesktop.org/drm/misc/kernel/-/issues for other drivers
> +
Acked for MSM.
Thanks
Abhinav
> drivers/gpu/drm/ci/${DRIVER_NAME}-${HW_REVISION}-skips.txt
> -----------------------------------------------------------
>
^ permalink raw reply [flat|nested] 5+ messages in thread