From: "Jinhui Guo" <guojinhui.liam@bytedance.com>
To: "Alex Williamson" <alex@shazbot.org>,
"Jason Gunthorpe" <jgg@ziepe.ca>,
"Yishai Hadas" <yishaih@nvidia.com>,
"Shameer Kolothum" <skolothumtho@nvidia.com>,
"Kevin Tian" <kevin.tian@intel.com>
Cc: <kvm@vger.kernel.org>, <virtualization@lists.linux.dev>,
<linux-kernel@vger.kernel.org>,
"Jinhui Guo" <guojinhui.liam@bytedance.com>
Subject: [PATCH] vfio/virtio: Fix lock/unlock mismatch in virtiovf_read_device_context_chunk()
Date: Mon, 13 Apr 2026 14:52:04 +0800 [thread overview]
Message-ID: <20260413065204.30330-1-guojinhui.liam@bytedance.com> (raw)
virtiovf_read_device_context_chunk() takes migf->list_lock with
spin_lock() but releases it with spin_unlock_irq(). This mismatch
can incorrectly enable interrupts if they were already disabled
when the lock was acquired, leading to unbalanced IRQ state.
Fix by using spin_lock_irq() to match spin_unlock_irq().
Fixes: 0bbc82e4ec79 ("vfio/virtio: Add support for the basic live migration functionality")
Signed-off-by: Jinhui Guo <guojinhui.liam@bytedance.com>
---
drivers/vfio/pci/virtio/migrate.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/vfio/pci/virtio/migrate.c b/drivers/vfio/pci/virtio/migrate.c
index 35fa2d6ed611..9fc24788fc04 100644
--- a/drivers/vfio/pci/virtio/migrate.c
+++ b/drivers/vfio/pci/virtio/migrate.c
@@ -621,7 +621,7 @@ virtiovf_read_device_context_chunk(struct virtiovf_migration_file *migf,
buf->start_pos = buf->migf->max_pos;
migf->max_pos += buf->length;
- spin_lock(&migf->list_lock);
+ spin_lock_irq(&migf->list_lock);
list_add_tail(&buf->buf_elm, &migf->buf_list);
spin_unlock_irq(&migf->list_lock);
return 0;
--
2.20.1
reply other threads:[~2026-04-13 6:53 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260413065204.30330-1-guojinhui.liam@bytedance.com \
--to=guojinhui.liam@bytedance.com \
--cc=alex@shazbot.org \
--cc=jgg@ziepe.ca \
--cc=kevin.tian@intel.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=skolothumtho@nvidia.com \
--cc=virtualization@lists.linux.dev \
--cc=yishaih@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox