From: Greg KH <gregkh@linuxfoundation.org>
To: Goncalo Gomes <gomesgoncalo@gmail.com>
Cc: amit@kernel.org, arnd@arndb.de, virtualization@lists.linux.dev,
linux-kernel@vger.kernel.org,
Goncalo Gomes <gomesgoncalo+linuxkernel@gmail.com>
Subject: Re: [PATCH] virtio_console: clean up port name sysfs attribute
Date: Mon, 1 Jun 2026 16:30:29 +0200 [thread overview]
Message-ID: <2026060152-armrest-duller-fc38@gregkh> (raw)
In-Reply-To: <20260601142508.3740862-1-gomesgoncalo+linuxkernel@gmail.com>
On Mon, Jun 01, 2026 at 03:25:08PM +0100, Goncalo Gomes wrote:
> Fix issues flagged by checkpatch.pl:
This is only needed for new code, or stuff in drivers/staging/ Stick to
there unless you know the maintainer will take such changes.
> Replace `sprintf` with `sysfs_emit` in the `name_show` callback.
> sysfs.rst states that `show` methods should only use `sysfs_emit`
> when formatting output for user space.
>
> Rename `show_port_name` to `name_show` to follow the naming convention
> for sysfs attribute callbacks, and replace the open-coded DEVICE_ATTR()
> with DEVICE_ATTR_RO(name) which encodes both the mode and the expected
> function name.
>
> Also fix a missing blank line after a declaration in free_buf().
You should have broken this up into multiple patches anyway :(
thanks,
greg k-h
prev parent reply other threads:[~2026-06-01 14:31 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-01 14:25 [PATCH] virtio_console: clean up port name sysfs attribute Goncalo Gomes
2026-06-01 14:30 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2026060152-armrest-duller-fc38@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=amit@kernel.org \
--cc=arnd@arndb.de \
--cc=gomesgoncalo+linuxkernel@gmail.com \
--cc=gomesgoncalo@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=virtualization@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox