* [PATCH] virtio_pci: add missing newline to the pmcsr error message
@ 2026-09-12 18:03 Maoxia
2026-09-12 18:07 ` sashiko-bot
0 siblings, 1 reply; 2+ messages in thread
From: Maoxia @ 2026-09-12 18:03 UTC (permalink / raw)
To: Michael S . Tsirkin
Cc: Jason Wang, Eugenio Perez, Xuan Zhuo, David Stevens,
virtualization, linux-kernel
The error message emitted when the PCI power management control
register cannot be read is not newline-terminated, so the next kernel
message is appended to it on the same line.
Add the missing '\n'.
Fixes: dff4fa0e5785 ("virtio: Add support for no-reset virtio PCI PM")
Signed-off-by: Maoxia <2312891301@qq.com>
---
drivers/virtio/virtio_pci_common.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/virtio/virtio_pci_common.c b/drivers/virtio/virtio_pci_common.c
index b90c174450b2..24af84b0c6ad 100644
--- a/drivers/virtio/virtio_pci_common.c
+++ b/drivers/virtio/virtio_pci_common.c
@@ -633,7 +633,7 @@ static bool vp_supports_pm_no_reset(struct device *dev)
pci_read_config_word(pci_dev, pci_dev->pm_cap + PCI_PM_CTRL, &pmcsr);
if (PCI_POSSIBLE_ERROR(pmcsr)) {
- dev_err(dev, "Unable to query pmcsr");
+ dev_err(dev, "Unable to query pmcsr\n");
return false;
}
--
2.43.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] virtio_pci: add missing newline to the pmcsr error message
2026-09-12 18:03 [PATCH] virtio_pci: add missing newline to the pmcsr error message Maoxia
@ 2026-09-12 18:07 ` sashiko-bot
0 siblings, 0 replies; 2+ messages in thread
From: sashiko-bot @ 2026-09-12 18:07 UTC (permalink / raw)
To: Maoxia; +Cc: Michael S. Tsirkin, Eugenio Perez, virtualization
> The error message emitted when the PCI power management control
> register cannot be read is not newline-terminated, so the next kernel
> message is appended to it on the same line.
>
> Add the missing '\n'.
>
> Fixes: dff4fa0e5785 ("virtio: Add support for no-reset virtio PCI PM")
> Signed-off-by: Maoxia <2312891301@qq.com>
Sashiko has reviewed this patch and found no issues. It looks great!
--
Sashiko AI review · https://sashiko.dev/#/patchset/tencent_031B923A83E0DEE884BD05D49030890C0406@qq.com?part=1
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-09-12 18:07 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-09-12 18:03 [PATCH] virtio_pci: add missing newline to the pmcsr error message Maoxia
2026-09-12 18:07 ` sashiko-bot
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox