* Re: [PATCH] vhost-scsi: return -ENOENT when no matching tcm_vhost_tpg found
[not found] <1369731284-4139-1-git-send-email-wenchaolinux@gmail.com>
@ 2013-05-28 9:25 ` Asias He
2013-06-12 1:39 ` wenchao
0 siblings, 1 reply; 4+ messages in thread
From: Asias He @ 2013-05-28 9:25 UTC (permalink / raw)
To: Wenchao Xia
Cc: kvm, mst, virtualization, linux-next, wenchaolinuxkvm, pbonzini
On Tue, May 28, 2013 at 04:54:44PM +0800, Wenchao Xia wrote:
> ioctl for VHOST_SCSI_SET_ENDPOINT report file exist errori, when I forget
> to set it correctly in configfs, make user confused. Actually it fail
> to find a matching one, so change the error value.
>
> Signed-off-by: Wenchao Xia <wenchaolinux@gmail.com>
Acked-by: Asias He <asias@redhat.com>
BTW, It would be nice to print more informative info in qemu when wwpn
is not available as well.
> ---
> drivers/vhost/scsi.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/vhost/scsi.c b/drivers/vhost/scsi.c
> index 7014202..6325b1d 100644
> --- a/drivers/vhost/scsi.c
> +++ b/drivers/vhost/scsi.c
> @@ -1219,7 +1219,7 @@ static int vhost_scsi_set_endpoint(
> }
> ret = 0;
> } else {
> - ret = -EEXIST;
> + ret = -ENOENT;
> }
>
> /*
> --
> 1.7.1
>
--
Asias
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] vhost-scsi: return -ENOENT when no matching tcm_vhost_tpg found
2013-05-28 9:25 ` [PATCH] vhost-scsi: return -ENOENT when no matching tcm_vhost_tpg found Asias He
@ 2013-06-12 1:39 ` wenchao
2013-06-12 3:03 ` Greg Kroah-Hartman
0 siblings, 1 reply; 4+ messages in thread
From: wenchao @ 2013-06-12 1:39 UTC (permalink / raw)
To: Asias He
Cc: kvm, mst, Greg Kroah-Hartman, virtualization, linux-next,
wenchaolinuxkvm, pbonzini
cc to Greg for 3.9.
> On Tue, May 28, 2013 at 04:54:44PM +0800, Wenchao Xia wrote:
>> ioctl for VHOST_SCSI_SET_ENDPOINT report file exist errori, when I forget
>> to set it correctly in configfs, make user confused. Actually it fail
>> to find a matching one, so change the error value.
>>
>> Signed-off-by: Wenchao Xia <wenchaolinux@gmail.com>
>
> Acked-by: Asias He <asias@redhat.com>
>
> BTW, It would be nice to print more informative info in qemu when wwpn
> is not available as well.
>
>> ---
>> drivers/vhost/scsi.c | 2 +-
>> 1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/drivers/vhost/scsi.c b/drivers/vhost/scsi.c
>> index 7014202..6325b1d 100644
>> --- a/drivers/vhost/scsi.c
>> +++ b/drivers/vhost/scsi.c
>> @@ -1219,7 +1219,7 @@ static int vhost_scsi_set_endpoint(
>> }
>> ret = 0;
>> } else {
>> - ret = -EEXIST;
>> + ret = -ENOENT;
>> }
>>
>> /*
>> --
>> 1.7.1
>>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] vhost-scsi: return -ENOENT when no matching tcm_vhost_tpg found
@ 2013-05-28 8:54 Wenchao Xia
0 siblings, 0 replies; 4+ messages in thread
From: Wenchao Xia @ 2013-05-28 8:54 UTC (permalink / raw)
To: linux-next
Cc: kvm, mst, virtualization, wenchaolinuxkvm, Wenchao Xia, pbonzini
ioctl for VHOST_SCSI_SET_ENDPOINT report file exist errori, when I forget
to set it correctly in configfs, make user confused. Actually it fail
to find a matching one, so change the error value.
Signed-off-by: Wenchao Xia <wenchaolinux@gmail.com>
---
drivers/vhost/scsi.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/vhost/scsi.c b/drivers/vhost/scsi.c
index 7014202..6325b1d 100644
--- a/drivers/vhost/scsi.c
+++ b/drivers/vhost/scsi.c
@@ -1219,7 +1219,7 @@ static int vhost_scsi_set_endpoint(
}
ret = 0;
} else {
- ret = -EEXIST;
+ ret = -ENOENT;
}
/*
--
1.7.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2013-06-12 3:03 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1369731284-4139-1-git-send-email-wenchaolinux@gmail.com>
2013-05-28 9:25 ` [PATCH] vhost-scsi: return -ENOENT when no matching tcm_vhost_tpg found Asias He
2013-06-12 1:39 ` wenchao
2013-06-12 3:03 ` Greg Kroah-Hartman
2013-05-28 8:54 Wenchao Xia
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox