From: Stefan Hajnoczi <stefanha@redhat.com>
To: Pankaj Raghav <p.raghav@samsung.com>
Cc: axboe@kernel.dk, Pankaj Raghav <pankydev8@gmail.com>,
mst@redhat.com, gost.dev@samsung.com,
virtualization@lists.linux-foundation.org,
linux-block@vger.kernel.org, pbonzini@redhat.com
Subject: Re: [PATCH] virtio-blk: replace ida_simple[get|remove] with ida_[alloc_range|free]
Date: Wed, 30 Nov 2022 15:51:23 -0500 [thread overview]
Message-ID: <Y4fCS2d2r1YvSExI@fedora> (raw)
In-Reply-To: <20221130123001.25473-1-p.raghav@samsung.com>
[-- Attachment #1.1: Type: text/plain, Size: 660 bytes --]
On Wed, Nov 30, 2022 at 01:30:03PM +0100, Pankaj Raghav wrote:
> ida_simple[get|remove] are deprecated, and are just wrappers to
> ida_[alloc_range|free]. Replace ida_simple[get|remove] with their
> corresponding counterparts.
>
> No functional changes.
>
> Signed-off-by: Pankaj Raghav <p.raghav@samsung.com>
> ---
> drivers/block/virtio_blk.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
Chaitanya proposed a similar patch in the past:
https://lore.kernel.org/all/20220420041053.7927-5-kch@nvidia.com/
Your patch calculates the max argument correctly. Looks good.
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
[-- Attachment #2: Type: text/plain, Size: 183 bytes --]
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
next parent reply other threads:[~2022-11-30 20:51 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20221130123126eucas1p2cd3287ee4e5c03642f1847c50af0e4f2@eucas1p2.samsung.com>
[not found] ` <20221130123001.25473-1-p.raghav@samsung.com>
2022-11-30 20:51 ` Stefan Hajnoczi [this message]
2022-11-30 21:24 ` [PATCH] virtio-blk: replace ida_simple[get|remove] with ida_[alloc_range|free] Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y4fCS2d2r1YvSExI@fedora \
--to=stefanha@redhat.com \
--cc=axboe@kernel.dk \
--cc=gost.dev@samsung.com \
--cc=linux-block@vger.kernel.org \
--cc=mst@redhat.com \
--cc=p.raghav@samsung.com \
--cc=pankydev8@gmail.com \
--cc=pbonzini@redhat.com \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox