* Re: [PATCH] virtio-blk: replace ida_simple[get|remove] with ida_[alloc_range|free]
[not found] ` <20221130123001.25473-1-p.raghav@samsung.com>
@ 2022-11-30 20:51 ` Stefan Hajnoczi
2022-11-30 21:24 ` Jens Axboe
1 sibling, 0 replies; 2+ messages in thread
From: Stefan Hajnoczi @ 2022-11-30 20:51 UTC (permalink / raw)
To: Pankaj Raghav
Cc: axboe, Pankaj Raghav, mst, gost.dev, virtualization, linux-block,
pbonzini
[-- Attachment #1.1: Type: text/plain, Size: 660 bytes --]
On Wed, Nov 30, 2022 at 01:30:03PM +0100, Pankaj Raghav wrote:
> ida_simple[get|remove] are deprecated, and are just wrappers to
> ida_[alloc_range|free]. Replace ida_simple[get|remove] with their
> corresponding counterparts.
>
> No functional changes.
>
> Signed-off-by: Pankaj Raghav <p.raghav@samsung.com>
> ---
> drivers/block/virtio_blk.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
Chaitanya proposed a similar patch in the past:
https://lore.kernel.org/all/20220420041053.7927-5-kch@nvidia.com/
Your patch calculates the max argument correctly. Looks good.
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
[-- Attachment #2: Type: text/plain, Size: 183 bytes --]
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] virtio-blk: replace ida_simple[get|remove] with ida_[alloc_range|free]
[not found] ` <20221130123001.25473-1-p.raghav@samsung.com>
2022-11-30 20:51 ` [PATCH] virtio-blk: replace ida_simple[get|remove] with ida_[alloc_range|free] Stefan Hajnoczi
@ 2022-11-30 21:24 ` Jens Axboe
1 sibling, 0 replies; 2+ messages in thread
From: Jens Axboe @ 2022-11-30 21:24 UTC (permalink / raw)
To: pbonzini, Pankaj Raghav, stefanha
Cc: Pankaj Raghav, mst, gost.dev, virtualization, linux-block
On Wed, 30 Nov 2022 13:30:03 +0100, Pankaj Raghav wrote:
> ida_simple[get|remove] are deprecated, and are just wrappers to
> ida_[alloc_range|free]. Replace ida_simple[get|remove] with their
> corresponding counterparts.
>
> No functional changes.
>
>
> [...]
Applied, thanks!
[1/1] virtio-blk: replace ida_simple[get|remove] with ida_[alloc_range|free]
commit: 92a34c461719eb4a3f95353bb7b27a3238eb7478
Best regards,
--
Jens Axboe
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
^ permalink raw reply [flat|nested] 2+ messages in thread