From: Petr Mladek via Virtualization <virtualization@lists.linux-foundation.org>
To: "Seth Forshee (DigitalOcean)" <sforshee@digitalocean.com>
Cc: Joe Lawrence <joe.lawrence@redhat.com>,
kvm@vger.kernel.org, "Michael S. Tsirkin" <mst@redhat.com>,
netdev@vger.kernel.org, Jiri Kosina <jikos@kernel.org>,
linux-kernel@vger.kernel.org,
virtualization@lists.linux-foundation.org,
"Seth Forshee \(DigitalOcean\)" <sforshee@kernel.org>,
live-patching@vger.kernel.org, Miroslav Benes <mbenes@suse.cz>,
Josh Poimboeuf <jpoimboe@kernel.org>
Subject: Re: [PATCH 0/2] vhost: improve livepatch switching for heavily loaded vhost worker kthreads
Date: Thu, 26 Jan 2023 18:03:16 +0100 [thread overview]
Message-ID: <Y9KyVKQk3eH+RRse@alley> (raw)
In-Reply-To: <20230120-vhost-klp-switching-v1-0-7c2b65519c43@kernel.org>
On Fri 2023-01-20 16:12:20, Seth Forshee (DigitalOcean) wrote:
> We've fairly regularaly seen liveptches which cannot transition within kpatch's
> timeout period due to busy vhost worker kthreads.
I have missed this detail. Miroslav told me that we have solved
something similar some time ago, see
https://lore.kernel.org/all/20220507174628.2086373-1-song@kernel.org/
Honestly, kpatch's timeout 1 minute looks incredible low to me. Note
that the transition is tried only once per minute. It means that there
are "only" 60 attempts.
Just by chance, does it help you to increase the timeout, please?
This low timeout might be useful for testing. But in practice, it does
not matter when the transition is lasting one hour or even longer.
It takes much longer time to prepare the livepatch.
Best Regards,
Petr
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
next prev parent reply other threads:[~2023-01-26 17:03 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20230120-vhost-klp-switching-v1-0-7c2b65519c43@kernel.org>
2023-01-22 8:34 ` [PATCH 0/2] vhost: improve livepatch switching for heavily loaded vhost worker kthreads Michael S. Tsirkin
[not found] ` <20230120-vhost-klp-switching-v1-2-7c2b65519c43@kernel.org>
2023-01-24 14:17 ` [PATCH 2/2] vhost: check for pending livepatches from " Petr Mladek via Virtualization
[not found] ` <Y9ATo5FukOhphwqT@do-x1extreme>
2023-01-25 11:34 ` Petr Mladek via Virtualization
[not found] ` <Y9FfenH/p3qzRlar@do-x1extreme>
2023-01-26 11:16 ` Petr Mladek via Virtualization
2023-01-26 11:49 ` Petr Mladek via Virtualization
2023-01-26 17:03 ` Petr Mladek via Virtualization [this message]
[not found] ` <Y9LswwnPAf+nOVFG@do-x1extreme>
[not found] ` <20230127044355.frggdswx424kd5dq@treble>
2023-01-27 10:37 ` [PATCH 0/2] vhost: improve livepatch switching for heavily loaded " Peter Zijlstra
2023-01-27 12:09 ` Petr Mladek via Virtualization
[not found] ` <20230127165236.rjcp6jm6csdta6z3@treble>
[not found] ` <20230127170946.zey6xbr4sm4kvh3x@treble>
[not found] ` <20230127221131.sdneyrlxxhc4h3fa@treble>
2023-01-30 12:40 ` Peter Zijlstra
2023-01-30 18:36 ` Mark Rutland
[not found] ` <20230130194823.6y3rc227bvsgele4@treble>
2023-01-31 10:22 ` Mark Rutland
[not found] ` <20230131163832.z46ihurbmjcwuvck@treble>
2023-02-01 11:10 ` Mark Rutland
[not found] ` <20230201165727.lnywx6zyefbqbrke@treble>
2023-02-01 17:11 ` Mark Rutland
[not found] ` <20230130195930.s5iu76e56j4q5bra@treble>
2023-01-31 10:02 ` Peter Zijlstra
2023-01-27 11:19 ` Petr Mladek via Virtualization
[not found] ` <Y9PmZFBEwUBwV3s/@do-x1extreme>
2023-01-30 9:55 ` Petr Mladek via Virtualization
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y9KyVKQk3eH+RRse@alley \
--to=virtualization@lists.linux-foundation.org \
--cc=jikos@kernel.org \
--cc=joe.lawrence@redhat.com \
--cc=jpoimboe@kernel.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=live-patching@vger.kernel.org \
--cc=mbenes@suse.cz \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=pmladek@suse.com \
--cc=sforshee@digitalocean.com \
--cc=sforshee@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox