[PATCH] VSOCK: fix returnvar.cocci warnings

[PATCH] VSOCK: fix returnvar.cocci warnings

[Julia Lawall]

Remove unneeded variable used to store return value.

Generated by: scripts/coccinelle/misc/returnvar.cocci

CC: Asias He <asias@redhat.com>
Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
Signed-off-by: Julia Lawall <julia.lawall@lip6.fr>

---

 vsock.c |    3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

--- a/drivers/vhost/vsock.c
+++ b/drivers/vhost/vsock.c
@@ -56,8 +56,7 @@ struct vhost_vsock {
 
 static u32 vhost_transport_get_local_cid(void)
 {
-	u32 cid = VHOST_VSOCK_DEFAULT_HOST_CID;
-	return cid;
+	return VHOST_VSOCK_DEFAULT_HOST_CID;
 }
 
 static struct vhost_vsock *vhost_vsock_get(u32 guest_cid)

Re: [PATCH] VSOCK: fix returnvar.cocci warnings

[Stefan Hajnoczi]

[-- Attachment #1.1: Type: text/plain, Size: 819 bytes --]

On Sun, Dec 06, 2015 at 06:56:23AM +0100, Julia Lawall wrote:
> Remove unneeded variable used to store return value.
> 
> Generated by: scripts/coccinelle/misc/returnvar.cocci
> 
> CC: Asias He <asias@redhat.com>
> Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
> Signed-off-by: Julia Lawall <julia.lawall@lip6.fr>
> 
> ---
> 
>  vsock.c |    3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> --- a/drivers/vhost/vsock.c
> +++ b/drivers/vhost/vsock.c
> @@ -56,8 +56,7 @@ struct vhost_vsock {
>  
>  static u32 vhost_transport_get_local_cid(void)
>  {
> -	u32 cid = VHOST_VSOCK_DEFAULT_HOST_CID;
> -	return cid;
> +	return VHOST_VSOCK_DEFAULT_HOST_CID;
>  }
>  
>  static struct vhost_vsock *vhost_vsock_get(u32 guest_cid)

Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]

[-- Attachment #2: Type: text/plain, Size: 183 bytes --]

_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization

Re: [PATCH] VSOCK: fix returnvar.cocci warnings

[David Miller]

From: Julia Lawall <julia.lawall@lip6.fr>
Date: Sun, 6 Dec 2015 06:56:23 +0100 (CET)

> Remove unneeded variable used to store return value.
> 
> Generated by: scripts/coccinelle/misc/returnvar.cocci
> 
> CC: Asias He <asias@redhat.com>
> Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
> Signed-off-by: Julia Lawall <julia.lawall@lip6.fr>

Applied to net-next, thanks.