Linux virtualization list
 help / color / mirror / Atom feed
From: "H. Peter Anvin" <hpa@zytor.com>
To: Nick Desaulniers <ndesaulniers@google.com>,
	akpm@linux-foundation.org, mingo@redhat.com, tglx@linutronix.de
Cc: kstewart@linuxfoundation.org, andrea.parri@amarulasolutions.com,
	linux-efi@vger.kernel.org, brijesh.singh@amd.com,
	jan.kiszka@siemens.com, will.deacon@arm.com,
	jarkko.sakkinen@linux.intel.com, linux-kernel@vger.kernel.org,
	yamada.masahiro@socionext.com, manojgupta@google.com,
	akataria@vmware.com, tweek@google.com, mawilcox@microsoft.com,
	x86@kernel.org, ghackmann@google.com, mka@chromium.org,
	geert@linux-m68k.org, rientjes@google.com,
	aryabinin@virtuozzo.com, thomas.lendacky@amd.com, arnd@arndb.de,
	linux-kbuild@vger.kernel.org, keescook@google.com,
	rostedt@goodmis.org, acme@redhat.com, caoj.fnst@cn.fujitsu.com,
	jpoimboe@redhat.com, sedat.dilek@gmail.com,
	boris.ostrovsky@oracle.com,
	virtualization@lists.linux-foundation.org, jgross@suse.com,
	michal.lkml@markovi.net, tstellar@redhat.com,
	gregkh@linuxfoundation.org, ard.biesheuvel@linaro.org,
	astrachan@google.com, mjg59@g
Subject: Re: [PATCH v5 2/3] x86/asm: add _ASM_ARG* constants for argument registers to <asm/asm.h>
Date: Thu, 14 Jun 2018 13:47:27 -0700	[thread overview]
Message-ID: <b027a324-ffae-fd5e-d8a3-03934be91a2d@zytor.com> (raw)
In-Reply-To: <20180613210518.113983-3-ndesaulniers@google.com>

On 06/13/18 14:05, Nick Desaulniers wrote:
> From: "H. Peter Anvin" <hpa@linux.intel.com>
> 
> i386 and x86-64 uses different registers for arguments; make them
> available so we don't have to #ifdef in the actual code.
> 
> Native size and specified size (q, l, w, b) versions are provided.
> 
> Suggested-by: Sedat Dilek <sedat.dilek@gmail.com>
> Signed-off-by: H. Peter Anvin <hpa@linux.intel.com>
> Signed-off-by: Nick Desaulniers <ndesaulniers@google.com>

I still object to Suggested-by: here.  Sedat did a correction, which is
a Reviewed-by:, but unless I'm completely out to sea, there was no
suggestion on Sedat's part of this; and I had certainly not seen it when
I wrote the code.

	-hpa

       reply	other threads:[~2018-06-14 20:47 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20180613210518.113983-1-ndesaulniers@google.com>
     [not found] ` <20180613210518.113983-3-ndesaulniers@google.com>
2018-06-14 20:47   ` H. Peter Anvin [this message]
     [not found]     ` <CAKwvOdngs8k_T=nDKh8JYdAwwFoJRcCU0bZu0tJHQ+keZ5+RFQ@mail.gmail.com>
2018-06-15  0:17       ` [PATCH v5 2/3] x86/asm: add _ASM_ARG* constants for argument registers to <asm/asm.h> H. Peter Anvin
     [not found]         ` <CAKwvOdmE-EHJY7tgzkhyQqNT3m3oWtd6iE3sWBTz19Rijzx4Ew@mail.gmail.com>
2018-06-21 12:28           ` Ingo Molnar
2018-06-19 15:03 ` [PATCH v5 0/3] extern inline native_save_fl for paravirt Juergen Gross

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b027a324-ffae-fd5e-d8a3-03934be91a2d@zytor.com \
    --to=hpa@zytor.com \
    --cc=acme@redhat.com \
    --cc=akataria@vmware.com \
    --cc=akpm@linux-foundation.org \
    --cc=andrea.parri@amarulasolutions.com \
    --cc=ard.biesheuvel@linaro.org \
    --cc=arnd@arndb.de \
    --cc=aryabinin@virtuozzo.com \
    --cc=astrachan@google.com \
    --cc=boris.ostrovsky@oracle.com \
    --cc=brijesh.singh@amd.com \
    --cc=caoj.fnst@cn.fujitsu.com \
    --cc=geert@linux-m68k.org \
    --cc=ghackmann@google.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=jan.kiszka@siemens.com \
    --cc=jarkko.sakkinen@linux.intel.com \
    --cc=jgross@suse.com \
    --cc=jpoimboe@redhat.com \
    --cc=keescook@google.com \
    --cc=kstewart@linuxfoundation.org \
    --cc=linux-efi@vger.kernel.org \
    --cc=linux-kbuild@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=manojgupta@google.com \
    --cc=mawilcox@microsoft.com \
    --cc=michal.lkml@markovi.net \
    --cc=mingo@redhat.com \
    --cc=mjg59@g \
    --cc=mka@chromium.org \
    --cc=ndesaulniers@google.com \
    --cc=rientjes@google.com \
    --cc=rostedt@goodmis.org \
    --cc=sedat.dilek@gmail.com \
    --cc=tglx@linutronix.de \
    --cc=thomas.lendacky@amd.com \
    --cc=tstellar@redhat.com \
    --cc=tweek@google.com \
    --cc=virtualization@lists.linux-foundation.org \
    --cc=will.deacon@arm.com \
    --cc=x86@kernel.org \
    --cc=yamada.masahiro@socionext.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox