From: "H. Peter Anvin" <hpa@zytor.com>
To: Nick Desaulniers <ndesaulniers@google.com>
Cc: Kate Stewart <kstewart@linuxfoundation.org>,
andrea.parri@amarulasolutions.com, linux-efi@vger.kernel.org,
brijesh.singh@amd.com, "J. Kiszka" <jan.kiszka@siemens.com>,
Josh Poimboeuf <jpoimboe@redhat.com>,
Will Deacon <will.deacon@arm.com>,
jarkko.sakkinen@linux.intel.com,
virtualization@lists.linux-foundation.org,
Masahiro Yamada <yamada.masahiro@socionext.com>,
Manoj Gupta <manojgupta@google.com>,
boris.ostrovsky@oracle.com, Thiebaud Weksteen <tweek@google.com>,
mawilcox@microsoft.com, x86@kernel.org, akataria@vmware.com,
Greg Hackmann <ghackmann@google.com>,
mingo@redhat.com, Alistair Strachan <astrachan@google.com>,
David Rientjes <rientjes@google.com>,
geert@linux-m68k.org, thomas.lendacky@amd.com,
Arnd Bergmann <arnd@arndb.de>,
Linux Kbuild mailing list <linux-kbuild@vger.kernel.org>,
Philippe Ombredanne <pombredanne@nexb.com>,
rostedt@goodmis.org, acme@redhat.co
Subject: Re: [PATCH v5 2/3] x86/asm: add _ASM_ARG* constants for argument registers to <asm/asm.h>
Date: Thu, 14 Jun 2018 17:17:23 -0700 [thread overview]
Message-ID: <deb5a074-b057-9388-4ab7-42295b5bb46c@zytor.com> (raw)
In-Reply-To: <CAKwvOdngs8k_T=nDKh8JYdAwwFoJRcCU0bZu0tJHQ+keZ5+RFQ@mail.gmail.com>
On 06/14/18 13:59, Nick Desaulniers wrote:
> On Thu, Jun 14, 2018 at 1:48 PM H. Peter Anvin <hpa@zytor.com> wrote:
>>
>> On 06/13/18 14:05, Nick Desaulniers wrote:
>>> From: "H. Peter Anvin" <hpa@linux.intel.com>
>>>
>>> i386 and x86-64 uses different registers for arguments; make them
>>> available so we don't have to #ifdef in the actual code.
>>>
>>> Native size and specified size (q, l, w, b) versions are provided.
>>>
>>> Suggested-by: Sedat Dilek <sedat.dilek@gmail.com>
>>> Signed-off-by: H. Peter Anvin <hpa@linux.intel.com>
>>> Signed-off-by: Nick Desaulniers <ndesaulniers@google.com>
>>
>> I still object to Suggested-by: here. Sedat did a correction, which is
>> a Reviewed-by:, but unless I'm completely out to sea, there was no
>> suggestion on Sedat's part of this; and I had certainly not seen it when
>> I wrote the code.
>
> I'm fine with changing it from a Suggested-by to a Reviewed-by. Can
> you do that when you apply the set, or should I send a v6?
>
I'm not handling patch mechanics for x86 at the moment.
-hpa
next prev parent reply other threads:[~2018-06-15 0:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20180613210518.113983-1-ndesaulniers@google.com>
[not found] ` <20180613210518.113983-3-ndesaulniers@google.com>
2018-06-14 20:47 ` [PATCH v5 2/3] x86/asm: add _ASM_ARG* constants for argument registers to <asm/asm.h> H. Peter Anvin
[not found] ` <CAKwvOdngs8k_T=nDKh8JYdAwwFoJRcCU0bZu0tJHQ+keZ5+RFQ@mail.gmail.com>
2018-06-15 0:17 ` H. Peter Anvin [this message]
[not found] ` <CAKwvOdmE-EHJY7tgzkhyQqNT3m3oWtd6iE3sWBTz19Rijzx4Ew@mail.gmail.com>
2018-06-21 12:28 ` Ingo Molnar
2018-06-19 15:03 ` [PATCH v5 0/3] extern inline native_save_fl for paravirt Juergen Gross
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=deb5a074-b057-9388-4ab7-42295b5bb46c@zytor.com \
--to=hpa@zytor.com \
--cc=acme@redhat.co \
--cc=akataria@vmware.com \
--cc=andrea.parri@amarulasolutions.com \
--cc=arnd@arndb.de \
--cc=astrachan@google.com \
--cc=boris.ostrovsky@oracle.com \
--cc=brijesh.singh@amd.com \
--cc=geert@linux-m68k.org \
--cc=ghackmann@google.com \
--cc=jan.kiszka@siemens.com \
--cc=jarkko.sakkinen@linux.intel.com \
--cc=jpoimboe@redhat.com \
--cc=kstewart@linuxfoundation.org \
--cc=linux-efi@vger.kernel.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=manojgupta@google.com \
--cc=mawilcox@microsoft.com \
--cc=mingo@redhat.com \
--cc=ndesaulniers@google.com \
--cc=pombredanne@nexb.com \
--cc=rientjes@google.com \
--cc=rostedt@goodmis.org \
--cc=thomas.lendacky@amd.com \
--cc=tweek@google.com \
--cc=virtualization@lists.linux-foundation.org \
--cc=will.deacon@arm.com \
--cc=x86@kernel.org \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox