[PATCH] vhost: Remove the unused variable.

[PATCH] vhost: Remove the unused variable.

[Tonghao Zhang]

The patch (7235acdb1) changed the way of the work
flushing in which the queued seq, done seq, and the
flushing are not used anymore. Then remove them now.

Fixes: 7235acdb1 ("vhost: simplify work flushing")
Cc: Jason Wang <jasowang@redhat.com>
Signed-off-by: Tonghao Zhang <xiangxia.m.yue@gmail.com>
---
 drivers/vhost/vhost.c | 1 -
 drivers/vhost/vhost.h | 4 ----
 2 files changed, 5 deletions(-)

diff --git a/drivers/vhost/vhost.c b/drivers/vhost/vhost.c
index 33ac2b186b85..9b04cad91d65 100644
--- a/drivers/vhost/vhost.c
+++ b/drivers/vhost/vhost.c
@@ -181,7 +181,6 @@ void vhost_work_init(struct vhost_work *work, vhost_work_fn_t fn)
 {
 	clear_bit(VHOST_WORK_QUEUED, &work->flags);
 	work->fn = fn;
-	init_waitqueue_head(&work->done);
 }
 EXPORT_SYMBOL_GPL(vhost_work_init);
 
diff --git a/drivers/vhost/vhost.h b/drivers/vhost/vhost.h
index 79c6e7a60a5e..749fe13e061c 100644
--- a/drivers/vhost/vhost.h
+++ b/drivers/vhost/vhost.h
@@ -20,10 +20,6 @@ typedef void (*vhost_work_fn_t)(struct vhost_work *work);
 struct vhost_work {
 	struct llist_node	  node;
 	vhost_work_fn_t		  fn;
-	wait_queue_head_t	  done;
-	int			  flushing;
-	unsigned		  queue_seq;
-	unsigned		  done_seq;
 	unsigned long		  flags;
 };
 
-- 
2.13.6

Re: [PATCH] vhost: Remove the unused variable.

[Jason Wang]

On 2018年01月09日 09:46, Tonghao Zhang wrote:
> The patch (7235acdb1) changed the way of the work
> flushing in which the queued seq, done seq, and the
> flushing are not used anymore. Then remove them now.
>
> Fixes: 7235acdb1 ("vhost: simplify work flushing")
> Cc: Jason Wang <jasowang@redhat.com>
> Signed-off-by: Tonghao Zhang <xiangxia.m.yue@gmail.com>
> ---
>   drivers/vhost/vhost.c | 1 -
>   drivers/vhost/vhost.h | 4 ----
>   2 files changed, 5 deletions(-)
>
> diff --git a/drivers/vhost/vhost.c b/drivers/vhost/vhost.c
> index 33ac2b186b85..9b04cad91d65 100644
> --- a/drivers/vhost/vhost.c
> +++ b/drivers/vhost/vhost.c
> @@ -181,7 +181,6 @@ void vhost_work_init(struct vhost_work *work, vhost_work_fn_t fn)
>   {
>   	clear_bit(VHOST_WORK_QUEUED, &work->flags);
>   	work->fn = fn;
> -	init_waitqueue_head(&work->done);
>   }
>   EXPORT_SYMBOL_GPL(vhost_work_init);
>   
> diff --git a/drivers/vhost/vhost.h b/drivers/vhost/vhost.h
> index 79c6e7a60a5e..749fe13e061c 100644
> --- a/drivers/vhost/vhost.h
> +++ b/drivers/vhost/vhost.h
> @@ -20,10 +20,6 @@ typedef void (*vhost_work_fn_t)(struct vhost_work *work);
>   struct vhost_work {
>   	struct llist_node	  node;
>   	vhost_work_fn_t		  fn;
> -	wait_queue_head_t	  done;
> -	int			  flushing;
> -	unsigned		  queue_seq;
> -	unsigned		  done_seq;
>   	unsigned long		  flags;
>   };
>   

Thanks for the patch, but please use get_maintainer.pl to cc correct 
list and maintainers.

You can add my Acked-by when reposting.

_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization