* [PATCH 00/75] drm/connector: Convert all drivers to atomic_create_state and remove reset
@ 2026-10-14 17:26 Maxime Ripard
2026-10-14 17:26 ` [PATCH 31/75] drm/qxl: Switch to drm_atomic_helper_connector_create_state Maxime Ripard
` (5 more replies)
0 siblings, 6 replies; 11+ messages in thread
From: Maxime Ripard @ 2026-10-14 17:26 UTC (permalink / raw)
To: Maarten Lankhorst, Thomas Zimmermann, David Airlie, Simona Vetter
Cc: dri-devel, Maxime Ripard, Aun-Ali Zaidi, Christian König,
Alex Deucher, amd-gfx, Harry Wentland, Leo Li, Rodrigo Siqueira,
Liviu Dudau, Andrew Jeffery, Joel Stanley, Dave Airlie,
Jocelyn Falempe, Francesco Dolcini, Ian Ray, Martyn Welch,
Peter Senna Tschudin, Russell King, Alim Akhtar, Inki Dae,
Krzysztof Kozlowski, Kyungmin Park, Peter Griffin, Seung-Woo Kim,
linux-samsung-soc, Alison Wang, Stefan Agner, Tian Tao,
Xinwei Kong, Yongbang Shi, Dexuan Cui, Long Li, Saurabh Sengar,
linux-hyperv, Fabio Estevam, Frank Li, Pengutronix Kernel Team,
Philipp Zabel, Sascha Hauer, imx, Paul Kocialkowski, Huacai Chen,
Icenowy Zheng, Jianmin Lv, Mingcong Bai, Qianhai Wu, Xi Ruoyao,
Abhinav Kumar, Dmitry Baryshkov, Jessica Zhang, Marijn Suijten,
Rob Clark, Sean Paul, freedreno, linux-arm-msm, Gerd Hoffmann,
spice-devel, virtualization, Geert Uytterhoeven,
linux-renesas-soc, Marcus Folkesson, Iker Pedrosa,
Javier Martinez Canillas, Alain Volmat, Raphael Gallais-Pou,
Alexandre Torgue, Maxime Coquelin, Philippe Cornu,
Raphael Gallais-Pou, Yannick Fertre, Chen-Yu Tsai, Samuel Holland,
linux-sunxi, Jonathan Hunter, Mikko Perttunen, Thierry Reding,
linux-tegra, Alexey Brodkin, Hans de Goede, LiangCheng Wang,
Alex Lanzano, Maíra Canal, Dave Stevenson,
Raspberry Pi Kernel Maintenance, Chia-I Wu, Dmitry Osipenko,
Gurchetan Singh, Haneen Mohammed, Louis Chauvet, Melissa Wen,
Oleksandr Andrushchenko, Ruben Wauters, Jerome Brunet,
Kevin Hilman, Martin Blumenstingl, linux-amlogic, Jani Nikula,
Joonas Lahtinen, Rodrigo Vivi, Tvrtko Ursulin, intel-gfx,
intel-xe, Danilo Krummrich, Lyude Paul, nouveau, Kieran Bingham,
Laurent Pinchart, Magnus Damm, Tomi Valkeinen,
Broadcom internal kernel review list, Zack Rusin, Aditya Garg
This is a follow-up to the plane and CRTC reset removal series, and
part of a larger effort to remove the reset hook from all KMS objects.
The connector reset hook is overloaded: it is called both at probe
time to create the initial software state and during suspend/resume to
reset hardware and software state. These two roles have different
requirements, and the reset hook is not fallible, making error
handling difficult for the initial state allocation path.
While reset has the semantics to reset both the software and hardware
state, the vast majority of implementations and all the helpers only
reset the software state, making them equivalent to
atomic_create_state in practice. The atomic_create_state hook makes
this explicit: it only allocates and initializes a pristine state
without any side effect, and returns the state pointer or an ERR_PTR
on failure.
This series converts all connector drivers tree-wide from the reset hook
to atomic_create_state, then removes the reset hook from struct
drm_connector_funcs entirely. The conversions were done using a
combination of Coccinelle semantic patches, mechanical one-line
replacements and manual adjustments.
Signed-off-by: Maxime Ripard <mripard@kernel.org>
---
Maxime Ripard (75):
drm/panel: Add atomic_create_state support
drm/adp: Switch to drm_atomic_helper_connector_create_state
drm/amdgpu: vkms: Switch to drm_atomic_helper_connector_create_state
drm/amdgpu: dm: Switch to drm_atomic_helper_connector_create_state
drm/arm: komeda: Switch to drm_atomic_helper_connector_create_state
drm/aspeed: Switch to drm_atomic_helper_connector_create_state
drm/ast: Switch to drm_atomic_helper_connector_create_state
drm/bridge: analogix-anx6345: Switch to drm_atomic_helper_connector_create_state
drm/bridge: analogix-anx78xx: Switch to drm_atomic_helper_connector_create_state
drm/bridge: chrontel-ch7033: Switch to drm_atomic_helper_connector_create_state
drm/bridge: lontium-lt8912b: Switch to drm_atomic_helper_connector_create_state
drm/bridge: megachips: Switch to drm_atomic_helper_connector_create_state
drm/bridge: nxp-ptn3460: Switch to drm_atomic_helper_connector_create_state
drm/panel: Switch to drm_atomic_helper_connector_create_state
drm/bridge: sii902x: Switch to drm_atomic_helper_connector_create_state
drm/bridge: simple-bridge: Switch to drm_atomic_helper_connector_create_state
drm/bridge: synopsys: dw-hdmi: Switch to drm_atomic_helper_connector_create_state
drm/bridge: tc358767: Switch to drm_atomic_helper_connector_create_state
drm/bridge: tda998x: Switch to drm_atomic_helper_connector_create_state
drm/bridge: ti-tfp410: Switch to drm_atomic_helper_connector_create_state
drm/exynos: Switch to drm_atomic_helper_connector_create_state
drm/fsl-dcu: Switch to drm_atomic_helper_connector_create_state
drm/hisilicon: hibmc: Switch to drm_atomic_helper_connector_create_state
drm/hyperv: Switch to drm_atomic_helper_connector_create_state
drm/imx: ipuv3: Switch to drm_atomic_helper_connector_create_state
drm/logicvc: Switch to drm_atomic_helper_connector_create_state
drm/loongson: Switch to drm_atomic_helper_connector_create_state
drm/mgag200: Switch to drm_atomic_helper_connector_create_state
drm/mipi-dbi: Switch to drm_atomic_helper_connector_create_state
drm/msm: dpu1: Switch to drm_atomic_helper_connector_create_state
drm/qxl: Switch to drm_atomic_helper_connector_create_state
drm/renesas: shmobile: Switch to drm_atomic_helper_connector_create_state
drm/sitronix: st7571: Switch to drm_atomic_helper_connector_create_state
drm/sitronix: st7920: Switch to drm_atomic_helper_connector_create_state
drm/solomon: ssd130x: Switch to drm_atomic_helper_connector_create_state
drm/sti: Switch to drm_atomic_helper_connector_create_state
drm/stm: Switch to drm_atomic_helper_connector_create_state
drm/sun4i: Switch to drm_atomic_helper_connector_create_state
drm/sysfb: Switch to drm_atomic_helper_connector_create_state
drm/tegra: Switch to drm_atomic_helper_connector_create_state
drm/tests: Switch to drm_atomic_helper_connector_create_state
drm/tiny: arcpgu: Switch to drm_atomic_helper_connector_create_state
drm/tiny: bochs: Switch to drm_atomic_helper_connector_create_state
drm/tiny: cirrus: Switch to drm_atomic_helper_connector_create_state
drm/tiny: gm12u320: Switch to drm_atomic_helper_connector_create_state
drm/tiny: pixpaper: Switch to drm_atomic_helper_connector_create_state
drm/tiny: repaper: Switch to drm_atomic_helper_connector_create_state
drm/tiny: sharp: Switch to drm_atomic_helper_connector_create_state
drm/udl: Switch to drm_atomic_helper_connector_create_state
drm/vboxvideo: Switch to drm_atomic_helper_connector_create_state
drm/vc4: Switch to drm_atomic_helper_connector_create_state
drm/virtio: Switch to drm_atomic_helper_connector_create_state
drm/vkms: Switch to drm_atomic_helper_connector_create_state
drm/xen: Switch to drm_atomic_helper_connector_create_state
drm/atomic-state-helper: Rename connector_tv_margins_reset to state_init
drm/atomic-state-helper: Rename connector_tv_reset to state_init
drm/bridge: synopsys: dw-hdmi: Convert to atomic_create_state
drm/meson: Convert to atomic_create_state
drm/gud: Convert to atomic_create_state
drm/sun4i: hdmi: Convert to atomic_create_state
drm/sun4i: tv: Convert to atomic_create_state
drm/tests: hdmi: Convert to atomic_create_state
drm/vc4: hdmi: Convert to atomic_create_state
drm/vc4: vec: Convert to atomic_create_state
drm/connector: Remove drm_atomic_helper_connector_reset()
drm/amdgpu: dm: Convert to atomic_create_state
drm/malidp: Convert to atomic_create_state
drm/ast: Convert to atomic_create_state
drm/i915: Convert to atomic_create_state
drm/nouveau: Convert to atomic_create_state
drm/rcar-du: Convert to atomic_create_state
drm/tegra: Convert to atomic_create_state
drm/vmwgfx: Convert to atomic_create_state
drm/connector: Remove __drm_atomic_helper_connector_reset()
drm/connector: Remove reset
drivers/gpu/drm/amd/amdgpu/amdgpu_vkms.c | 2 +-
.../amd/display/amdgpu_dm/amdgpu_dm_connector.c | 32 ++++----
.../amd/display/amdgpu_dm/amdgpu_dm_connector.h | 3 +-
.../amd/display/amdgpu_dm/amdgpu_dm_mst_types.c | 4 +-
.../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_wb.c | 14 +++-
.../display/amdgpu_dm/tests/amdgpu_dm_audio_test.c | 2 +-
.../amdgpu_dm/tests/amdgpu_dm_backlight_test.c | 2 +-
.../amdgpu_dm/tests/amdgpu_dm_connector_test.c | 90 ++++++++++++++--------
.../display/amdgpu_dm/tests/amdgpu_dm_crc_test.c | 7 +-
.../amdgpu_dm/tests/amdgpu_dm_helpers_test.c | 2 +-
.../display/amdgpu_dm/tests/amdgpu_dm_irq_test.c | 2 +-
.../amdgpu_dm/tests/amdgpu_dm_mst_types_test.c | 4 +-
.../display/amdgpu_dm/tests/amdgpu_dm_wb_test.c | 2 +-
.../drm/arm/display/komeda/komeda_wb_connector.c | 2 +-
drivers/gpu/drm/arm/malidp_mw.c | 18 ++---
drivers/gpu/drm/aspeed/aspeed_gfx_out.c | 2 +-
drivers/gpu/drm/ast/ast_dp.c | 19 ++---
drivers/gpu/drm/ast/ast_dp501.c | 2 +-
drivers/gpu/drm/ast/ast_sil164.c | 2 +-
drivers/gpu/drm/ast/ast_vga.c | 2 +-
drivers/gpu/drm/bridge/analogix/analogix-anx6345.c | 2 +-
drivers/gpu/drm/bridge/analogix/analogix-anx78xx.c | 2 +-
drivers/gpu/drm/bridge/chrontel-ch7033.c | 2 +-
drivers/gpu/drm/bridge/lontium-lt8912b.c | 2 +-
.../drm/bridge/megachips-stdpxxxx-ge-b850v3-fw.c | 2 +-
drivers/gpu/drm/bridge/nxp-ptn3460.c | 2 +-
drivers/gpu/drm/bridge/sii902x.c | 2 +-
drivers/gpu/drm/bridge/simple-bridge.c | 2 +-
drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 12 ++-
drivers/gpu/drm/bridge/tc358767.c | 2 +-
drivers/gpu/drm/bridge/tda998x_drv.c | 2 +-
drivers/gpu/drm/bridge/ti-tfp410.c | 2 +-
drivers/gpu/drm/display/drm_hdmi_state_helper.c | 3 +-
drivers/gpu/drm/drm_atomic_state_helper.c | 68 ++++------------
drivers/gpu/drm/drm_connector.c | 8 --
drivers/gpu/drm/drm_mode_config.c | 4 +-
drivers/gpu/drm/drm_panel.c | 14 +++-
drivers/gpu/drm/exynos/exynos_drm_dpi.c | 2 +-
drivers/gpu/drm/exynos/exynos_drm_vidi.c | 2 +-
drivers/gpu/drm/exynos/exynos_hdmi.c | 2 +-
drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_rgb.c | 2 +-
drivers/gpu/drm/gud/gud_connector.c | 20 +++--
drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_dp.c | 2 +-
drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_vdac.c | 2 +-
drivers/gpu/drm/hyperv/hyperv_drm_modeset.c | 2 +-
drivers/gpu/drm/i915/display/intel_connector.c | 6 +-
drivers/gpu/drm/i915/display/intel_sdvo.c | 6 +-
drivers/gpu/drm/imx/ipuv3/imx-tve.c | 2 +-
drivers/gpu/drm/logicvc/logicvc_interface.c | 2 +-
drivers/gpu/drm/loongson/lsdc_output_7a1000.c | 2 +-
drivers/gpu/drm/loongson/lsdc_output_7a2000.c | 4 +-
drivers/gpu/drm/meson/meson_encoder_hdmi.c | 12 ++-
drivers/gpu/drm/mgag200/mgag200_vga.c | 2 +-
drivers/gpu/drm/mgag200/mgag200_vga_bmc.c | 2 +-
drivers/gpu/drm/msm/disp/dpu1/dpu_writeback.c | 2 +-
drivers/gpu/drm/nouveau/dispnv50/disp.c | 9 ++-
drivers/gpu/drm/nouveau/nouveau_connector.c | 25 +++---
drivers/gpu/drm/nouveau/nouveau_connector.h | 3 +-
drivers/gpu/drm/qxl/qxl_display.c | 2 +-
.../gpu/drm/renesas/rcar-du/rcar_du_writeback.c | 15 ++--
drivers/gpu/drm/renesas/shmobile/shmob_drm_crtc.c | 2 +-
drivers/gpu/drm/sitronix/st7571.c | 2 +-
drivers/gpu/drm/sitronix/st7920.c | 2 +-
drivers/gpu/drm/solomon/ssd130x.c | 2 +-
drivers/gpu/drm/sti/sti_dvo.c | 2 +-
drivers/gpu/drm/sti/sti_hda.c | 2 +-
drivers/gpu/drm/sti/sti_hdmi.c | 2 +-
drivers/gpu/drm/stm/lvds.c | 2 +-
drivers/gpu/drm/sun4i/sun4i_hdmi_enc.c | 17 +++-
drivers/gpu/drm/sun4i/sun4i_lvds.c | 2 +-
drivers/gpu/drm/sun4i/sun4i_rgb.c | 2 +-
drivers/gpu/drm/sun4i/sun4i_tv.c | 16 +++-
drivers/gpu/drm/sun4i/sun6i_mipi_dsi.c | 2 +-
drivers/gpu/drm/sysfb/drm_sysfb_helper.h | 2 +-
drivers/gpu/drm/tegra/dsi.c | 17 ++--
drivers/gpu/drm/tegra/hdmi.c | 2 +-
drivers/gpu/drm/tegra/sor.c | 13 ++--
drivers/gpu/drm/tests/drm_atomic_commit_test.c | 2 +-
drivers/gpu/drm/tests/drm_atomic_test.c | 2 +-
drivers/gpu/drm/tests/drm_connector_test.c | 4 +-
drivers/gpu/drm/tests/drm_hdmi_state_helper_test.c | 17 +++-
drivers/gpu/drm/tests/drm_probe_helper_test.c | 2 +-
drivers/gpu/drm/tiny/appletbdrm.c | 2 +-
drivers/gpu/drm/tiny/arcpgu.c | 2 +-
drivers/gpu/drm/tiny/bochs.c | 2 +-
drivers/gpu/drm/tiny/cirrus-qemu.c | 2 +-
drivers/gpu/drm/tiny/gm12u320.c | 2 +-
drivers/gpu/drm/tiny/pixpaper.c | 2 +-
drivers/gpu/drm/tiny/repaper.c | 2 +-
drivers/gpu/drm/tiny/sharp-memory.c | 2 +-
drivers/gpu/drm/udl/udl_modeset.c | 2 +-
drivers/gpu/drm/vboxvideo/vbox_mode.c | 2 +-
drivers/gpu/drm/vc4/tests/vc4_mock_output.c | 2 +-
drivers/gpu/drm/vc4/vc4_hdmi.c | 32 ++++++--
drivers/gpu/drm/vc4/vc4_txp.c | 2 +-
drivers/gpu/drm/vc4/vc4_vec.c | 16 +++-
drivers/gpu/drm/virtio/virtgpu_display.c | 2 +-
drivers/gpu/drm/vkms/vkms_connector.c | 2 +-
drivers/gpu/drm/vkms/vkms_writeback.c | 2 +-
drivers/gpu/drm/vmwgfx/vmwgfx_kms.c | 23 ++----
drivers/gpu/drm/vmwgfx/vmwgfx_kms.h | 3 +-
drivers/gpu/drm/vmwgfx/vmwgfx_ldu.c | 2 +-
drivers/gpu/drm/vmwgfx/vmwgfx_scrn.c | 2 +-
drivers/gpu/drm/vmwgfx/vmwgfx_stdu.c | 2 +-
drivers/gpu/drm/xen/xen_drm_front_conn.c | 2 +-
include/drm/drm_atomic_state_helper.h | 9 +--
include/drm/drm_connector.h | 12 ---
include/drm/drm_mipi_dbi.h | 2 +-
108 files changed, 392 insertions(+), 331 deletions(-)
---
base-commit: 91f52e99824b0beebb48cad51bbda81437af8664
change-id: 20260709-drm-no-more-connector-reset-45ee14d7c62c
Best regards,
--
Maxime Ripard <mripard@kernel.org>
^ permalink raw reply [flat|nested] 11+ messages in thread
* [PATCH 31/75] drm/qxl: Switch to drm_atomic_helper_connector_create_state
2026-10-14 17:26 [PATCH 00/75] drm/connector: Convert all drivers to atomic_create_state and remove reset Maxime Ripard
@ 2026-10-14 17:26 ` Maxime Ripard
2026-10-14 17:53 ` sashiko-bot
2026-10-14 17:27 ` [PATCH 43/75] drm/tiny: bochs: " Maxime Ripard
` (4 subsequent siblings)
5 siblings, 1 reply; 11+ messages in thread
From: Maxime Ripard @ 2026-10-14 17:26 UTC (permalink / raw)
To: Maarten Lankhorst, Thomas Zimmermann, David Airlie, Simona Vetter
Cc: dri-devel, Maxime Ripard, Dave Airlie, Gerd Hoffmann, spice-devel,
virtualization
The qxl connector implementation uses the deprecated
drm_atomic_helper_connector_reset() as its reset hook.
Switch to drm_atomic_helper_connector_create_state() instead.
Signed-off-by: Maxime Ripard <mripard@kernel.org>
---
Cc: Dave Airlie <airlied@redhat.com>
Cc: Gerd Hoffmann <kraxel@redhat.com>
Cc: spice-devel@lists.freedesktop.org
Cc: virtualization@lists.linux.dev
---
drivers/gpu/drm/qxl/qxl_display.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/qxl/qxl_display.c b/drivers/gpu/drm/qxl/qxl_display.c
index 63fc7c6a7f1a..204c47d61373 100644
--- a/drivers/gpu/drm/qxl/qxl_display.c
+++ b/drivers/gpu/drm/qxl/qxl_display.c
@@ -1139,11 +1139,11 @@ static void qxl_conn_destroy(struct drm_connector *connector)
static const struct drm_connector_funcs qxl_connector_funcs = {
.detect = qxl_conn_detect,
.fill_modes = drm_helper_probe_single_connector_modes,
.destroy = qxl_conn_destroy,
- .reset = drm_atomic_helper_connector_reset,
+ .atomic_create_state = drm_atomic_helper_connector_create_state,
.atomic_duplicate_state = drm_atomic_helper_connector_duplicate_state,
.atomic_destroy_state = drm_atomic_helper_connector_destroy_state,
};
static int qxl_mode_create_hotplug_mode_update_property(struct qxl_device *qdev)
--
2.55.0
^ permalink raw reply related [flat|nested] 11+ messages in thread
* [PATCH 43/75] drm/tiny: bochs: Switch to drm_atomic_helper_connector_create_state
2026-10-14 17:26 [PATCH 00/75] drm/connector: Convert all drivers to atomic_create_state and remove reset Maxime Ripard
2026-10-14 17:26 ` [PATCH 31/75] drm/qxl: Switch to drm_atomic_helper_connector_create_state Maxime Ripard
@ 2026-10-14 17:27 ` Maxime Ripard
2026-10-14 17:56 ` sashiko-bot
2026-10-14 17:27 ` [PATCH 44/75] drm/tiny: cirrus: " Maxime Ripard
` (3 subsequent siblings)
5 siblings, 1 reply; 11+ messages in thread
From: Maxime Ripard @ 2026-10-14 17:27 UTC (permalink / raw)
To: Maarten Lankhorst, Thomas Zimmermann, David Airlie, Simona Vetter
Cc: dri-devel, Maxime Ripard, Gerd Hoffmann, virtualization
The tiny: bochs connector implementation uses the deprecated
drm_atomic_helper_connector_reset() as its reset hook.
Switch to drm_atomic_helper_connector_create_state() instead.
Signed-off-by: Maxime Ripard <mripard@kernel.org>
---
Cc: Gerd Hoffmann <kraxel@redhat.com>
Cc: virtualization@lists.linux.dev
---
drivers/gpu/drm/tiny/bochs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/tiny/bochs.c b/drivers/gpu/drm/tiny/bochs.c
index 8192decddbc1..771d59b92f67 100644
--- a/drivers/gpu/drm/tiny/bochs.c
+++ b/drivers/gpu/drm/tiny/bochs.c
@@ -590,11 +590,11 @@ static const struct drm_connector_helper_funcs bochs_connector_helper_funcs = {
};
static const struct drm_connector_funcs bochs_connector_funcs = {
.fill_modes = drm_helper_probe_single_connector_modes,
.destroy = drm_connector_cleanup,
- .reset = drm_atomic_helper_connector_reset,
+ .atomic_create_state = drm_atomic_helper_connector_create_state,
.atomic_duplicate_state = drm_atomic_helper_connector_duplicate_state,
.atomic_destroy_state = drm_atomic_helper_connector_destroy_state,
};
static enum drm_mode_status bochs_mode_config_mode_valid(struct drm_device *dev,
--
2.55.0
^ permalink raw reply related [flat|nested] 11+ messages in thread
* [PATCH 44/75] drm/tiny: cirrus: Switch to drm_atomic_helper_connector_create_state
2026-10-14 17:26 [PATCH 00/75] drm/connector: Convert all drivers to atomic_create_state and remove reset Maxime Ripard
2026-10-14 17:26 ` [PATCH 31/75] drm/qxl: Switch to drm_atomic_helper_connector_create_state Maxime Ripard
2026-10-14 17:27 ` [PATCH 43/75] drm/tiny: bochs: " Maxime Ripard
@ 2026-10-14 17:27 ` Maxime Ripard
2026-10-14 17:57 ` sashiko-bot
2026-10-14 17:27 ` [PATCH 52/75] drm/virtio: " Maxime Ripard
` (2 subsequent siblings)
5 siblings, 1 reply; 11+ messages in thread
From: Maxime Ripard @ 2026-10-14 17:27 UTC (permalink / raw)
To: Maarten Lankhorst, Thomas Zimmermann, David Airlie, Simona Vetter
Cc: dri-devel, Maxime Ripard, Dave Airlie, Gerd Hoffmann,
virtualization
The tiny: cirrus connector implementation uses the deprecated
drm_atomic_helper_connector_reset() as its reset hook.
Switch to drm_atomic_helper_connector_create_state() instead.
Signed-off-by: Maxime Ripard <mripard@kernel.org>
---
Cc: Dave Airlie <airlied@redhat.com>
Cc: Gerd Hoffmann <kraxel@redhat.com>
Cc: virtualization@lists.linux.dev
---
drivers/gpu/drm/tiny/cirrus-qemu.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/tiny/cirrus-qemu.c b/drivers/gpu/drm/tiny/cirrus-qemu.c
index 63c242e25662..9e3051b9c3f7 100644
--- a/drivers/gpu/drm/tiny/cirrus-qemu.c
+++ b/drivers/gpu/drm/tiny/cirrus-qemu.c
@@ -448,11 +448,11 @@ static const struct drm_connector_helper_funcs cirrus_connector_helper_funcs = {
};
static const struct drm_connector_funcs cirrus_connector_funcs = {
.fill_modes = drm_helper_probe_single_connector_modes,
.destroy = drm_connector_cleanup,
- .reset = drm_atomic_helper_connector_reset,
+ .atomic_create_state = drm_atomic_helper_connector_create_state,
.atomic_duplicate_state = drm_atomic_helper_connector_duplicate_state,
.atomic_destroy_state = drm_atomic_helper_connector_destroy_state,
};
static int cirrus_pipe_init(struct cirrus_device *cirrus)
--
2.55.0
^ permalink raw reply related [flat|nested] 11+ messages in thread
* [PATCH 52/75] drm/virtio: Switch to drm_atomic_helper_connector_create_state
2026-10-14 17:26 [PATCH 00/75] drm/connector: Convert all drivers to atomic_create_state and remove reset Maxime Ripard
` (2 preceding siblings ...)
2026-10-14 17:27 ` [PATCH 44/75] drm/tiny: cirrus: " Maxime Ripard
@ 2026-10-14 17:27 ` Maxime Ripard
2026-10-14 18:10 ` sashiko-bot
2026-10-16 15:06 ` (subset) [PATCH 00/75] drm/connector: Convert all drivers to atomic_create_state and remove reset Maxime Ripard
2026-10-16 15:12 ` Maxime Ripard
5 siblings, 1 reply; 11+ messages in thread
From: Maxime Ripard @ 2026-10-14 17:27 UTC (permalink / raw)
To: Maarten Lankhorst, Thomas Zimmermann, David Airlie, Simona Vetter
Cc: dri-devel, Maxime Ripard, Chia-I Wu, David Airlie,
Dmitry Osipenko, Gerd Hoffmann, Gurchetan Singh, virtualization
The virtio connector implementation uses the deprecated
drm_atomic_helper_connector_reset() as its reset hook.
Switch to drm_atomic_helper_connector_create_state() instead.
Signed-off-by: Maxime Ripard <mripard@kernel.org>
---
Cc: Chia-I Wu <olvaffe@gmail.com>
Cc: David Airlie <airlied@redhat.com>
Cc: Dmitry Osipenko <dmitry.osipenko@collabora.com>
Cc: Gerd Hoffmann <kraxel@redhat.com>
Cc: Gurchetan Singh <gurchetansingh@chromium.org>
Cc: virtualization@lists.linux.dev
---
drivers/gpu/drm/virtio/virtgpu_display.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/virtio/virtgpu_display.c b/drivers/gpu/drm/virtio/virtgpu_display.c
index b60aab07e78d..f0ed9bd27a91 100644
--- a/drivers/gpu/drm/virtio/virtgpu_display.c
+++ b/drivers/gpu/drm/virtio/virtgpu_display.c
@@ -268,11 +268,11 @@ static void virtio_gpu_conn_destroy(struct drm_connector *connector)
static const struct drm_connector_funcs virtio_gpu_connector_funcs = {
.detect = virtio_gpu_conn_detect,
.fill_modes = drm_helper_probe_single_connector_modes,
.destroy = virtio_gpu_conn_destroy,
- .reset = drm_atomic_helper_connector_reset,
+ .atomic_create_state = drm_atomic_helper_connector_create_state,
.atomic_duplicate_state = drm_atomic_helper_connector_duplicate_state,
.atomic_destroy_state = drm_atomic_helper_connector_destroy_state,
};
static int vgdev_output_init(struct virtio_gpu_device *vgdev, int index)
--
2.55.0
^ permalink raw reply related [flat|nested] 11+ messages in thread
* Re: [PATCH 31/75] drm/qxl: Switch to drm_atomic_helper_connector_create_state
2026-10-14 17:26 ` [PATCH 31/75] drm/qxl: Switch to drm_atomic_helper_connector_create_state Maxime Ripard
@ 2026-10-14 17:53 ` sashiko-bot
0 siblings, 0 replies; 11+ messages in thread
From: sashiko-bot @ 2026-10-14 17:53 UTC (permalink / raw)
To: Maxime Ripard; +Cc: virtualization, Michael S. Tsirkin, Eugenio Perez
> The qxl connector implementation uses the deprecated
> drm_atomic_helper_connector_reset() as its reset hook.
>
> Switch to drm_atomic_helper_connector_create_state() instead.
>
> Signed-off-by: Maxime Ripard <mripard@kernel.org>
Sashiko has reviewed this patch and found no issues. It looks great!
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261014-drm-no-more-connector-reset-v1-0-586c9c026823@kernel.org?part=31
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH 43/75] drm/tiny: bochs: Switch to drm_atomic_helper_connector_create_state
2026-10-14 17:27 ` [PATCH 43/75] drm/tiny: bochs: " Maxime Ripard
@ 2026-10-14 17:56 ` sashiko-bot
0 siblings, 0 replies; 11+ messages in thread
From: sashiko-bot @ 2026-10-14 17:56 UTC (permalink / raw)
To: Maxime Ripard; +Cc: virtualization, Michael S. Tsirkin, Eugenio Perez
> The tiny: bochs connector implementation uses the deprecated
> drm_atomic_helper_connector_reset() as its reset hook.
>
> Switch to drm_atomic_helper_connector_create_state() instead.
>
> Signed-off-by: Maxime Ripard <mripard@kernel.org>
Sashiko has reviewed this patch and found no issues. It looks great!
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261014-drm-no-more-connector-reset-v1-0-586c9c026823@kernel.org?part=43
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH 44/75] drm/tiny: cirrus: Switch to drm_atomic_helper_connector_create_state
2026-10-14 17:27 ` [PATCH 44/75] drm/tiny: cirrus: " Maxime Ripard
@ 2026-10-14 17:57 ` sashiko-bot
0 siblings, 0 replies; 11+ messages in thread
From: sashiko-bot @ 2026-10-14 17:57 UTC (permalink / raw)
To: Maxime Ripard; +Cc: virtualization, Michael S. Tsirkin, Eugenio Perez
> The tiny: cirrus connector implementation uses the deprecated
> drm_atomic_helper_connector_reset() as its reset hook.
>
> Switch to drm_atomic_helper_connector_create_state() instead.
>
> Signed-off-by: Maxime Ripard <mripard@kernel.org>
Sashiko has reviewed this patch and found no issues. It looks great!
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261014-drm-no-more-connector-reset-v1-0-586c9c026823@kernel.org?part=44
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH 52/75] drm/virtio: Switch to drm_atomic_helper_connector_create_state
2026-10-14 17:27 ` [PATCH 52/75] drm/virtio: " Maxime Ripard
@ 2026-10-14 18:10 ` sashiko-bot
0 siblings, 0 replies; 11+ messages in thread
From: sashiko-bot @ 2026-10-14 18:10 UTC (permalink / raw)
To: Maxime Ripard; +Cc: virtualization, Michael S. Tsirkin, Eugenio Perez
> The virtio connector implementation uses the deprecated
> drm_atomic_helper_connector_reset() as its reset hook.
>
> Switch to drm_atomic_helper_connector_create_state() instead.
>
> Signed-off-by: Maxime Ripard <mripard@kernel.org>
Sashiko has reviewed this patch and found no issues. It looks great!
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261014-drm-no-more-connector-reset-v1-0-586c9c026823@kernel.org?part=52
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: (subset) [PATCH 00/75] drm/connector: Convert all drivers to atomic_create_state and remove reset
2026-10-14 17:26 [PATCH 00/75] drm/connector: Convert all drivers to atomic_create_state and remove reset Maxime Ripard
` (3 preceding siblings ...)
2026-10-14 17:27 ` [PATCH 52/75] drm/virtio: " Maxime Ripard
@ 2026-10-16 15:06 ` Maxime Ripard
2026-10-16 15:12 ` Maxime Ripard
5 siblings, 0 replies; 11+ messages in thread
From: Maxime Ripard @ 2026-10-16 15:06 UTC (permalink / raw)
To: Maarten Lankhorst, Thomas Zimmermann, David Airlie, Simona Vetter,
Maxime Ripard
Cc: dri-devel, Aun-Ali Zaidi, Christian König, Alex Deucher,
amd-gfx, Harry Wentland, Leo Li, Rodrigo Siqueira, Liviu Dudau,
Andrew Jeffery, Joel Stanley, Dave Airlie, Jocelyn Falempe,
Francesco Dolcini, Ian Ray, Martyn Welch, Peter Senna Tschudin,
Russell King, Alim Akhtar, Inki Dae, Krzysztof Kozlowski,
Kyungmin Park, Peter Griffin, Seung-Woo Kim, linux-samsung-soc,
Alison Wang, Stefan Agner, Tian Tao, Xinwei Kong, Yongbang Shi,
Dexuan Cui, Long Li, Saurabh Sengar, linux-hyperv, Fabio Estevam,
Frank Li, Pengutronix Kernel Team, Philipp Zabel, Sascha Hauer,
imx, Paul Kocialkowski, Huacai Chen, Icenowy Zheng, Jianmin Lv,
Mingcong Bai, Qianhai Wu, Xi Ruoyao, Abhinav Kumar,
Dmitry Baryshkov, Jessica Zhang, Marijn Suijten, Rob Clark,
Sean Paul, freedreno, linux-arm-msm, Gerd Hoffmann, spice-devel,
virtualization, Geert Uytterhoeven, linux-renesas-soc,
Marcus Folkesson, Iker Pedrosa, Javier Martinez Canillas,
Alain Volmat, Raphael Gallais-Pou, Alexandre Torgue,
Maxime Coquelin, Philippe Cornu, Raphael Gallais-Pou,
Yannick Fertre, Chen-Yu Tsai, Samuel Holland, linux-sunxi,
Jonathan Hunter, Mikko Perttunen, Thierry Reding, linux-tegra,
Alexey Brodkin, Hans de Goede, LiangCheng Wang, Alex Lanzano,
Maíra Canal, Dave Stevenson, Raspberry Pi Kernel Maintenance,
Chia-I Wu, Dmitry Osipenko, Gurchetan Singh, Haneen Mohammed,
Louis Chauvet, Melissa Wen, Oleksandr Andrushchenko,
Ruben Wauters, Jerome Brunet, Kevin Hilman, Martin Blumenstingl,
linux-amlogic, Jani Nikula, Joonas Lahtinen, Rodrigo Vivi,
Tvrtko Ursulin, intel-gfx, intel-xe, Danilo Krummrich, Lyude Paul,
nouveau, Kieran Bingham, Laurent Pinchart, Magnus Damm,
Tomi Valkeinen, Broadcom internal kernel review list, Zack Rusin,
Aditya Garg
On Wed, 14 Oct 2026 19:26:23 +0200, Maxime Ripard wrote:
> This is a follow-up to the plane and CRTC reset removal series, and
> part of a larger effort to remove the reset hook from all KMS objects.
>
> The connector reset hook is overloaded: it is called both at probe
> time to create the initial software state and during suspend/resume to
> reset hardware and software state. These two roles have different
> requirements, and the reset hook is not fallible, making error
> handling difficult for the initial state allocation path.
>
> [...]
Applied to misc/kernel.git (drm-misc-next)
[05/75] drm/arm: komeda: Switch to drm_atomic_helper_connector_create_state
commit: 849b1119cb1f429667bf3e79cba86ad397087ab7
[11/75] drm/bridge: lontium-lt8912b: Switch to drm_atomic_helper_connector_create_state
commit: 80512a4f295c52caf1394677d9c80738b68c8831
[12/75] drm/bridge: megachips: Switch to drm_atomic_helper_connector_create_state
commit: 9a4a55df74880acf7c2b954d6011aab579db5f5e
[24/75] drm/hyperv: Switch to drm_atomic_helper_connector_create_state
commit: 7b9c28149a291451ada4c3e9fc7fd2ae13f36bc5
[25/75] drm/imx: ipuv3: Switch to drm_atomic_helper_connector_create_state
commit: 75da1ba5a3c36dca76206ec8e90bebcfc3641c64
[35/75] drm/solomon: ssd130x: Switch to drm_atomic_helper_connector_create_state
commit: 9ec42580ccceb54bd8e0b044729a98e4f345b522
[39/75] drm/sysfb: Switch to drm_atomic_helper_connector_create_state
commit: af36b2313c54e10b832298033b8be2fd50746c96
[51/75] drm/vc4: Switch to drm_atomic_helper_connector_create_state
commit: c81e4d88c3ed73483a99a90f56cc80c80eebc863
[67/75] drm/malidp: Convert to atomic_create_state
commit: 8b32d0652db9bb6b01055311e1cce5e3c4b70137
Thanks!
Maxime
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: (subset) [PATCH 00/75] drm/connector: Convert all drivers to atomic_create_state and remove reset
2026-10-14 17:26 [PATCH 00/75] drm/connector: Convert all drivers to atomic_create_state and remove reset Maxime Ripard
` (4 preceding siblings ...)
2026-10-16 15:06 ` (subset) [PATCH 00/75] drm/connector: Convert all drivers to atomic_create_state and remove reset Maxime Ripard
@ 2026-10-16 15:12 ` Maxime Ripard
5 siblings, 0 replies; 11+ messages in thread
From: Maxime Ripard @ 2026-10-16 15:12 UTC (permalink / raw)
To: Maarten Lankhorst, Thomas Zimmermann, David Airlie, Simona Vetter,
Maxime Ripard
Cc: dri-devel, Aun-Ali Zaidi, Christian König, Alex Deucher,
amd-gfx, Harry Wentland, Leo Li, Rodrigo Siqueira, Liviu Dudau,
Andrew Jeffery, Joel Stanley, Dave Airlie, Jocelyn Falempe,
Francesco Dolcini, Ian Ray, Martyn Welch, Peter Senna Tschudin,
Russell King, Alim Akhtar, Inki Dae, Krzysztof Kozlowski,
Kyungmin Park, Peter Griffin, Seung-Woo Kim, linux-samsung-soc,
Alison Wang, Stefan Agner, Tian Tao, Xinwei Kong, Yongbang Shi,
Dexuan Cui, Long Li, Saurabh Sengar, linux-hyperv, Fabio Estevam,
Frank Li, Pengutronix Kernel Team, Philipp Zabel, Sascha Hauer,
imx, Paul Kocialkowski, Huacai Chen, Icenowy Zheng, Jianmin Lv,
Mingcong Bai, Qianhai Wu, Xi Ruoyao, Abhinav Kumar,
Dmitry Baryshkov, Jessica Zhang, Marijn Suijten, Rob Clark,
Sean Paul, freedreno, linux-arm-msm, Gerd Hoffmann, spice-devel,
virtualization, Geert Uytterhoeven, linux-renesas-soc,
Marcus Folkesson, Iker Pedrosa, Javier Martinez Canillas,
Alain Volmat, Raphael Gallais-Pou, Alexandre Torgue,
Maxime Coquelin, Philippe Cornu, Raphael Gallais-Pou,
Yannick Fertre, Chen-Yu Tsai, Samuel Holland, linux-sunxi,
Jonathan Hunter, Mikko Perttunen, Thierry Reding, linux-tegra,
Alexey Brodkin, Hans de Goede, LiangCheng Wang, Alex Lanzano,
Maíra Canal, Dave Stevenson, Raspberry Pi Kernel Maintenance,
Chia-I Wu, Dmitry Osipenko, Gurchetan Singh, Haneen Mohammed,
Louis Chauvet, Melissa Wen, Oleksandr Andrushchenko,
Ruben Wauters, Jerome Brunet, Kevin Hilman, Martin Blumenstingl,
linux-amlogic, Jani Nikula, Joonas Lahtinen, Rodrigo Vivi,
Tvrtko Ursulin, intel-gfx, intel-xe, Danilo Krummrich, Lyude Paul,
nouveau, Kieran Bingham, Laurent Pinchart, Magnus Damm,
Tomi Valkeinen, Broadcom internal kernel review list, Zack Rusin,
Aditya Garg
On Wed, 14 Oct 2026 19:26:23 +0200, Maxime Ripard wrote:
> This is a follow-up to the plane and CRTC reset removal series, and
> part of a larger effort to remove the reset hook from all KMS objects.
>
> The connector reset hook is overloaded: it is called both at probe
> time to create the initial software state and during suspend/resume to
> reset hardware and software state. These two roles have different
> requirements, and the reset hook is not fallible, making error
> handling difficult for the initial state allocation path.
>
> [...]
Applied to misc/kernel.git (drm-misc-next)
[02/75] drm/adp: Switch to drm_atomic_helper_connector_create_state
commit: db1de27aca30ebaad04aea74ac21e4c4fb531a37
Thanks!
Maxime
^ permalink raw reply [flat|nested] 11+ messages in thread
end of thread, other threads:[~2026-10-16 15:12 UTC | newest]
Thread overview: 11+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-10-14 17:26 [PATCH 00/75] drm/connector: Convert all drivers to atomic_create_state and remove reset Maxime Ripard
2026-10-14 17:26 ` [PATCH 31/75] drm/qxl: Switch to drm_atomic_helper_connector_create_state Maxime Ripard
2026-10-14 17:53 ` sashiko-bot
2026-10-14 17:27 ` [PATCH 43/75] drm/tiny: bochs: " Maxime Ripard
2026-10-14 17:56 ` sashiko-bot
2026-10-14 17:27 ` [PATCH 44/75] drm/tiny: cirrus: " Maxime Ripard
2026-10-14 17:57 ` sashiko-bot
2026-10-14 17:27 ` [PATCH 52/75] drm/virtio: " Maxime Ripard
2026-10-14 18:10 ` sashiko-bot
2026-10-16 15:06 ` (subset) [PATCH 00/75] drm/connector: Convert all drivers to atomic_create_state and remove reset Maxime Ripard
2026-10-16 15:12 ` Maxime Ripard
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox