Linux virtualization list
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Joonho Lee" <mynameisjune111@gmail.com>
Cc: virtualization@lists.linux.dev,
	"Michael S. Tsirkin" <mst@redhat.com>,
	"Eugenio Perez" <eperezma@redhat.com>
Subject: Re: [PATCH v6 12/14] ALSA: virtio: complete control transitions and preserve drain tail
Date: Wed, 28 Oct 2026 03:06:42 +0000	[thread overview]
Message-ID: <sashiko-outbox-187378@kernel.org> (raw)
In-Reply-To: <20261028025317.92450-13-mynameisjune111@gmail.com>

> Pending signals can interrupt synchronous PCM state changes or the RX
> teardown wait after the device has accepted the command. Recovery can then
> issue a conflicting request before the previous transition has completed.
> Wait for SET_PARAMS, PREPARE and START within the existing timeout, as for
> STOP and RELEASE, and make the pending-RX drain wait non-interruptible.
> Device reset still cancels the wait and the timeout remains bounded.
> 
> Track whether a control request was submitted. Expose that information to
> the pause-restart state machine so it can distinguish a definitive failure
> from a timeout or reset after submission. The next patch uses this helper.
> 
> Keep INTEGER64 control values in the aligned response-data allocation
> instead of placing them immediately after the four-byte response header.
> 
> Capture DRAINING must allow consumption of the remaining tail without
> queueing fresh RX requests. Permit its indirect ACK while stopped and skip
> the refill in the transfer callback. A non-staged drain test returned
> -EPIPE with v5; the corrected kernel returned the final frame.
> 
> These changes address Sashiko findings in patches 1, 5 and 6 of this
> series. They apply after the included prerequisites.
> 
> Assisted-by: LLM
> Signed-off-by: Joonho Lee <mynameisjune111@gmail.com>

Sashiko has reviewed this patch and found no issues.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261028025317.92450-1-mynameisjune111@gmail.com?part=12


  reply	other threads:[~2026-10-28  3:06 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-28  2:53 [PATCH v6 00/14] ALSA: virtio: staged capture and dsnoop recovery Joonho Lee
2026-10-28  2:53 ` [PATCH v6 01/14] ALSA: virtio: Propagate PCM send failures through ACK Joonho Lee
2026-10-28  3:09   ` sashiko-bot
2026-10-28  2:53 ` [PATCH v6 02/14] ALSA: virtio: Recover PCM state after a failed start Joonho Lee
2026-10-28  3:21   ` sashiko-bot
2026-10-28  2:53 ` [PATCH v6 03/14] ALSA: virtio: Retain queued messages through device reset Joonho Lee
2026-10-28  3:19   ` sashiko-bot
2026-10-28  2:53 ` [PATCH v6 04/14] ALSA: virtio: Keep PCM DMA buffers alive through device ownership Joonho Lee
2026-10-28  3:15   ` sashiko-bot
2026-10-28  2:53 ` [PATCH v6 05/14] ALSA: virtio: Keep control payloads alive through DMA completion Joonho Lee
2026-10-28  3:07   ` sashiko-bot
2026-10-28  2:53 ` [PATCH v6 06/14] ALSA: virtio: wait through signals for PCM teardown Joonho Lee
2026-10-28  3:12   ` sashiko-bot
2026-10-28  2:53 ` [PATCH v6 07/14] ALSA: virtio: stage VZ capture and restart paused streams Joonho Lee
2026-10-28  3:27   ` sashiko-bot
2026-10-28  2:53 ` [PATCH v6 08/14] ALSA: virtio: account staged capture reads before RX refill Joonho Lee
2026-10-28  3:03   ` sashiko-bot
2026-10-28  2:53 ` [PATCH v6 09/14] ALSA: virtio: prioritize staged capture period work Joonho Lee
2026-10-28  3:00   ` sashiko-bot
2026-10-28  2:53 ` [PATCH v6 10/14] ALSA: pcm: mark stop-threshold accesses for capture policy sampling Joonho Lee
2026-10-28  2:58   ` sashiko-bot
2026-10-28  2:53 ` [PATCH v6 11/14] ALSA: virtio-snd: fix dsnoop capture with staged buffers Joonho Lee
2026-10-28  3:16   ` sashiko-bot
2026-10-28  2:53 ` [PATCH v6 12/14] ALSA: virtio: complete control transitions and preserve drain tail Joonho Lee
2026-10-28  3:06   ` sashiko-bot [this message]
2026-10-28  2:53 ` [PATCH v6 13/14] ALSA: virtio: fence staged capture state and recovery Joonho Lee
2026-10-28  3:27   ` sashiko-bot
2026-10-28  2:53 ` [PATCH v6 14/14] docs: describe virtio-sound capture options Joonho Lee
2026-10-28  2:58   ` sashiko-bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-187378@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=eperezma@redhat.com \
    --cc=mst@redhat.com \
    --cc=mynameisjune111@gmail.com \
    --cc=sashiko-reviews@lists.linux.dev \
    --cc=virtualization@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox