Linux virtualization list
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Joonho Lee" <mynameisjune111@gmail.com>
Cc: virtualization@lists.linux.dev,
	"Michael S. Tsirkin" <mst@redhat.com>,
	"Eugenio Perez" <eperezma@redhat.com>
Subject: Re: [PATCH v6 11/14] ALSA: virtio-snd: fix dsnoop capture with staged buffers
Date: Wed, 28 Oct 2026 03:16:25 +0000	[thread overview]
Message-ID: <sashiko-outbox-187407@kernel.org> (raw)
In-Reply-To: <20261028025317.92450-12-mynameisjune111@gmail.com>

> dsnoop runs its hardware slave with stop_threshold == boundary and can
> consume the mmap capture ring without advancing the hardware application
> pointer. Staged capture currently treats every stream as a bounded
> consumer: capture_ready grows until the completion capacity check fails.
> 
> With a 48 kHz mono slave, 960-frame periods and a 7680-frame buffer, the
> baseline dsnoop reproduction stops after 6720 frames with -EPIPE and a
> ring_capacity rejection. Direct capture continues to work.
> 
> Cache the prepared boundary and recognize the free-running policy under
> the substream lock. Keep RX requests supplied in that mode, while retaining
> payload, frame alignment, counter and pointer-window checks. Sample the
> policy once per completion so validation, copying and refill agree.
> Refresh it separately in the ACK accounting and refill critical sections.
> 
> [ ... ]
> regression also pass with KASAN and lockdep. No new physical-device or
> KCSAN results are claimed for this revision.
> 
> Assisted-by: LLM
> Signed-off-by: Joonho Lee <mynameisjune111@gmail.com>

Sashiko has reviewed this patch and found no issues.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261028025317.92450-1-mynameisjune111@gmail.com?part=11


  reply	other threads:[~2026-10-28  3:16 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-28  2:53 [PATCH v6 00/14] ALSA: virtio: staged capture and dsnoop recovery Joonho Lee
2026-10-28  2:53 ` [PATCH v6 01/14] ALSA: virtio: Propagate PCM send failures through ACK Joonho Lee
2026-10-28  3:09   ` sashiko-bot
2026-10-28  2:53 ` [PATCH v6 02/14] ALSA: virtio: Recover PCM state after a failed start Joonho Lee
2026-10-28  3:21   ` sashiko-bot
2026-10-28  2:53 ` [PATCH v6 03/14] ALSA: virtio: Retain queued messages through device reset Joonho Lee
2026-10-28  3:19   ` sashiko-bot
2026-10-28  2:53 ` [PATCH v6 04/14] ALSA: virtio: Keep PCM DMA buffers alive through device ownership Joonho Lee
2026-10-28  3:15   ` sashiko-bot
2026-10-28  2:53 ` [PATCH v6 05/14] ALSA: virtio: Keep control payloads alive through DMA completion Joonho Lee
2026-10-28  3:07   ` sashiko-bot
2026-10-28  2:53 ` [PATCH v6 06/14] ALSA: virtio: wait through signals for PCM teardown Joonho Lee
2026-10-28  3:12   ` sashiko-bot
2026-10-28  2:53 ` [PATCH v6 07/14] ALSA: virtio: stage VZ capture and restart paused streams Joonho Lee
2026-10-28  3:27   ` sashiko-bot
2026-10-28  2:53 ` [PATCH v6 08/14] ALSA: virtio: account staged capture reads before RX refill Joonho Lee
2026-10-28  3:03   ` sashiko-bot
2026-10-28  2:53 ` [PATCH v6 09/14] ALSA: virtio: prioritize staged capture period work Joonho Lee
2026-10-28  3:00   ` sashiko-bot
2026-10-28  2:53 ` [PATCH v6 10/14] ALSA: pcm: mark stop-threshold accesses for capture policy sampling Joonho Lee
2026-10-28  2:58   ` sashiko-bot
2026-10-28  2:53 ` [PATCH v6 11/14] ALSA: virtio-snd: fix dsnoop capture with staged buffers Joonho Lee
2026-10-28  3:16   ` sashiko-bot [this message]
2026-10-28  2:53 ` [PATCH v6 12/14] ALSA: virtio: complete control transitions and preserve drain tail Joonho Lee
2026-10-28  3:06   ` sashiko-bot
2026-10-28  2:53 ` [PATCH v6 13/14] ALSA: virtio: fence staged capture state and recovery Joonho Lee
2026-10-28  3:27   ` sashiko-bot
2026-10-28  2:53 ` [PATCH v6 14/14] docs: describe virtio-sound capture options Joonho Lee
2026-10-28  2:58   ` sashiko-bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-187407@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=eperezma@redhat.com \
    --cc=mst@redhat.com \
    --cc=mynameisjune111@gmail.com \
    --cc=sashiko-reviews@lists.linux.dev \
    --cc=virtualization@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox