Linux virtualization list
 help / color / mirror / Atom feed
* [PATCH v2 00/64] drm: Switch drivers to drm_mode_config_create_initial_state
@ 2026-11-16 10:30 Maxime Ripard
  2026-11-16 10:30 ` [PATCH v2 24/64] drm/qxl: Switch " Maxime Ripard
                   ` (4 more replies)
  0 siblings, 5 replies; 10+ messages in thread
From: Maxime Ripard @ 2026-11-16 10:30 UTC (permalink / raw)
  To: Maarten Lankhorst, Thomas Zimmermann, David Airlie, Simona Vetter
  Cc: dri-devel, Maxime Ripard, Janne Grunau, Sasha Finkelstein, asahi,
	Christian König, Alex Deucher, amd-gfx, sashiko-bot,
	Liviu Dudau, Russell King, Dave Airlie, Jocelyn Falempe,
	Alim Akhtar, Inki Dae, Krzysztof Kozlowski, Kyungmin Park,
	Peter Griffin, Seung-Woo Kim, linux-samsung-soc, Alison Wang,
	Stefan Agner, Tian Tao, Xinwei Kong, Yongbang Shi, Dexuan Cui,
	Long Li, Saurabh Sengar, linux-hyperv, Fabio Estevam, Frank Li,
	Pengutronix Kernel Team, Philipp Zabel, Sascha Hauer, imx,
	Paul Cercueil, linux-mips, Anitha Chrisanthus, Paul Kocialkowski,
	Huacai Chen, Icenowy Zheng, Jianmin Lv, Mingcong Bai, Qianhai Wu,
	Xi Ruoyao, AngeloGioacchino Del Regno, Chun-Kuang Hu,
	Matthias Brugger, Abhinav Kumar, Dmitry Baryshkov, Jessica Zhang,
	Marijn Suijten, Rob Clark, Sean Paul, freedreno, linux-arm-msm,
	Danilo Krummrich, Lyude Paul, nouveau, Tomi Valkeinen,
	Gerd Hoffmann, spice-devel, virtualization, Geert Uytterhoeven,
	Kieran Bingham, Laurent Pinchart, Magnus Damm, Tomi Valkeinen,
	linux-renesas-soc, Biju Das, Marcus Folkesson, David Lechner,
	Iker Pedrosa, Baolin Wang, Chunyan Zhang, Orson Zhai,
	Alexandre Torgue, Maxime Coquelin, Philippe Cornu,
	Raphael Gallais-Pou, Yannick Fertre, Chen-Yu Tsai, Samuel Holland,
	linux-sunxi, Jonathan Hunter, Mikko Perttunen, Thierry Reding,
	linux-tegra, Jyri Sarha, Alexey Brodkin, Hans de Goede,
	Kamlesh Gurudasani, Alex Lanzano, LiangCheng Wang, Chia-I Wu,
	Dmitry Osipenko, Gurchetan Singh,
	Broadcom internal kernel review list, Zack Rusin,
	Oleksandr Andrushchenko, Michal Simek

drm_mode_config_reset() has a dual role: it creates the initial KMS
state at probe time, and resets hardware and software state during
suspend/resume cycles. However, the two roles need different
behaviors, notably for objects like drm_private_obj that must persist
across suspend/resume and are excluded from drm_mode_config_reset()
by design.

Previous series introduced drm_mode_config_create_initial_state() to
handle only the initial state creation at probe time, including
drm_private_obj. Unlike drm_mode_config_reset(), it returns an error
code, allowing drivers to properly handle allocation failures.

This series switches all drivers calling drm_mode_config_reset() at
probe time to drm_mode_config_create_initial_state(). The conversion
was done using a Coccinelle semantic patch.

This is part, and the final piece, of a larger transition to remove the
overloaded reset semantics from the KMS subsystem, following similar
series for planes, CRTCs, connectors, and bridges.

Signed-off-by: Maxime Ripard <mripard@kernel.org>
---
Changes in v2:
- Fix some sashiko issues
- Link to v1: https://lore.kernel.org/r/20261105-drm-no-more-config-reset-v1-0-763560c2cc3f@kernel.org

---
Maxime Ripard (64):
      drm/adp: Switch to drm_mode_config_create_initial_state
      drm/amdgpu: Switch to drm_mode_config_create_initial_state
      drm/hdlcd: Fix drm_atomic_helper_shutdown() on the probe error path
      drm/hdlcd: Switch to drm_mode_config_create_initial_state
      drm/armada: Switch to drm_mode_config_create_initial_state
      drm/ast: Switch to drm_mode_config_create_initial_state
      drm/exynos: Switch to drm_mode_config_create_initial_state
      drm/fsl-dcu: Switch to drm_mode_config_create_initial_state
      drm/hisilicon/hibmc: Remove hibmc_unload() from the load error path
      drm/hisilicon/hibmc: Switch to drm_mode_config_create_initial_state
      drm/hyperv: Switch to drm_mode_config_create_initial_state
      drm/imx/ipuv3: Switch to drm_mode_config_create_initial_state
      drm/ingenic: Move the private object creation before the reset
      drm/ingenic: Switch to drm_mode_config_create_initial_state
      drm/kmb: Switch to drm_mode_config_create_initial_state
      drm/logicvc: Switch to drm_mode_config_create_initial_state
      drm/loongson: Switch to drm_mode_config_create_initial_state
      drm/mediatek: Switch to drm_mode_config_create_initial_state
      drm/mgag200: Switch to drm_mode_config_create_initial_state
      drm/msm: Switch to drm_mode_config_create_initial_state
      drm/nouveau: Switch to drm_mode_config_create_initial_state
      drm/omap: Switch to drm_mode_config_create_initial_state
      drm/qxl: Destroy the monitors object on the modeset init error path
      drm/qxl: Switch to drm_mode_config_create_initial_state
      drm/rcar-du: Switch to drm_mode_config_create_initial_state
      drm/rz-du: Switch to drm_mode_config_create_initial_state
      drm/shmobile: Switch to drm_mode_config_create_initial_state
      drm/st7571: Switch to drm_mode_config_create_initial_state
      drm/st7586: Switch to drm_mode_config_create_initial_state
      drm/st7735r: Switch to drm_mode_config_create_initial_state
      drm/st7920: Switch to drm_mode_config_create_initial_state
      drm/sprd: Switch to drm_mode_config_create_initial_state
      drm/sti: Fix drm_atomic_helper_shutdown() on the bind error paths
      drm/sti: Move drm_mode_config_create_initial_state() before drm_dev_register()
      drm/stm: Switch to drm_mode_config_create_initial_state
      drm/sun4i: Switch to drm_mode_config_create_initial_state
      drm/tegra: Switch to drm_mode_config_create_initial_state
      drm/tests: drm_atomic_state_test: Switch to drm_mode_config_create_initial_state
      drm/tests: drm_atomic_test: Switch to drm_mode_config_create_initial_state
      drm/tests: drm_bridge_test: Switch to drm_mode_config_create_initial_state
      drm/tests: drm_hdmi_state_helper_test: Switch to drm_mode_config_create_initial_state
      drm/tidss: Switch to drm_mode_config_create_initial_state
      drm/tilcdc: Switch to drm_mode_config_create_initial_state
      drm/arcpgu: Switch to drm_mode_config_create_initial_state
      drm/bochs: Switch to drm_mode_config_create_initial_state
      drm/cirrus-qemu: Switch to drm_mode_config_create_initial_state
      drm/gm12u320: Switch to drm_mode_config_create_initial_state
      drm/hx8357d: Switch to drm_mode_config_create_initial_state
      drm/ili9163: Switch to drm_mode_config_create_initial_state
      drm/ili9225: Switch to drm_mode_config_create_initial_state
      drm/ili9341: Switch to drm_mode_config_create_initial_state
      drm/ili9486: Switch to drm_mode_config_create_initial_state
      drm/mi0283qt: Switch to drm_mode_config_create_initial_state
      drm/panel-mipi-dbi: Switch to drm_mode_config_create_initial_state
      drm/pixpaper: Switch to drm_mode_config_create_initial_state
      drm/repaper: Switch to drm_mode_config_create_initial_state
      drm/sharp-memory: Switch to drm_mode_config_create_initial_state
      drm/udl: Switch to drm_mode_config_create_initial_state
      drm/vboxvideo: Switch to drm_mode_config_create_initial_state
      drm/verisilicon: Switch to drm_mode_config_create_initial_state
      drm/virtio: Switch to drm_mode_config_create_initial_state
      drm/vmwgfx: Switch to drm_mode_config_create_initial_state
      drm/xen: Switch to drm_mode_config_create_initial_state
      drm/xlnx: Switch to drm_mode_config_create_initial_state

 drivers/gpu/drm/adp/adp_drv.c                      |  4 +---
 drivers/gpu/drm/amd/amdgpu/amdgpu_vkms.c           |  4 +++-
 .../amdgpu_dm/tests/amdgpu_dm_connector_test.c     |  3 ++-
 .../amdgpu_dm/tests/amdgpu_dm_mst_types_test.c     |  4 +++-
 drivers/gpu/drm/arm/hdlcd_drv.c                    |  9 +++++----
 drivers/gpu/drm/armada/armada_drv.c                |  4 +++-
 drivers/gpu/drm/ast/ast_mode.c                     |  4 +++-
 drivers/gpu/drm/exynos/exynos_drm_drv.c            |  4 +++-
 drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_kms.c          |  4 +++-
 drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c    |  7 ++++---
 drivers/gpu/drm/hyperv/hyperv_drm_modeset.c        |  4 +---
 drivers/gpu/drm/imx/ipuv3/imx-drm-core.c           |  4 +++-
 drivers/gpu/drm/ingenic/ingenic-drm-drv.c          | 22 +++++++++++++---------
 drivers/gpu/drm/kmb/kmb_drv.c                      |  3 +--
 drivers/gpu/drm/logicvc/logicvc_mode.c             |  4 +++-
 drivers/gpu/drm/loongson/lsdc_drv.c                |  4 +++-
 drivers/gpu/drm/mediatek/mtk_drm_drv.c             |  8 +++++++-
 drivers/gpu/drm/mgag200/mgag200_g200.c             |  4 +++-
 drivers/gpu/drm/mgag200/mgag200_g200eh.c           |  4 +++-
 drivers/gpu/drm/mgag200/mgag200_g200eh3.c          |  4 +++-
 drivers/gpu/drm/mgag200/mgag200_g200eh5.c          |  4 +++-
 drivers/gpu/drm/mgag200/mgag200_g200er.c           |  4 +++-
 drivers/gpu/drm/mgag200/mgag200_g200ev.c           |  4 +++-
 drivers/gpu/drm/mgag200/mgag200_g200ew3.c          |  4 +++-
 drivers/gpu/drm/mgag200/mgag200_g200se.c           |  4 +++-
 drivers/gpu/drm/mgag200/mgag200_g200wb.c           |  4 +++-
 drivers/gpu/drm/msm/msm_kms.c                      |  4 +++-
 drivers/gpu/drm/nouveau/nouveau_display.c          |  4 +++-
 drivers/gpu/drm/omapdrm/omap_drv.c                 |  4 +++-
 drivers/gpu/drm/qxl/qxl_display.c                  | 11 +++++++++--
 drivers/gpu/drm/renesas/rcar-du/rcar_du_kms.c      |  4 +++-
 drivers/gpu/drm/renesas/rz-du/rzg2l_du_kms.c       |  4 +++-
 drivers/gpu/drm/renesas/shmobile/shmob_drm_kms.c   |  4 +++-
 drivers/gpu/drm/sitronix/st7571.c                  |  4 +++-
 drivers/gpu/drm/sitronix/st7586.c                  |  4 +++-
 drivers/gpu/drm/sitronix/st7735r.c                 |  4 +++-
 drivers/gpu/drm/sitronix/st7920.c                  |  4 +---
 drivers/gpu/drm/sprd/sprd_drm.c                    |  6 ++++--
 drivers/gpu/drm/sti/sti_drv.c                      | 10 ++++------
 drivers/gpu/drm/stm/drv.c                          |  6 +++++-
 drivers/gpu/drm/sun4i/sun4i_drv.c                  |  4 +++-
 drivers/gpu/drm/sun4i/sun4i_framebuffer.c          |  6 +++---
 drivers/gpu/drm/sun4i/sun4i_framebuffer.h          |  2 +-
 drivers/gpu/drm/tegra/drm.c                        |  4 +++-
 drivers/gpu/drm/tests/drm_atomic_commit_test.c     |  3 ++-
 drivers/gpu/drm/tests/drm_atomic_test.c            |  4 +++-
 drivers/gpu/drm/tests/drm_bridge_test.c            | 12 +++++++++---
 drivers/gpu/drm/tests/drm_hdmi_state_helper_test.c |  3 ++-
 drivers/gpu/drm/tidss/tidss_drv.c                  |  6 +++++-
 drivers/gpu/drm/tilcdc/tilcdc_drv.c                |  4 +++-
 drivers/gpu/drm/tiny/arcpgu.c                      |  4 +++-
 drivers/gpu/drm/tiny/bochs.c                       |  4 +---
 drivers/gpu/drm/tiny/cirrus-qemu.c                 |  4 +++-
 drivers/gpu/drm/tiny/gm12u320.c                    |  4 +++-
 drivers/gpu/drm/tiny/hx8357d.c                     |  4 +++-
 drivers/gpu/drm/tiny/ili9163.c                     |  4 +++-
 drivers/gpu/drm/tiny/ili9225.c                     |  4 +++-
 drivers/gpu/drm/tiny/ili9341.c                     |  4 +++-
 drivers/gpu/drm/tiny/ili9486.c                     |  4 +++-
 drivers/gpu/drm/tiny/mi0283qt.c                    |  4 +++-
 drivers/gpu/drm/tiny/panel-mipi-dbi.c              |  4 +++-
 drivers/gpu/drm/tiny/pixpaper.c                    |  4 +++-
 drivers/gpu/drm/tiny/repaper.c                     |  4 +++-
 drivers/gpu/drm/tiny/sharp-memory.c                |  4 +++-
 drivers/gpu/drm/udl/udl_modeset.c                  |  4 +++-
 drivers/gpu/drm/vboxvideo/vbox_mode.c              |  5 ++++-
 drivers/gpu/drm/verisilicon/vs_drm.c               |  4 +++-
 drivers/gpu/drm/virtio/virtgpu_display.c           |  3 +--
 drivers/gpu/drm/vmwgfx/vmwgfx_kms.c                | 14 +++++++++++++-
 drivers/gpu/drm/vmwgfx/vmwgfx_ldu.c                |  3 ---
 drivers/gpu/drm/vmwgfx/vmwgfx_scrn.c               |  3 ---
 drivers/gpu/drm/vmwgfx/vmwgfx_stdu.c               |  3 ---
 drivers/gpu/drm/xen/xen_drm_front_kms.c            |  4 +++-
 drivers/gpu/drm/xlnx/zynqmp_kms.c                  |  6 ++++--
 74 files changed, 243 insertions(+), 115 deletions(-)
---
base-commit: a8670a2ab1a81dc3fc30093e47c23b83244ca4d0
change-id: 20260712-drm-no-more-config-reset-1ea89f56693d

Best regards,
-- 
Maxime Ripard <mripard@kernel.org>


^ permalink raw reply	[flat|nested] 10+ messages in thread

* [PATCH v2 24/64] drm/qxl: Switch to drm_mode_config_create_initial_state
  2026-11-16 10:30 [PATCH v2 00/64] drm: Switch drivers to drm_mode_config_create_initial_state Maxime Ripard
@ 2026-11-16 10:30 ` Maxime Ripard
  2026-11-16 10:52   ` sashiko-bot
  2026-11-16 10:31 ` [PATCH v2 45/64] drm/bochs: " Maxime Ripard
                   ` (3 subsequent siblings)
  4 siblings, 1 reply; 10+ messages in thread
From: Maxime Ripard @ 2026-11-16 10:30 UTC (permalink / raw)
  To: Maarten Lankhorst, Thomas Zimmermann, David Airlie, Simona Vetter
  Cc: dri-devel, Maxime Ripard, Dave Airlie, Gerd Hoffmann, spice-devel,
	virtualization

drm_mode_config_reset() has a dual role: it creates the initial KMS
state at probe time, and resets hardware and software state during
suspend/resume cycles.

Since the two roles need different behaviors (notably for objects like
drm_private_obj that must persist across suspend/resume),
drm_mode_config_create_initial_state() was introduced to handle only
the initial state creation at probe time.

Switch to drm_mode_config_create_initial_state().

Signed-off-by: Maxime Ripard <mripard@kernel.org>
---
Cc: Dave Airlie <airlied@redhat.com>
Cc: Gerd Hoffmann <kraxel@redhat.com>
Cc: spice-devel@lists.freedesktop.org
Cc: virtualization@lists.linux.dev
---
 drivers/gpu/drm/qxl/qxl_display.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/qxl/qxl_display.c b/drivers/gpu/drm/qxl/qxl_display.c
index 77fbf3c864cc..361265a0d620 100644
--- a/drivers/gpu/drm/qxl/qxl_display.c
+++ b/drivers/gpu/drm/qxl/qxl_display.c
@@ -1310,11 +1310,14 @@ int qxl_modeset_init(struct qxl_device *qdev)
 
 	ret = drm_vblank_init(&qdev->ddev, qxl_num_crtc);
 	if (ret)
 		goto destroy_monitors_object;
 
-	drm_mode_config_reset(&qdev->ddev);
+	ret = drm_mode_config_create_initial_state(&qdev->ddev);
+	if (ret)
+		goto destroy_monitors_object;
+
 	return 0;
 
 destroy_monitors_object:
 	qxl_destroy_monitors_object(qdev);
 	return ret;

-- 
2.56.1


^ permalink raw reply related	[flat|nested] 10+ messages in thread

* [PATCH v2 45/64] drm/bochs: Switch to drm_mode_config_create_initial_state
  2026-11-16 10:30 [PATCH v2 00/64] drm: Switch drivers to drm_mode_config_create_initial_state Maxime Ripard
  2026-11-16 10:30 ` [PATCH v2 24/64] drm/qxl: Switch " Maxime Ripard
@ 2026-11-16 10:31 ` Maxime Ripard
  2026-11-16 10:55   ` sashiko-bot
  2026-11-16 10:31 ` [PATCH v2 46/64] drm/cirrus-qemu: " Maxime Ripard
                   ` (2 subsequent siblings)
  4 siblings, 1 reply; 10+ messages in thread
From: Maxime Ripard @ 2026-11-16 10:31 UTC (permalink / raw)
  To: Maarten Lankhorst, Thomas Zimmermann, David Airlie, Simona Vetter
  Cc: dri-devel, Maxime Ripard, Gerd Hoffmann, virtualization

drm_mode_config_reset() has a dual role: it creates the initial KMS
state at probe time, and resets hardware and software state during
suspend/resume cycles.

Since the two roles need different behaviors (notably for objects like
drm_private_obj that must persist across suspend/resume),
drm_mode_config_create_initial_state() was introduced to handle only
the initial state creation at probe time.

Switch to drm_mode_config_create_initial_state().

Signed-off-by: Maxime Ripard <mripard@kernel.org>
---
Cc: Gerd Hoffmann <kraxel@redhat.com>
Cc: virtualization@lists.linux.dev
---
 drivers/gpu/drm/tiny/bochs.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/gpu/drm/tiny/bochs.c b/drivers/gpu/drm/tiny/bochs.c
index 771d59b92f67..c24adbcb77a3 100644
--- a/drivers/gpu/drm/tiny/bochs.c
+++ b/drivers/gpu/drm/tiny/bochs.c
@@ -681,13 +681,11 @@ static int bochs_kms_init(struct bochs_device *bochs)
 
 	ret = drm_vblank_init(dev, 1);
 	if (ret)
 		return ret;
 
-	drm_mode_config_reset(dev);
-
-	return 0;
+	return drm_mode_config_create_initial_state(dev);
 }
 
 /* ---------------------------------------------------------------------- */
 /* drm interface                                                          */
 

-- 
2.56.1


^ permalink raw reply related	[flat|nested] 10+ messages in thread

* [PATCH v2 46/64] drm/cirrus-qemu: Switch to drm_mode_config_create_initial_state
  2026-11-16 10:30 [PATCH v2 00/64] drm: Switch drivers to drm_mode_config_create_initial_state Maxime Ripard
  2026-11-16 10:30 ` [PATCH v2 24/64] drm/qxl: Switch " Maxime Ripard
  2026-11-16 10:31 ` [PATCH v2 45/64] drm/bochs: " Maxime Ripard
@ 2026-11-16 10:31 ` Maxime Ripard
  2026-11-16 10:54   ` sashiko-bot
  2026-11-16 10:31 ` [PATCH v2 61/64] drm/virtio: " Maxime Ripard
  2026-11-17 13:22 ` [PATCH v2 00/64] drm: Switch drivers " Thomas Zimmermann
  4 siblings, 1 reply; 10+ messages in thread
From: Maxime Ripard @ 2026-11-16 10:31 UTC (permalink / raw)
  To: Maarten Lankhorst, Thomas Zimmermann, David Airlie, Simona Vetter
  Cc: dri-devel, Maxime Ripard, Dave Airlie, Gerd Hoffmann,
	virtualization

drm_mode_config_reset() has a dual role: it creates the initial KMS
state at probe time, and resets hardware and software state during
suspend/resume cycles.

Since the two roles need different behaviors (notably for objects like
drm_private_obj that must persist across suspend/resume),
drm_mode_config_create_initial_state() was introduced to handle only
the initial state creation at probe time.

Switch to drm_mode_config_create_initial_state().

Signed-off-by: Maxime Ripard <mripard@kernel.org>
---
Cc: Dave Airlie <airlied@redhat.com>
Cc: Gerd Hoffmann <kraxel@redhat.com>
Cc: virtualization@lists.linux.dev
---
 drivers/gpu/drm/tiny/cirrus-qemu.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/tiny/cirrus-qemu.c b/drivers/gpu/drm/tiny/cirrus-qemu.c
index 9e3051b9c3f7..98664f573ff8 100644
--- a/drivers/gpu/drm/tiny/cirrus-qemu.c
+++ b/drivers/gpu/drm/tiny/cirrus-qemu.c
@@ -621,11 +621,13 @@ static int cirrus_pci_probe(struct pci_dev *pdev,
 
 	ret = cirrus_pipe_init(cirrus);
 	if (ret < 0)
 		return ret;
 
-	drm_mode_config_reset(dev);
+	ret = drm_mode_config_create_initial_state(dev);
+	if (ret)
+		return ret;
 
 	pci_set_drvdata(pdev, dev);
 	ret = drm_dev_register(dev, 0);
 	if (ret)
 		return ret;

-- 
2.56.1


^ permalink raw reply related	[flat|nested] 10+ messages in thread

* [PATCH v2 61/64] drm/virtio: Switch to drm_mode_config_create_initial_state
  2026-11-16 10:30 [PATCH v2 00/64] drm: Switch drivers to drm_mode_config_create_initial_state Maxime Ripard
                   ` (2 preceding siblings ...)
  2026-11-16 10:31 ` [PATCH v2 46/64] drm/cirrus-qemu: " Maxime Ripard
@ 2026-11-16 10:31 ` Maxime Ripard
  2026-11-16 11:01   ` sashiko-bot
  2026-11-17 13:22 ` [PATCH v2 00/64] drm: Switch drivers " Thomas Zimmermann
  4 siblings, 1 reply; 10+ messages in thread
From: Maxime Ripard @ 2026-11-16 10:31 UTC (permalink / raw)
  To: Maarten Lankhorst, Thomas Zimmermann, David Airlie, Simona Vetter
  Cc: dri-devel, Maxime Ripard, Chia-I Wu, David Airlie,
	Dmitry Osipenko, Gerd Hoffmann, Gurchetan Singh, virtualization

drm_mode_config_reset() has a dual role: it creates the initial KMS
state at probe time, and resets hardware and software state during
suspend/resume cycles.

Since the two roles need different behaviors (notably for objects like
drm_private_obj that must persist across suspend/resume),
drm_mode_config_create_initial_state() was introduced to handle only
the initial state creation at probe time.

Switch to drm_mode_config_create_initial_state().

Signed-off-by: Maxime Ripard <mripard@kernel.org>
---
Cc: Chia-I Wu <olvaffe@gmail.com>
Cc: David Airlie <airlied@redhat.com>
Cc: Dmitry Osipenko <dmitry.osipenko@collabora.com>
Cc: Gerd Hoffmann <kraxel@redhat.com>
Cc: Gurchetan Singh <gurchetansingh@chromium.org>
Cc: virtualization@lists.linux.dev
---
 drivers/gpu/drm/virtio/virtgpu_display.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/virtio/virtgpu_display.c b/drivers/gpu/drm/virtio/virtgpu_display.c
index f0ed9bd27a91..dfc3aed03b8e 100644
--- a/drivers/gpu/drm/virtio/virtgpu_display.c
+++ b/drivers/gpu/drm/virtio/virtgpu_display.c
@@ -394,12 +394,11 @@ int virtio_gpu_modeset_init(struct virtio_gpu_device *vgdev)
 
 	ret = drm_vblank_init(vgdev->ddev, vgdev->num_scanouts);
 	if (ret)
 		return ret;
 
-	drm_mode_config_reset(vgdev->ddev);
-	return 0;
+	return drm_mode_config_create_initial_state(vgdev->ddev);
 }
 
 void virtio_gpu_modeset_fini(struct virtio_gpu_device *vgdev)
 {
 	int i;

-- 
2.56.1


^ permalink raw reply related	[flat|nested] 10+ messages in thread

* Re: [PATCH v2 24/64] drm/qxl: Switch to drm_mode_config_create_initial_state
  2026-11-16 10:30 ` [PATCH v2 24/64] drm/qxl: Switch " Maxime Ripard
@ 2026-11-16 10:52   ` sashiko-bot
  0 siblings, 0 replies; 10+ messages in thread
From: sashiko-bot @ 2026-11-16 10:52 UTC (permalink / raw)
  To: Maxime Ripard; +Cc: virtualization, Michael S. Tsirkin, Eugenio Perez

> drm_mode_config_reset() has a dual role: it creates the initial KMS
> state at probe time, and resets hardware and software state during
> suspend/resume cycles.
> 
> Since the two roles need different behaviors (notably for objects like
> drm_private_obj that must persist across suspend/resume),
> drm_mode_config_create_initial_state() was introduced to handle only
> the initial state creation at probe time.
> 
> Switch to drm_mode_config_create_initial_state().
> 
> Signed-off-by: Maxime Ripard <mripard@kernel.org>

Sashiko has reviewed this patch and found no issues.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261116-drm-no-more-config-reset-v2-0-0bb471f4d1e0@kernel.org?part=24


^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH v2 46/64] drm/cirrus-qemu: Switch to drm_mode_config_create_initial_state
  2026-11-16 10:31 ` [PATCH v2 46/64] drm/cirrus-qemu: " Maxime Ripard
@ 2026-11-16 10:54   ` sashiko-bot
  0 siblings, 0 replies; 10+ messages in thread
From: sashiko-bot @ 2026-11-16 10:54 UTC (permalink / raw)
  To: Maxime Ripard; +Cc: virtualization, Michael S. Tsirkin, Eugenio Perez

> drm_mode_config_reset() has a dual role: it creates the initial KMS
> state at probe time, and resets hardware and software state during
> suspend/resume cycles.
> 
> Since the two roles need different behaviors (notably for objects like
> drm_private_obj that must persist across suspend/resume),
> drm_mode_config_create_initial_state() was introduced to handle only
> the initial state creation at probe time.
> 
> Switch to drm_mode_config_create_initial_state().
> 
> Signed-off-by: Maxime Ripard <mripard@kernel.org>

Sashiko has reviewed this patch and found no issues.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261116-drm-no-more-config-reset-v2-0-0bb471f4d1e0@kernel.org?part=46


^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH v2 45/64] drm/bochs: Switch to drm_mode_config_create_initial_state
  2026-11-16 10:31 ` [PATCH v2 45/64] drm/bochs: " Maxime Ripard
@ 2026-11-16 10:55   ` sashiko-bot
  0 siblings, 0 replies; 10+ messages in thread
From: sashiko-bot @ 2026-11-16 10:55 UTC (permalink / raw)
  To: Maxime Ripard; +Cc: virtualization, Michael S. Tsirkin, Eugenio Perez

> drm_mode_config_reset() has a dual role: it creates the initial KMS
> state at probe time, and resets hardware and software state during
> suspend/resume cycles.
> 
> Since the two roles need different behaviors (notably for objects like
> drm_private_obj that must persist across suspend/resume),
> drm_mode_config_create_initial_state() was introduced to handle only
> the initial state creation at probe time.
> 
> Switch to drm_mode_config_create_initial_state().
> 
> Signed-off-by: Maxime Ripard <mripard@kernel.org>

Sashiko has reviewed this patch and found no issues.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261116-drm-no-more-config-reset-v2-0-0bb471f4d1e0@kernel.org?part=45


^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH v2 61/64] drm/virtio: Switch to drm_mode_config_create_initial_state
  2026-11-16 10:31 ` [PATCH v2 61/64] drm/virtio: " Maxime Ripard
@ 2026-11-16 11:01   ` sashiko-bot
  0 siblings, 0 replies; 10+ messages in thread
From: sashiko-bot @ 2026-11-16 11:01 UTC (permalink / raw)
  To: Maxime Ripard; +Cc: virtualization, Michael S. Tsirkin, Eugenio Perez

> drm_mode_config_reset() has a dual role: it creates the initial KMS
> state at probe time, and resets hardware and software state during
> suspend/resume cycles.
> 
> Since the two roles need different behaviors (notably for objects like
> drm_private_obj that must persist across suspend/resume),
> drm_mode_config_create_initial_state() was introduced to handle only
> the initial state creation at probe time.
> 
> Switch to drm_mode_config_create_initial_state().
> 
> Signed-off-by: Maxime Ripard <mripard@kernel.org>

Sashiko has reviewed this patch and found no issues.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261116-drm-no-more-config-reset-v2-0-0bb471f4d1e0@kernel.org?part=61


^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH v2 00/64] drm: Switch drivers to drm_mode_config_create_initial_state
  2026-11-16 10:30 [PATCH v2 00/64] drm: Switch drivers to drm_mode_config_create_initial_state Maxime Ripard
                   ` (3 preceding siblings ...)
  2026-11-16 10:31 ` [PATCH v2 61/64] drm/virtio: " Maxime Ripard
@ 2026-11-17 13:22 ` Thomas Zimmermann
  4 siblings, 0 replies; 10+ messages in thread
From: Thomas Zimmermann @ 2026-11-17 13:22 UTC (permalink / raw)
  To: Maxime Ripard, Maarten Lankhorst, David Airlie, Simona Vetter
  Cc: dri-devel, Janne Grunau, Sasha Finkelstein, asahi,
	Christian König, Alex Deucher, amd-gfx, sashiko-bot,
	Liviu Dudau, Russell King, Dave Airlie, Jocelyn Falempe,
	Alim Akhtar, Inki Dae, Krzysztof Kozlowski, Kyungmin Park,
	Peter Griffin, Seung-Woo Kim, linux-samsung-soc, Alison Wang,
	Stefan Agner, Tian Tao, Xinwei Kong, Yongbang Shi, Dexuan Cui,
	Long Li, Saurabh Sengar, linux-hyperv, Fabio Estevam, Frank Li,
	Pengutronix Kernel Team, Philipp Zabel, Sascha Hauer, imx,
	Paul Cercueil, linux-mips, Anitha Chrisanthus, Paul Kocialkowski,
	Huacai Chen, Icenowy Zheng, Jianmin Lv, Mingcong Bai, Qianhai Wu,
	Xi Ruoyao, AngeloGioacchino Del Regno, Chun-Kuang Hu,
	Matthias Brugger, Abhinav Kumar, Dmitry Baryshkov, Jessica Zhang,
	Marijn Suijten, Rob Clark, Sean Paul, freedreno, linux-arm-msm,
	Danilo Krummrich, Lyude Paul, nouveau, Tomi Valkeinen,
	Gerd Hoffmann, spice-devel, virtualization, Geert Uytterhoeven,
	Kieran Bingham, Laurent Pinchart, Magnus Damm, Tomi Valkeinen,
	linux-renesas-soc, Biju Das, Marcus Folkesson, David Lechner,
	Iker Pedrosa, Baolin Wang, Chunyan Zhang, Orson Zhai,
	Alexandre Torgue, Maxime Coquelin, Philippe Cornu,
	Raphael Gallais-Pou, Yannick Fertre, Chen-Yu Tsai, Samuel Holland,
	linux-sunxi, Jonathan Hunter, Mikko Perttunen, Thierry Reding,
	linux-tegra, Jyri Sarha, Alexey Brodkin, Hans de Goede,
	Kamlesh Gurudasani, Alex Lanzano, LiangCheng Wang, Chia-I Wu,
	Dmitry Osipenko, Gurchetan Singh,
	Broadcom internal kernel review list, Zack Rusin,
	Oleksandr Andrushchenko, Michal Simek

Hi Maxime

Am 16.11.26 um 11:30 schrieb Maxime Ripard:
> drm_mode_config_reset() has a dual role: it creates the initial KMS
> state at probe time, and resets hardware and software state during
> suspend/resume cycles. However, the two roles need different
> behaviors, notably for objects like drm_private_obj that must persist
> across suspend/resume and are excluded from drm_mode_config_reset()
> by design.
>
> Previous series introduced drm_mode_config_create_initial_state() to
> handle only the initial state creation at probe time, including
> drm_private_obj. Unlike drm_mode_config_reset(), it returns an error
> code, allowing drivers to properly handle allocation failures.
>
> This series switches all drivers calling drm_mode_config_reset() at
> probe time to drm_mode_config_create_initial_state(). The conversion
> was done using a Coccinelle semantic patch.
>
> This is part, and the final piece, of a larger transition to remove the
> overloaded reset semantics from the KMS subsystem, following similar
> series for planes, CRTCs, connectors, and bridges.
>
> Signed-off-by: Maxime Ripard <mripard@kernel.org>

For the entire series:

Reviewed-by: Thomas Zimmermann <tzimmermann@suse.de>


> ---
> Changes in v2:
> - Fix some sashiko issues
> - Link to v1: https://lore.kernel.org/r/20261105-drm-no-more-config-reset-v1-0-763560c2cc3f@kernel.org
>
> ---
> Maxime Ripard (64):
>        drm/adp: Switch to drm_mode_config_create_initial_state
>        drm/amdgpu: Switch to drm_mode_config_create_initial_state
>        drm/hdlcd: Fix drm_atomic_helper_shutdown() on the probe error path
>        drm/hdlcd: Switch to drm_mode_config_create_initial_state
>        drm/armada: Switch to drm_mode_config_create_initial_state
>        drm/ast: Switch to drm_mode_config_create_initial_state
>        drm/exynos: Switch to drm_mode_config_create_initial_state
>        drm/fsl-dcu: Switch to drm_mode_config_create_initial_state
>        drm/hisilicon/hibmc: Remove hibmc_unload() from the load error path
>        drm/hisilicon/hibmc: Switch to drm_mode_config_create_initial_state
>        drm/hyperv: Switch to drm_mode_config_create_initial_state
>        drm/imx/ipuv3: Switch to drm_mode_config_create_initial_state
>        drm/ingenic: Move the private object creation before the reset
>        drm/ingenic: Switch to drm_mode_config_create_initial_state
>        drm/kmb: Switch to drm_mode_config_create_initial_state
>        drm/logicvc: Switch to drm_mode_config_create_initial_state
>        drm/loongson: Switch to drm_mode_config_create_initial_state
>        drm/mediatek: Switch to drm_mode_config_create_initial_state
>        drm/mgag200: Switch to drm_mode_config_create_initial_state
>        drm/msm: Switch to drm_mode_config_create_initial_state
>        drm/nouveau: Switch to drm_mode_config_create_initial_state
>        drm/omap: Switch to drm_mode_config_create_initial_state
>        drm/qxl: Destroy the monitors object on the modeset init error path
>        drm/qxl: Switch to drm_mode_config_create_initial_state
>        drm/rcar-du: Switch to drm_mode_config_create_initial_state
>        drm/rz-du: Switch to drm_mode_config_create_initial_state
>        drm/shmobile: Switch to drm_mode_config_create_initial_state
>        drm/st7571: Switch to drm_mode_config_create_initial_state
>        drm/st7586: Switch to drm_mode_config_create_initial_state
>        drm/st7735r: Switch to drm_mode_config_create_initial_state
>        drm/st7920: Switch to drm_mode_config_create_initial_state
>        drm/sprd: Switch to drm_mode_config_create_initial_state
>        drm/sti: Fix drm_atomic_helper_shutdown() on the bind error paths
>        drm/sti: Move drm_mode_config_create_initial_state() before drm_dev_register()
>        drm/stm: Switch to drm_mode_config_create_initial_state
>        drm/sun4i: Switch to drm_mode_config_create_initial_state
>        drm/tegra: Switch to drm_mode_config_create_initial_state
>        drm/tests: drm_atomic_state_test: Switch to drm_mode_config_create_initial_state
>        drm/tests: drm_atomic_test: Switch to drm_mode_config_create_initial_state
>        drm/tests: drm_bridge_test: Switch to drm_mode_config_create_initial_state
>        drm/tests: drm_hdmi_state_helper_test: Switch to drm_mode_config_create_initial_state
>        drm/tidss: Switch to drm_mode_config_create_initial_state
>        drm/tilcdc: Switch to drm_mode_config_create_initial_state
>        drm/arcpgu: Switch to drm_mode_config_create_initial_state
>        drm/bochs: Switch to drm_mode_config_create_initial_state
>        drm/cirrus-qemu: Switch to drm_mode_config_create_initial_state
>        drm/gm12u320: Switch to drm_mode_config_create_initial_state
>        drm/hx8357d: Switch to drm_mode_config_create_initial_state
>        drm/ili9163: Switch to drm_mode_config_create_initial_state
>        drm/ili9225: Switch to drm_mode_config_create_initial_state
>        drm/ili9341: Switch to drm_mode_config_create_initial_state
>        drm/ili9486: Switch to drm_mode_config_create_initial_state
>        drm/mi0283qt: Switch to drm_mode_config_create_initial_state
>        drm/panel-mipi-dbi: Switch to drm_mode_config_create_initial_state
>        drm/pixpaper: Switch to drm_mode_config_create_initial_state
>        drm/repaper: Switch to drm_mode_config_create_initial_state
>        drm/sharp-memory: Switch to drm_mode_config_create_initial_state
>        drm/udl: Switch to drm_mode_config_create_initial_state
>        drm/vboxvideo: Switch to drm_mode_config_create_initial_state
>        drm/verisilicon: Switch to drm_mode_config_create_initial_state
>        drm/virtio: Switch to drm_mode_config_create_initial_state
>        drm/vmwgfx: Switch to drm_mode_config_create_initial_state
>        drm/xen: Switch to drm_mode_config_create_initial_state
>        drm/xlnx: Switch to drm_mode_config_create_initial_state
>
>   drivers/gpu/drm/adp/adp_drv.c                      |  4 +---
>   drivers/gpu/drm/amd/amdgpu/amdgpu_vkms.c           |  4 +++-
>   .../amdgpu_dm/tests/amdgpu_dm_connector_test.c     |  3 ++-
>   .../amdgpu_dm/tests/amdgpu_dm_mst_types_test.c     |  4 +++-
>   drivers/gpu/drm/arm/hdlcd_drv.c                    |  9 +++++----
>   drivers/gpu/drm/armada/armada_drv.c                |  4 +++-
>   drivers/gpu/drm/ast/ast_mode.c                     |  4 +++-
>   drivers/gpu/drm/exynos/exynos_drm_drv.c            |  4 +++-
>   drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_kms.c          |  4 +++-
>   drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c    |  7 ++++---
>   drivers/gpu/drm/hyperv/hyperv_drm_modeset.c        |  4 +---
>   drivers/gpu/drm/imx/ipuv3/imx-drm-core.c           |  4 +++-
>   drivers/gpu/drm/ingenic/ingenic-drm-drv.c          | 22 +++++++++++++---------
>   drivers/gpu/drm/kmb/kmb_drv.c                      |  3 +--
>   drivers/gpu/drm/logicvc/logicvc_mode.c             |  4 +++-
>   drivers/gpu/drm/loongson/lsdc_drv.c                |  4 +++-
>   drivers/gpu/drm/mediatek/mtk_drm_drv.c             |  8 +++++++-
>   drivers/gpu/drm/mgag200/mgag200_g200.c             |  4 +++-
>   drivers/gpu/drm/mgag200/mgag200_g200eh.c           |  4 +++-
>   drivers/gpu/drm/mgag200/mgag200_g200eh3.c          |  4 +++-
>   drivers/gpu/drm/mgag200/mgag200_g200eh5.c          |  4 +++-
>   drivers/gpu/drm/mgag200/mgag200_g200er.c           |  4 +++-
>   drivers/gpu/drm/mgag200/mgag200_g200ev.c           |  4 +++-
>   drivers/gpu/drm/mgag200/mgag200_g200ew3.c          |  4 +++-
>   drivers/gpu/drm/mgag200/mgag200_g200se.c           |  4 +++-
>   drivers/gpu/drm/mgag200/mgag200_g200wb.c           |  4 +++-
>   drivers/gpu/drm/msm/msm_kms.c                      |  4 +++-
>   drivers/gpu/drm/nouveau/nouveau_display.c          |  4 +++-
>   drivers/gpu/drm/omapdrm/omap_drv.c                 |  4 +++-
>   drivers/gpu/drm/qxl/qxl_display.c                  | 11 +++++++++--
>   drivers/gpu/drm/renesas/rcar-du/rcar_du_kms.c      |  4 +++-
>   drivers/gpu/drm/renesas/rz-du/rzg2l_du_kms.c       |  4 +++-
>   drivers/gpu/drm/renesas/shmobile/shmob_drm_kms.c   |  4 +++-
>   drivers/gpu/drm/sitronix/st7571.c                  |  4 +++-
>   drivers/gpu/drm/sitronix/st7586.c                  |  4 +++-
>   drivers/gpu/drm/sitronix/st7735r.c                 |  4 +++-
>   drivers/gpu/drm/sitronix/st7920.c                  |  4 +---
>   drivers/gpu/drm/sprd/sprd_drm.c                    |  6 ++++--
>   drivers/gpu/drm/sti/sti_drv.c                      | 10 ++++------
>   drivers/gpu/drm/stm/drv.c                          |  6 +++++-
>   drivers/gpu/drm/sun4i/sun4i_drv.c                  |  4 +++-
>   drivers/gpu/drm/sun4i/sun4i_framebuffer.c          |  6 +++---
>   drivers/gpu/drm/sun4i/sun4i_framebuffer.h          |  2 +-
>   drivers/gpu/drm/tegra/drm.c                        |  4 +++-
>   drivers/gpu/drm/tests/drm_atomic_commit_test.c     |  3 ++-
>   drivers/gpu/drm/tests/drm_atomic_test.c            |  4 +++-
>   drivers/gpu/drm/tests/drm_bridge_test.c            | 12 +++++++++---
>   drivers/gpu/drm/tests/drm_hdmi_state_helper_test.c |  3 ++-
>   drivers/gpu/drm/tidss/tidss_drv.c                  |  6 +++++-
>   drivers/gpu/drm/tilcdc/tilcdc_drv.c                |  4 +++-
>   drivers/gpu/drm/tiny/arcpgu.c                      |  4 +++-
>   drivers/gpu/drm/tiny/bochs.c                       |  4 +---
>   drivers/gpu/drm/tiny/cirrus-qemu.c                 |  4 +++-
>   drivers/gpu/drm/tiny/gm12u320.c                    |  4 +++-
>   drivers/gpu/drm/tiny/hx8357d.c                     |  4 +++-
>   drivers/gpu/drm/tiny/ili9163.c                     |  4 +++-
>   drivers/gpu/drm/tiny/ili9225.c                     |  4 +++-
>   drivers/gpu/drm/tiny/ili9341.c                     |  4 +++-
>   drivers/gpu/drm/tiny/ili9486.c                     |  4 +++-
>   drivers/gpu/drm/tiny/mi0283qt.c                    |  4 +++-
>   drivers/gpu/drm/tiny/panel-mipi-dbi.c              |  4 +++-
>   drivers/gpu/drm/tiny/pixpaper.c                    |  4 +++-
>   drivers/gpu/drm/tiny/repaper.c                     |  4 +++-
>   drivers/gpu/drm/tiny/sharp-memory.c                |  4 +++-
>   drivers/gpu/drm/udl/udl_modeset.c                  |  4 +++-
>   drivers/gpu/drm/vboxvideo/vbox_mode.c              |  5 ++++-
>   drivers/gpu/drm/verisilicon/vs_drm.c               |  4 +++-
>   drivers/gpu/drm/virtio/virtgpu_display.c           |  3 +--
>   drivers/gpu/drm/vmwgfx/vmwgfx_kms.c                | 14 +++++++++++++-
>   drivers/gpu/drm/vmwgfx/vmwgfx_ldu.c                |  3 ---
>   drivers/gpu/drm/vmwgfx/vmwgfx_scrn.c               |  3 ---
>   drivers/gpu/drm/vmwgfx/vmwgfx_stdu.c               |  3 ---
>   drivers/gpu/drm/xen/xen_drm_front_kms.c            |  4 +++-
>   drivers/gpu/drm/xlnx/zynqmp_kms.c                  |  6 ++++--
>   74 files changed, 243 insertions(+), 115 deletions(-)
> ---
> base-commit: a8670a2ab1a81dc3fc30093e47c23b83244ca4d0
> change-id: 20260712-drm-no-more-config-reset-1ea89f56693d
>
> Best regards,

-- 
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Frankenstr. 146, 90461 Nürnberg, Germany, www.suse.com
GF: Stefan Gaiser, Jochen Jaser, Abhinav Puri, (HRB 36809, AG Nürnberg)



^ permalink raw reply	[flat|nested] 10+ messages in thread

end of thread, other threads:[~2026-11-17 13:23 UTC | newest]

Thread overview: 10+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-11-16 10:30 [PATCH v2 00/64] drm: Switch drivers to drm_mode_config_create_initial_state Maxime Ripard
2026-11-16 10:30 ` [PATCH v2 24/64] drm/qxl: Switch " Maxime Ripard
2026-11-16 10:52   ` sashiko-bot
2026-11-16 10:31 ` [PATCH v2 45/64] drm/bochs: " Maxime Ripard
2026-11-16 10:55   ` sashiko-bot
2026-11-16 10:31 ` [PATCH v2 46/64] drm/cirrus-qemu: " Maxime Ripard
2026-11-16 10:54   ` sashiko-bot
2026-11-16 10:31 ` [PATCH v2 61/64] drm/virtio: " Maxime Ripard
2026-11-16 11:01   ` sashiko-bot
2026-11-17 13:22 ` [PATCH v2 00/64] drm: Switch drivers " Thomas Zimmermann

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox