From: Ian Campbell <ian.campbell@citrix.com>
To: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Cc: Wei Liu <wei.liu2@citrix.com>, xen-devel@lists.xen.org
Subject: Re: [PATCH] libxlu: avoid having two definitions of XLU_ConfigList
Date: Thu, 19 Mar 2015 11:03:58 +0000 [thread overview]
Message-ID: <1426763038.610.32.camel@citrix.com> (raw)
In-Reply-To: <20150319002815.GA25672@l.oracle.com>
On Wed, 2015-03-18 at 20:28 -0400, Konrad Rzeszutek Wilk wrote:
> On Wed, Mar 18, 2015 at 09:33:58PM +0000, Wei Liu wrote:
> > There is already a typedef in libxlutil.h. Remove the one in
> > libxlu_internal.h.
> >
> > Signed-off-by: Wei Liu <wei.liu2@citrix.com>
>
> Missing the 'Reported-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>'
I added this and acked + applied the patch.
Ian, who is surprised newer gcc is more lenient on this matter...
prev parent reply other threads:[~2015-03-19 11:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-18 21:33 [PATCH] libxlu: avoid having two definitions of XLU_ConfigList Wei Liu
2015-03-19 0:28 ` Konrad Rzeszutek Wilk
2015-03-19 11:03 ` Ian Campbell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1426763038.610.32.camel@citrix.com \
--to=ian.campbell@citrix.com \
--cc=konrad.wilk@oracle.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox