Xen-Devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To: Wei Liu <wei.liu2@citrix.com>
Cc: ian.campbell@citrix.com, xen-devel@lists.xen.org
Subject: Re: [PATCH] libxlu: avoid having two definitions of XLU_ConfigList
Date: Wed, 18 Mar 2015 20:28:15 -0400	[thread overview]
Message-ID: <20150319002815.GA25672@l.oracle.com> (raw)
In-Reply-To: <1426714438-1347-1-git-send-email-wei.liu2@citrix.com>

On Wed, Mar 18, 2015 at 09:33:58PM +0000, Wei Liu wrote:
> There is already a typedef in libxlutil.h. Remove the one in
> libxlu_internal.h.
> 
> Signed-off-by: Wei Liu <wei.liu2@citrix.com>

Missing the 'Reported-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>'
> ---
>  tools/libxl/libxlu_internal.h | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/tools/libxl/libxlu_internal.h b/tools/libxl/libxlu_internal.h
> index 3451cfe..0acdde3 100644
> --- a/tools/libxl/libxlu_internal.h
> +++ b/tools/libxl/libxlu_internal.h
> @@ -25,11 +25,11 @@
>  
>  #include "libxlutil.h"
>  
> -typedef struct XLU_ConfigList {
> +struct XLU_ConfigList {
>      int avalues; /* available slots */
>      int nvalues; /* actual occupied slots */
>      XLU_ConfigValue **values;
> -} XLU_ConfigList;
> +};
>  
>  typedef struct YYLTYPE
>  {
> -- 
> 1.9.1
> 

  reply	other threads:[~2015-03-19  0:28 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-18 21:33 [PATCH] libxlu: avoid having two definitions of XLU_ConfigList Wei Liu
2015-03-19  0:28 ` Konrad Rzeszutek Wilk [this message]
2015-03-19 11:03   ` Ian Campbell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150319002815.GA25672@l.oracle.com \
    --to=konrad.wilk@oracle.com \
    --cc=ian.campbell@citrix.com \
    --cc=wei.liu2@citrix.com \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox