Re: [docs] [PATCH 12/13] ref-manual: add migration section for 3.3 release

["Paul Eggleton" <bluelightning@bluelightning.org>]

Hi Quentin

Thanks for the review!

On Wednesday, 14 April 2021 20:26:03 NZST Quentin Schulz wrote:
> On Tue, Apr 13, 2021 at 05:19:53PM -0700, Paul Eggleton wrote:
> > +BitBake changes
> > +---------------
> > +
> > +- BitBake is now configured to use a default ``umask`` of ``022`` for all
> > tasks +  (specified via a new ``BB_DEFAULT_UMASK`` variable). If needed,
> > ``umask`` can
> s/``BB_DEFAULT_UMASK``/:term:`BB_DEFAULT_UMASK`/
> 
> IIRC, this works fine even for bitbake terms (might need some tweaking
> if it does not work but I know we use :term: for some bitbake variables
> from bitbake's docs).

Wow, that does work but I didn't imagine that it would. Any idea how it 
resolves those references given that doc is not in this tree?
 
> > +- ``iproute2``: split ip binary to its own package
> 
> s/ip/``ip``/

Well spotted! Fixed.
 
> > +- The default poky :term:`DISTRO_VERSION` value now uses the core
> > metadata's +  git hash (i.e. :term:`METADATA_REVISION`) rather than the
> > date (i.e. +  :term:`DATE`) to reduce one small source of
> > non-reproducibility. You can +  of course specify your own
> > ``DISTRO_VERSION`` value as desired
> 
> s/``DISTRO_VERSION``/:term:`DISTRO_VERSION`/

Fixed.
 
> > +  (particularly if you create your own custom distro configuration).
> > +- The :ref:`ccache <ref-classes-ccache>` class now uses ``ccache`` from
> > the +  build host rather than building ``ccache-native`` (due to circular
> > +  dependencies in ccache 4.0 that are impractical to resolve otherwise),
> > so +  if you enable it you will now need to have ``ccache`` installed on
> > your +  host system.
> 
> Will a warning be shown if ccache is not installed on the host or does
> it silently fail to use ccache?

Good question, but on further digging I found the corresponding code change 
actually got reverted and I had missed that in my earlier sweep. Just as well 
you asked about it :)

I've incorporated all of your other feedback and will send a new series 
imminently.

Cheers
Paul