[PATCH] Fix makefile.

[PATCH] Fix makefile.

[Tom Isaacson]

Signed-off-by: Tom Isaacson <tom.isaacson@teknique.com>
---
 documentation/sdk-manual/working-projects.rst | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/documentation/sdk-manual/working-projects.rst b/documentation/sdk-manual/working-projects.rst
index 9a0db0099..b49a4cdca 100644
--- a/documentation/sdk-manual/working-projects.rst
+++ b/documentation/sdk-manual/working-projects.rst
@@ -296,8 +296,8 @@ example:
       	${CC} main.o module.o -o target_bin
       main.o: main.c module.h
       	${CC} -I . -c main.c
-      module.o: module.c
-      	module.h ${CC} -I . -c module.c
+      module.o: module.c module.h
+         ${CC} -I . -c module.c
       clean:
       	rm -rf *.o
       	rm target_bin
-- 
2.40.0.windows.1

Re: [docs] [PATCH] Fix makefile.

[Alexander Kanavin]

[-- Attachment #1: Type: text/plain, Size: 1368 bytes --]

What is bring fixed and why? The commit message needs to include this
information.

Alex

On Mon 29. May 2023 at 5.06, Tom Isaacson <tom.isaacson@teknique.com> wrote:

> Signed-off-by: Tom Isaacson <tom.isaacson@teknique.com>
> ---
>  documentation/sdk-manual/working-projects.rst | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/documentation/sdk-manual/working-projects.rst
> b/documentation/sdk-manual/working-projects.rst
> index 9a0db0099..b49a4cdca 100644
> --- a/documentation/sdk-manual/working-projects.rst
> +++ b/documentation/sdk-manual/working-projects.rst
> @@ -296,8 +296,8 @@ example:
>         ${CC} main.o module.o -o target_bin
>        main.o: main.c module.h
>         ${CC} -I . -c main.c
> -      module.o: module.c
> -       module.h ${CC} -I . -c module.c
> +      module.o: module.c module.h
> +         ${CC} -I . -c module.c
>        clean:
>         rm -rf *.o
>         rm target_bin
> --
> 2.40.0.windows.1
>
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#3971):
> https://lists.yoctoproject.org/g/docs/message/3971
> Mute This Topic: https://lists.yoctoproject.org/mt/99193507/1686489
> Group Owner: docs+owner@lists.yoctoproject.org
> Unsubscribe: https://lists.yoctoproject.org/g/docs/unsub [
> alex.kanavin@gmail.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>
>

[-- Attachment #2: Type: text/html, Size: 2375 bytes --]

[PATCH v2] sdk-manual: fix Makefile example

[michael.opdenacker]

From: Michael Opdenacker <michael.opdenacker@bootlin.com>

From: Tom Isaacson <tom.isaacson@teknique.com>

"module.h" should be part of the dependency line
Space fixes too

Signed-off-by: Tom Isaacson <tom.isaacson@teknique.com>
Signed-off-by: Michael Opdenacker <michael.opdenacker@bootlin.com>
---
 documentation/sdk-manual/working-projects.rst | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/documentation/sdk-manual/working-projects.rst b/documentation/sdk-manual/working-projects.rst
index 9a0db0099d..b9af33393b 100644
--- a/documentation/sdk-manual/working-projects.rst
+++ b/documentation/sdk-manual/working-projects.rst
@@ -293,11 +293,11 @@ example:
       # CC=i586-poky-linux-gcc -m32 -march=i586 --sysroot=/opt/poky/2.5/sysroots/i586-poky-linux
       # CC="gcc"
       all: main.o module.o
-      	${CC} main.o module.o -o target_bin
+        ${CC} main.o module.o -o target_bin
       main.o: main.c module.h
       	${CC} -I . -c main.c
-      module.o: module.c
-      	module.h ${CC} -I . -c module.c
+      module.o: module.c module.h
+        ${CC} -I . -c module.c
       clean:
       	rm -rf *.o
       	rm target_bin
-- 
2.34.1

Re: [docs] [PATCH] Fix makefile.

[Michael Opdenacker]

On 29.05.23 at 06:46, Alexander Kanavin wrote:
> What is bring fixed and why? The commit message needs to include this 
> information.


Happy to help with that. Thanks Isaac for the patch and Alex for the review!
Cheers
Michael.

-- 
Michael Opdenacker, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com