Re: [PATCH 2/2] ref-manual: document uboot-sign class and variables

[Michael Opdenacker <michael.opdenacker@bootlin.com>]

Hi Sean,

On 11.05.23 at 20:51, Sean Anderson wrote:
>
>> +-  :term:`UBOOT_FIT_GENERATE_KEYS`: allows to generate the keys
>> +   if they don't exist yet.
> Remove the "allows to"


Fixed, thanks

>
>> +-  :term:`UBOOT_FIT_HASH_ALG`: hash algorithm for the FIT image.
>> +-  :term:`UBOOT_FIT_KEY_GENRSA_ARGS`: ``openssl genrsa`` arguments.
>> +-  :term:`UBOOT_FIT_KEY_REQ_ARGS`: ``openssl req`` arguments.
>> +-  :term:`UBOOT_FIT_SIGN_ALG`: signature algorithm for the FIT image.
>> +-  :term:`UBOOT_FIT_SIGN_NUMBITS`: size of the private key for FIT image
>> +   signing.
>> +-  :term:`UBOOT_FIT_KEY_SIGN_PKCS`: format for the public key certificate
>> +   for FIT image signing.
> Maybe "algorithm" instead of "format"? The format stays the same (a
> binary blob), but what's changing is the way the data is interpreted.

Sure, done.

>
>> +-  :term:`UBOOT_FITIMAGE_ENABLE`: enables the generation of a U-Boot FIT image.
> enables -> enable


Good catch. Thanks.
All these fixes are now in master-next.

Thanks again
Cheers
Michael.

-- 
Michael Opdenacker, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com