public inbox for docs@lists.yoctoproject.org
 help / color / mirror / Atom feed
From: Michael Opdenacker <michael.opdenacker@bootlin.com>
To: Sean Anderson <sean.anderson@seco.com>
Cc: docs@lists.yoctoproject.org
Subject: Re: [PATCH 1/2] ref-manual: improve description of kernel-fitimage variables
Date: Fri, 12 May 2023 10:05:53 +0200	[thread overview]
Message-ID: <89950193-e9bd-4470-9f97-55e2f60525d6@bootlin.com> (raw)
In-Reply-To: <d540bdcf-5035-c16f-1118-ef80ab4358e0@seco.com>

Hi Sean,

Many thanks for the review!

On 11.05.23 at 20:43, Sean Anderson wrote:
> On 5/11/23 12:11, michael.opdenacker@bootlin.com wrote:
>> [You don't often get email from michael.opdenacker@bootlin.com. Learn why this is important at https://cas5-0-urlprotect.trendmicro.com:443/wis/clicktime/v1/query?url=https%3a%2f%2faka.ms%2fLearnAboutSenderIdentification&umid=518cf34e-efd1-4968-94ed-83b8c8896b6c&auth=d807158c60b7d2502abde8a2fc01f40662980862-ebaf0a6579314efc58145c5fef613fa0b2d5e7d3 ]
>>
>> From: Michael Opdenacker <michael.opdenacker@bootlin.com>
>>
>> - Mentioning that they are related to this class
>>    (for further information about their usage)
>> - Replace "fitImage" by "FIT image"
>> - Minor formating and style fixes
>>
>> Signed-off-by: Michael Opdenacker <michael.opdenacker@bootlin.com>
>> CC: Jamin Lin <jamin_lin@aspeedtech.com>
>> CC: Sean Anderson <sean.anderson@seco.com>
>> ---
>>   documentation/ref-manual/classes.rst   |   4 +-
>>   documentation/ref-manual/variables.rst | 105 ++++++++++++++++---------
>>   2 files changed, 68 insertions(+), 41 deletions(-)
>>
>> diff --git a/documentation/ref-manual/classes.rst b/documentation/ref-manual/classes.rst
>> index 94b6a3ebd7..2f96ffb82f 100644
>> --- a/documentation/ref-manual/classes.rst
>> +++ b/documentation/ref-manual/classes.rst
>> @@ -1582,13 +1582,13 @@ The :ref:`ref-classes-kernel-devicetree` class, which is inherited by the
>>   ===================
>>
>>   The :ref:`ref-classes-kernel-fitimage` class provides support to pack a kernel image,
>> -device trees, a U-boot script, a :term:`Initramfs` bundle and a RAM disk
>> +device trees, a U-boot script, an :term:`Initramfs` bundle and a RAM disk
> If we're being pedantic, it's "U-Boot." All these variables should really be U_BOOT_... too, but that ship has sailed.
Yes, things can be complicated to change once they have been deployed :|
>
> Reviewed-by: Sean Anderson <sean.anderson@seco.com>


Thanks again!
Cheers
Michael.

-- 
Michael Opdenacker, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com



      parent reply	other threads:[~2023-05-12  8:06 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-11 16:11 [PATCH 1/2] ref-manual: improve description of kernel-fitimage variables michael.opdenacker
2023-05-11 16:11 ` [PATCH 2/2] ref-manual: document uboot-sign class and variables michael.opdenacker
     [not found]   ` <ee686b0e-410f-6ff8-2a10-be6fbb6446cc@seco.com>
2023-05-12  8:13     ` Michael Opdenacker
     [not found] ` <d540bdcf-5035-c16f-1118-ef80ab4358e0@seco.com>
2023-05-12  8:05   ` Michael Opdenacker [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=89950193-e9bd-4470-9f97-55e2f60525d6@bootlin.com \
    --to=michael.opdenacker@bootlin.com \
    --cc=docs@lists.yoctoproject.org \
    --cc=sean.anderson@seco.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox