Re: [docs] [PATCH] ref-manual: add missing quotes

["Ulrich Ölmann" <u.oelmann@pengutronix.de>]

Hi there,

On Sun, Feb 12 2023 at 22:41 +0100, Ulrich Ölmann <u.oelmann@pengutronix.de> wrote:
> Signed-off-by: Ulrich Ölmann <u.oelmann@pengutronix.de>
> ---
>  documentation/ref-manual/variables.rst | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/documentation/ref-manual/variables.rst b/documentation/ref-manual/variables.rst
> index a36c4c6df962..c561aae6563a 100644
> --- a/documentation/ref-manual/variables.rst
> +++ b/documentation/ref-manual/variables.rst
> @@ -4275,7 +4275,7 @@ system and gives an overview of their function and contents.
>        To use the variable, set it in the append file for your kernel recipe
>        using the following form::
>
> -         KBUILD_DEFCONFIG_KMACHINE ?= defconfig_file
> +         KBUILD_DEFCONFIG_KMACHINE ?= "defconfig_file"

I did not find any occurance of a variable named "KBUILD_DEFCONFIG_
KMACHINE" in kernel-yocto.bbclass and from the above line's context my
feeling is that the last underscore was meant to be the old override
syntax which should be updated to ":" now. If this is correct then I
would additionally expect the override not to be KMACHINE but MACHINE
instead as only the latter is a valid override. Could someone with more
insight please confirm or reject my suspicion?

In case of positive feedback I would gladly send another patch doing a

  s/KBUILD_DEFCONFIG_KMACHINE/KBUILD_DEFCONFIG:MACHINE/

that changes both occurances in ref-manual/variables.rst and kernel-dev/
common.rst.

Best regards
Ulrich


>        Here is an example from a "raspberrypi2" :term:`KMACHINE` build that uses
>        a ``defconfig`` file named "bcm2709_defconfig"::
-- 
Pengutronix e.K.                           | Ulrich Ölmann               |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |