public inbox for docs@lists.yoctoproject.org
 help / color / mirror / Atom feed
From: Joao Marcos Costa <joaomarcos.costa@bootlin.com>
To: quentin.schulz@cherry.de, docs@lists.yoctoproject.org
Subject: Re: [docs] [PATCH] ref-manual/variables.rst: fix wording in COMPATIBLE_MACHINE note
Date: Thu, 9 Apr 2026 13:22:35 +0200	[thread overview]
Message-ID: <7d76e296-5ec5-4dd2-8813-782b497a58a8@bootlin.com> (raw)
In-Reply-To: <5ff51b37-613a-448d-949f-406a56f1a012@cherry.de>

Hello, Quentin

On 4/9/26 12:29, Quentin Schulz via lists.yoctoproject.org wrote:
> Hi João,
> 
> On 4/9/26 11:40 AM, Joao Marcos Costa via lists.yoctoproject.org wrote:
>> Add missing "that" between "recipe" and "inherits".
>>
>> Signed-off-by: João Marcos Costa <joaomarcos.costa@bootlin.com>
>> ---
>>   documentation/ref-manual/variables.rst | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/documentation/ref-manual/variables.rst 
>> b/documentation/ref-manual/variables.rst
>> index 60e608c0c..8466124e0 100644
>> --- a/documentation/ref-manual/variables.rst
>> +++ b/documentation/ref-manual/variables.rst
>> @@ -1679,7 +1679,7 @@ system and gives an overview of their function 
>> and contents.
>>         .. note::
>> -         When :term:`COMPATIBLE_MACHINE` is set in a recipe inherits 
>> from
>> +         When :term:`COMPATIBLE_MACHINE` is set in a recipe that 
>> inherits from
>>            native, the recipe is always skipped. All native recipes 
>> must be
> 
> Doesn't read well to me still. I would say maybe go for
> 
> "in a native recipe"
> 
> What do you think?
> 
> Cheers,
> Quentin

I like the current phrasing, to be honest. My only concern about it is 
the grammar, so my goal here is to provide a plain fix rather than a 
subjective improvement in semantics.

Thanks for the review!

-- 
Best regards,
João Marcos Costa


  reply	other threads:[~2026-04-09 11:22 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-09  9:40 [PATCH] ref-manual/variables.rst: fix wording in COMPATIBLE_MACHINE note João Marcos Costa
2026-04-09 10:29 ` [docs] " Quentin Schulz
2026-04-09 11:22   ` Joao Marcos Costa [this message]
2026-04-09 11:32     ` Quentin Schulz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7d76e296-5ec5-4dd2-8813-782b497a58a8@bootlin.com \
    --to=joaomarcos.costa@bootlin.com \
    --cc=docs@lists.yoctoproject.org \
    --cc=quentin.schulz@cherry.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox