Re: [PATCH 2/2] migration-guides/{migration,release-note}-5.2: improvements and fixes

[Quentin Schulz <quentin.schulz@cherry.de>]

Hi Antonin,

On 4/3/25 4:08 PM, Antonin Godard wrote:
> Address some of the reviews received on the release notes and migration
> guide for 5.2:
> 
> - Remove the wget fetcher addition, I misread commit 0a9f90ff658e
>    ("tests/fetch: support setting PV in the wget fetcher") from BitBake,
>    and it actually affects the tests for the wget fetcher, not the
>    fetcher itself.
> - Add a way to transition from the branch=nameX,nameY syntax. From what
>    I have tested, I achieve the same behavior when using one or the other
>    syntax.
> - Remove the default value for SPDX_PACKAGE_VERSION in the release note.
> - Fix a couple of typos.
> 
> Suggested-by: Quentin Schulz <quentin.schulz@cherry.de>
> Signed-off-by: Antonin Godard <antonin.godard@bootlin.com>
> ---
>   documentation/migration-guides/migration-5.2.rst     | 10 +++++++++-
>   documentation/migration-guides/release-notes-5.2.rst |  7 ++-----
>   2 files changed, 11 insertions(+), 6 deletions(-)
> 
> diff --git a/documentation/migration-guides/migration-5.2.rst b/documentation/migration-guides/migration-5.2.rst
> index c54f054c7..59f21ff4c 100644
> --- a/documentation/migration-guides/migration-5.2.rst
> +++ b/documentation/migration-guides/migration-5.2.rst
> @@ -193,6 +193,14 @@ anymore::
>   This was rarely used in the core repositories, and this removal simplifies the
>   code logic in several places.
>   
> +If one of your recipes is still using this mechanism, you can split the
> +code source fetching into two separate entries::
> +
> +   SRC_URI = "git://some.host/somepath;branch=branchX;name=nameX \
> +              git://some.host/somepath;branch=branchY;name=nameY"
> +   SRCREV_nameX = "xxxxxxxxxxxxxxxxxxxx"
> +   SRCREV_nameY = "yyyyyyyyyyyyyyyyyyyy"
> +
>   Git fetcher: Branch parameter now required in :term:`SRC_URI`
>   ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>   
> @@ -242,7 +250,7 @@ The following recipes have been removed in this release:
>      :oe_git:`openembedded-core </openembedded-core>` or :oe_git:`meta-openembedded </meta-openembedded>`.
>   
>   -  ``blktool``: It was created in 2004 as an alternative to hdparm and never
> -   updated since (while :wikipedia:`hdparm <Hdparm>` remains in active.
> +   updated since (while :wikipedia:`hdparm <Hdparm>` remains in active).

Mmmm, should we say

s/remains in active/remains active/ ?

Slow brain day so maybe my intuition is wrong today :)

>   
>   -  ``cargo-c-native``: converted to a target recipe and renamed to ``cargo-c``.
>   
> diff --git a/documentation/migration-guides/release-notes-5.2.rst b/documentation/migration-guides/release-notes-5.2.rst
> index 05fc92e85..2ad441449 100644
> --- a/documentation/migration-guides/release-notes-5.2.rst
> +++ b/documentation/migration-guides/release-notes-5.2.rst
> @@ -44,11 +44,10 @@ New Features / Enhancements in |yocto-ver|
>         uses.
>   
>      -  The :term:`GRUB_MKIMAGE_OPTS` can be used to control the flags to the
> -      ``grub-mkimage`` command in the context of the Grub recipe (``grub-efi``).
> +      ``grub-mkimage`` command in the context of the GRUB recipe (``grub-efi``).
>   
>      -  The :term:`SPDX_PACKAGE_VERSION` variable controls the package version as
> -      seen in the SPDX 3.0 JSON output (``software_packageVersion``). The default
> -      value for this variable is :term:`PV`.
> +      seen in the SPDX 3.0 JSON output (``software_packageVersion``).

The indentation seems odd here (but to be fair, it is also in the part 
of the diff that is being removed).

Cheers,
Quentin