Re: [PATCH 2/2] migration-guides/{migration,release-note}-5.2: improvements and fixes

["Antonin Godard" <antonin.godard@bootlin.com>]

Hi Quentin,

On Thu Apr 3, 2025 at 7:37 PM CEST, Quentin Schulz wrote:
> Hi Antonin,
>
> On 4/3/25 5:10 PM, Antonin Godard wrote:
>> Hi Quentin,
>> 
>> On Thu Apr 3, 2025 at 4:23 PM CEST, Quentin Schulz wrote:
>>> Hi Antonin,
>>>
>>> On 4/3/25 4:08 PM, Antonin Godard wrote:
>>>> Address some of the reviews received on the release notes and migration
>>>> guide for 5.2:
>>>>
>>>> - Remove the wget fetcher addition, I misread commit 0a9f90ff658e
>>>>     ("tests/fetch: support setting PV in the wget fetcher") from BitBake,
>>>>     and it actually affects the tests for the wget fetcher, not the
>>>>     fetcher itself.
>>>> - Add a way to transition from the branch=nameX,nameY syntax. From what
>>>>     I have tested, I achieve the same behavior when using one or the other
>>>>     syntax.
>>>> - Remove the default value for SPDX_PACKAGE_VERSION in the release note.
>>>> - Fix a couple of typos.
>>>>
>>>> Suggested-by: Quentin Schulz <quentin.schulz@cherry.de>
>>>> Signed-off-by: Antonin Godard <antonin.godard@bootlin.com>
>>>> ---
>>>>    documentation/migration-guides/migration-5.2.rst     | 10 +++++++++-
>>>>    documentation/migration-guides/release-notes-5.2.rst |  7 ++-----
>>>>    2 files changed, 11 insertions(+), 6 deletions(-)
>>>>
>>>> diff --git a/documentation/migration-guides/migration-5.2.rst b/documentation/migration-guides/migration-5.2.rst
>>>> index c54f054c7..59f21ff4c 100644
>>>> --- a/documentation/migration-guides/migration-5.2.rst
>>>> +++ b/documentation/migration-guides/migration-5.2.rst
>>>> @@ -193,6 +193,14 @@ anymore::
>>>>    This was rarely used in the core repositories, and this removal simplifies the
>>>>    code logic in several places.
>>>>    
>>>> +If one of your recipes is still using this mechanism, you can split the
>>>> +code source fetching into two separate entries::
>>>> +
>>>> +   SRC_URI = "git://some.host/somepath;branch=branchX;name=nameX \
>>>> +              git://some.host/somepath;branch=branchY;name=nameY"
>>>> +   SRCREV_nameX = "xxxxxxxxxxxxxxxxxxxx"
>>>> +   SRCREV_nameY = "yyyyyyyyyyyyyyyyyyyy"
>>>> +
>
> Just to make sure we don't miss this for the v2, but this "solution" was 
> rejected by Richard as non-working, see 
> https://lore.kernel.org/yocto-docs/9c3af54f0c74af0b9d0887e0408fd591e936c4da.camel@linuxfoundation.org/T/#u

Hm, but there are recipes using this in oe-core like [1]. Does that mean that
these are broken at the moment?

In my testing, I could properly fetch and unpack such recipes with one syntax or
the other. Indeed, after unpacking, only the source code of the first item of
SRC_URI is unpacked and present in the WORKDIR, yet BitBake does not complain
about the second one or produce any kind of error. So I'm not sure of what to
conclude on this?

I'm not sure what is the best to say in the release notes.

[1]: https://git.openembedded.org/openembedded-core/tree/meta-selftest/recipes-extended/sysdig/sysdig-selftest_0.28.0.bb#n25

Antonin

-- 
Antonin Godard, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com