From: Trevor Woerner <twoerner@gmail.com>
To: Quentin Schulz <quentin.schulz@cherry.de>
Cc: docs@lists.yoctoproject.org
Subject: Re: [docs] [PATCH v2 5/8] docs: mark the placeholders in examples
Date: Thu, 24 Sep 2026 11:58:22 -0400 [thread overview]
Message-ID: <arVInhJefH824gNT@localhost.localdomain> (raw)
In-Reply-To: <440060d6-6522-4703-a036-ec42d128f0ad@cherry.de>
On Wed 2026-09-23 @ 12:57:39 PM, Quentin Schulz wrote:
> Hi Trevor,
>
> On 9/22/26 8:32 PM, Trevor Woerner via lists.yoctoproject.org wrote:
> > Values the reader is expected to replace are written as though they were
> > literal. "arch-gdb" reads like a command that exists, a Git SRC_URI
> > example reads like a URL and a pair of revisions worth copying, and the
> > git-config examples give an account name and address that are somebody
> > else's. Put them in the angle brackets the manuals already use for the
> > purpose.
> >
> > Two corrections go with them: the directory placeholder in the GDB
> > example described itself at length rather than naming the thing, and the
> > smtppass example carried a stray "=". Since git config takes a name and
> > then a value, that "=" was the value, and the password behind it an
> > argument git config reads as a pattern.
> >
> > AI-Generated: codex/claude-opus 5 (xhigh)
> > Signed-off-by: Trevor Woerner <twoerner@gmail.com>
> > ---
> > changes in v2:
> > - rebased on master-next; no other change
> > ---
> > .../contributor-guide/submit-changes.rst | 12 ++++++------
> > documentation/dev-manual/debugging.rst | 8 ++++----
> > documentation/migration-guides/migration-5.2.rst | 16 ++++++++--------
> > documentation/ref-manual/devtool-reference.rst | 2 +-
> > documentation/ref-manual/variables.rst | 2 +-
> > 5 files changed, 20 insertions(+), 20 deletions(-)
> >
> > diff --git a/documentation/contributor-guide/submit-changes.rst b/documentation/contributor-guide/submit-changes.rst
> > index e60f8ca7ace3..a283eb734768 100644
> > --- a/documentation/contributor-guide/submit-changes.rst
> > +++ b/documentation/contributor-guide/submit-changes.rst
> > @@ -62,8 +62,8 @@ on Debian and Ubuntu::
> > Then, you need to set a name and e-mail address that Git will
> > use to identify your commits::
> > - $ git config --global user.name "Ada Lovelace"
> > - $ git config --global user.email "ada.lovelace@gmail.com"
> > + $ git config --global user.name "<name>"
>
> <firstname> <lastname>
Sounds good, i like the above one.
> maybe? I'm guessing some cultures have other orders, I've seen
>
> <lastname>, <firstname>
>
> a few times.
>
> > + $ git config --global user.email "<email>"
> > By default, Git adds a signature line at the end of patches containing the Git
> > version. We suggest to remove it as it doesn't add useful information.
> > @@ -399,8 +399,8 @@ regular STMP server, using a Google Mail account as an example::
> > $ git config --global sendemail.smtpserver smtp.gmail.com
>
> Why is this not changed to a placeholder?
Sounds good.
> > $ git config --global sendemail.smtpserverport 587
> > $ git config --global sendemail.smtpencryption tls
> > - $ git config --global sendemail.smtpuser ada.lovelace@gmail.com
> > - $ git config --global sendemail.smtppass = XXXXXXXX
> > + $ git config --global sendemail.smtpuser <email>
> > + $ git config --global sendemail.smtppass <password>
>
> It's also optional, in which case you're prompted every time you send a
> mail, which I kinda like :)
>
> > These settings will appear in the ``.gitconfig`` file in your home directory.
> > @@ -509,7 +509,7 @@ We have a frequent issue with contributors whose patches are received through
> > a ``From`` field which doesn't match the ``Signed-off-by`` information. Here is
> > a typical example for people sending from a domain name with :wikipedia:`DMARC`::
> > - From: "Linus Torvalds via lists.openembedded.org <linus.torvalds=kernel.org@lists.openembedded.org>"
> > + From: "xxx via lists.openembedded.org <xxx@lists.openembedded.org>"
>
> Please keep this one (or use an example that exists in the wild, I don't
> think Linus sent patches to OE-Core :)) as it is an actual example.
Okay.
> > This ``From`` field is used by ``git am`` to recreate commits with the right
> > author name. The following will ensure that your e-mails have an additional
> > @@ -517,7 +517,7 @@ author name. The following will ensure that your e-mails have an additional
> > maintainers accepting your patches don't have to fix commit author information
> > manually::
> > - $ git config --global sendemail.from "linus.torvalds@kernel.org"
> > + $ git config --global sendemail.from "<email>"
> > The ``sendemail.from`` should match your ``user.email`` setting,
> > which appears in the ``Signed-off-by`` line of your commits.
> > diff --git a/documentation/dev-manual/debugging.rst b/documentation/dev-manual/debugging.rst
> > index 0f6e9d1d7e85..8412c997a51e 100644
> > --- a/documentation/dev-manual/debugging.rst
> > +++ b/documentation/dev-manual/debugging.rst
> > @@ -810,7 +810,7 @@ be visible. In this case, there is a missing dependency for the ``neard``
> > Makefile target. Here is some abbreviated, sample output with the
> > missing dependency clearly visible at the end::
> > - i586-poky-linux-gcc -m32 -march=i586 --sysroot=/home/scott-lenovo/......
> > + i586-poky-linux-gcc -m32 -march=i586 --sysroot=<path/to/sysroot>
> > .
> > .
> > .
> > @@ -1114,11 +1114,11 @@ debugger.
> > After running gdbserver on the target, you need to run Gdb on the
> > host and configure it and connect to the target. Use these commands::
> > - $ cd directory-holding-the-debugfs-directory
> > - $ arch-gdb
> > + $ cd <debugfs-directory>
> > + $ <arch>-gdb
> > (gdb) set sysroot debugfs
> > (gdb) set substitute-path /usr/src/debug debugfs/usr/src/debug
> > - (gdb) target remote IP-of-target:1234
> > + (gdb) target remote <IP-of-target>:1234
>
> Here's yet another prompt we should support that I don't think it's
> supported in patch 2/8.
Agreed! Good catch.
> > At this
> > point, everything should automatically load (i.e. matching binaries,
> > diff --git a/documentation/migration-guides/migration-5.2.rst b/documentation/migration-guides/migration-5.2.rst
> > index 77a11fe27047..48f9e7485d93 100644
> > --- a/documentation/migration-guides/migration-5.2.rst
> > +++ b/documentation/migration-guides/migration-5.2.rst
> > @@ -193,9 +193,9 @@ The support for having multiple Git revisions per URL in :term:`SRC_URI` was
> > removed from BitBake, which means the following syntax is not supported
> > anymore::
> > - SRC_URI = "git://some.host/somepath;bareclone=1;branch=branchX,branchY;name=nameX,nameY"
> > - SRCREV_nameX = "xxxxxxxxxxxxxxxxxxxx"
> > - SRCREV_nameY = "yyyyyyyyyyyyyyyyyyyy"
> > + SRC_URI = "git://<some.host>/<somepath>;bareclone=1;branch=<branchX>,<branchY>;name=<nameX>,<nameY>"
> > + SRCREV_<nameX> = "<revisionX>"
> > + SRCREV_<nameY> = "<revisionY>"
>
> We should say that this is the full sha of the commit.
Sounds good. I thought "revisionX" was better enough from "xxxx", but
SHA is better yet.
> > This was rarely used in the core repositories because it would only ever make
> > sense for bare clones (the ``bareclone=1`` :term:`SRC_URI` option) where recipes
> > @@ -205,10 +205,10 @@ places.
> > If one of your recipes is using this mechanism, you can split the code source
> > fetching into two separate entries::
> > - SRC_URI = "git://some.host/somepath;bareclone=1;branch=branchX;name=nameX \
> > - git://some.host/somepath;bareclone=1;branch=branchY;name=nameY"
> > - SRCREV_nameX = "xxxxxxxxxxxxxxxxxxxx"
> > - SRCREV_nameY = "yyyyyyyyyyyyyyyyyyyy"
> > + SRC_URI = "git://<some.host>/<somepath>;bareclone=1;branch=<branchX>;name=<nameX> \
> > + git://<some.host>/<somepath>;bareclone=1;branch=<branchY>;name=<nameY>"
> > + SRCREV_<nameX> = "<revisionX>"
> > + SRCREV_<nameY> = "<revisionY>"
>
> Ditto.
Got it.
> Cheers,
> Quentin
next prev parent reply other threads:[~2026-09-24 15:58 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-22 18:32 [PATCH v2 0/8] docs: editorial repairs to the examples Trevor Woerner
2026-09-22 18:32 ` [PATCH v2 1/8] docs: give the root prompts a preamble Trevor Woerner
2026-09-23 10:17 ` [docs] " Quentin Schulz
2026-09-24 16:00 ` Trevor Woerner
2026-09-22 18:32 ` [PATCH v2 2/8] docs: copy only the command from a console block Trevor Woerner
2026-09-23 10:41 ` [docs] " Quentin Schulz
2026-09-23 10:43 ` Quentin Schulz
2026-09-22 18:32 ` [PATCH v2 3/8] docs: show a prompt on commands the reader is meant to type Trevor Woerner
2026-09-23 10:49 ` [docs] " Quentin Schulz
2026-09-24 15:59 ` Trevor Woerner
2026-09-22 18:32 ` [PATCH v2 4/8] docs: write an elided passage as a comment Trevor Woerner
2026-09-23 10:50 ` [docs] " Quentin Schulz
2026-09-22 18:32 ` [PATCH v2 5/8] docs: mark the placeholders in examples Trevor Woerner
2026-09-23 10:57 ` [docs] " Quentin Schulz
2026-09-24 15:58 ` Trevor Woerner [this message]
2026-09-22 18:32 ` [PATCH v2 6/8] docs: remove real accounts from the examples Trevor Woerner
2026-09-23 11:02 ` [docs] " Quentin Schulz
2026-09-24 15:55 ` Trevor Woerner
2026-09-22 18:32 ` [PATCH v2 7/8] kernel-dev: give each example block one thing to hold Trevor Woerner
2026-09-23 11:05 ` [docs] " Quentin Schulz
2026-09-22 18:32 ` [PATCH v2 8/8] ref-manual: put the ARCHIVER_MODE comments on their own lines Trevor Woerner
2026-09-23 11:09 ` [docs] " Quentin Schulz
2026-09-24 15:55 ` Trevor Woerner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=arVInhJefH824gNT@localhost.localdomain \
--to=twoerner@gmail.com \
--cc=docs@lists.yoctoproject.org \
--cc=quentin.schulz@cherry.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox