[PATCH] irqbalance: add PACKAGECONFIG for ui

[PATCH] irqbalance: add PACKAGECONFIG for ui

[jaeyoon.jung]

From: Jaeyoon Jung <jaeyoon.jung@lge.com>

Add 'ui' to PACKAGECONFIG, corresponding to the '--with-irqbalance-ui'
configure option along with an explicit build dependency on ncurses.
Add it to the default PACKAGECONFIG since the feature is enabled by
default unless '--without-irqbalance-ui' is specified.

Signed-off-by: Jaeyoon Jung <jaeyoon.jung@lge.com>
---
 recipes-extended/irqbalance/irqbalance.inc | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/recipes-extended/irqbalance/irqbalance.inc b/recipes-extended/irqbalance/irqbalance.inc
index 0c570e12..a0dda231 100644
--- a/recipes-extended/irqbalance/irqbalance.inc
+++ b/recipes-extended/irqbalance/irqbalance.inc
@@ -28,12 +28,13 @@ EXTRA_OECONF = "--program-transform-name= \
 
 # let the recipes or appends define options
 #
-PACKAGECONFIG ?= "${@bb.utils.contains('DISTRO_FEATURES', 'systemd', 'systemd', '', d)}"
+PACKAGECONFIG ?= "${@bb.utils.contains('DISTRO_FEATURES', 'systemd', 'systemd', '', d)} ui"
 # enable,disable,depends,rdepends
 #
 PACKAGECONFIG[numa] = "--enable-numa,--disable-numa,numactl,"
 PACKAGECONFIG[libcap-ng] = "--with-libcap-ng,--without-libcap-ng,libcap-ng,"
 PACKAGECONFIG[systemd] = "--with-systemd --with-pkgconfdir=${sysconfdir},--with-pkgconfdir=${sysconfdir},systemd,"
+PACKAGECONFIG[ui] = "--with-irqbalance-ui,--without-irqbalance-ui,ncurses,"
 
 do_install () {
         oe_runmake 'DESTDIR=${D}' install

Re: [meta-virtualization] [PATCH] irqbalance: add PACKAGECONFIG for ui

[Bruce Ashfield]

Hi Jaeyoon,

merged, but only after some empirical checking. Reading the diff,
adding 'ui' to the default PACKAGECONFIG line reads as adding new
functionality that wasn't in the default set before, which is
normally the opt-in pattern we'd ask for (add the PACKAGECONFIG[ui]
entry so consumers can enable it, but don't put it in the default
line). So I did a fresh build of the pre-patch recipe first to see
what was actually being produced.

It turns out irqbalance-ui was already being built. configure.ac
defaults with_irqbalanceui=yes, PKG_CHECK_MODULES([NCURSESW]) finds
ncurses in the recipe sysroot via transitive DEPENDS from other
packages, and /usr/sbin/irqbalance-ui lands in the image with
configure log "checking for ncursesw... yes".

So our current PACKAGECONFIG default (without 'ui') was already
producing the ui binary; the recipe just wasn't declaring it. This
patch aligns the declared PACKAGECONFIG with what we've been
shipping, adds the explicit ncurses DEPENDS the build was silently
relying on, and gives consumers a way to actually opt out via
PACKAGECONFIG:remove.

For future PACKAGECONFIG changes that add or reorder default
entries, please include this kind of empirical verification in
the commit message: what the pre-patch build was actually
producing, and why the change preserves rather than adds default
behaviour. Otherwise the diff reads as an opt-in becoming default
without a matching justification, and it takes a reviewer
reproducing the build to trust the claim. I've added a maintainer
note to the merged commit summarising the check.

Bruce