Yocto Project Discussions
 help / color / mirror / Atom feed
From: "Alexis Lothoré" <alexis.lothore@bootlin.com>
To: Ross Burton <Ross.Burton@arm.com>
Cc: Yocto discussion list <yocto@lists.yoctoproject.org>,
	Richard Purdie <richard.purdie@linuxfoundation.org>
Subject: Re: [yocto] QA notification for completed autobuilder build (yocto-4.3.rc1)
Date: Thu, 19 Oct 2023 14:28:17 +0200	[thread overview]
Message-ID: <39978441-6f8d-48be-92db-00cd66e13c00@bootlin.com> (raw)
In-Reply-To: <90D7FE40-32EB-4D67-B099-9E0C764FC258@arm.com>

Hi Ross,
On 10/19/23 13:04, Ross Burton wrote:
>> On 19 Oct 2023, at 09:36, Alexis Lothoré via lists.yoctoproject.org <alexis.lothore=bootlin.com@lists.yoctoproject.org> wrote:
> I just skimmed your report and have some feedback to hopefully make it easier to read in the future.
> 
> I’d suggest sorting the output in order of importance.  For example, this is a section that I really don’t care about:
> 
> Match:       sdk_core-image-sato_x86_64_fvp-base_20230910083055
>              sdk_core-image-sato_x86_64_fvp-base_20231017222150
> 
> Put those at the bottom, or even better collate them into a single section where there have been no changes.
> 
> Similarly:
> 
> Match:       runtime_core-image-sato_qemux86_20230911011430
>              runtime_core-image-sato_qemux86_20231017223736
>     Additionally, 1 new test(s) is/are present
> 
> I guess marginally more important than identical results, but “there are new tests that passed” isn’t very interesting.

Indeed, not so useful and hiding the real content at the bottom

> Regression: oeselftest_ubuntu-22.04_qemux86-64_20230911011940
>     oeselftest_almalinux-9.2_qemux86-64_20231017221342
> 
> Should they have matched? The host distro doesn’t match and this matters for some of the tests, as some distros don’t support some of the selftests. In this case specifically, there are seven regressions and six of them are specific to the host changing, which has the side-effect of hiding the one actual regression.

Yeah, that's a point I have been struggling with when starting to update those
tools. The initial assumption I have started working with, after discussing the
matter with Richard (see [1]), is the following:
1. MACHINE _must_ match between base and target
2. Different HOSTS _can_ be cross-checked

But the issue you are pointing tends to show it does not work well in some
cases. I will have to do some tests to see if dropping 2. reduce this noise
without loosing valuable data, or if we need to find something smarter

> 
> The report then lists the first however many regressions before announcing the summary:
> 
>  (In total, 7134 regressions/status changes detected)
>     Additionally, 7 previously failing test(s) is/are now passing
>     Additionally, 4622 new test(s) is/are present
>  
> The headline figure of 7134 regressions should be first, as that’s the most important data point in a skim of the report.  List the summary first, and then the breakdown.

ACK

> Grouping the results would be interesting, because the list got truncated I can’t see easily if all 7134 regressions were in ptestresult.gcc-g++-user.* or if that was just the first 100 and the rest were other components.  Breaking the ptest results up by the second level component would be interesting, if it said something like this then we’d be able to get a feel for what components have broken from the report.
> 
> 7134 regressions detected.
>     ptestresult.gcc-libstdc++-v3-user.30_threads/thread/native_handle/cancel.cc execution test: PASS -> FAIL
>     [ say 10 results per component ]
>     And 6123 more in ptestresult.gcc-libstdc++v3
>     ptestresult.gcc-libgomp.libgomp.c++/ctor-10.C: UNSUPPORTED -> UNRESOLVED

Makes sense. I have posted this morning the series introducing the display limit
([2]), I can work on a v2 implementing the ptest specific display limit

> This one also caught my eye:
> Regression:  runtime_core-image-sato_qemuppc_20230910082140
>              runtime_core-image-sato_qemuppc_20231017222112
>     systemd.SystemdJournalTests.test_systemd_boot_time: PASSED -> SKIPPED
>     Additionally, 1 new test(s) is/are present
> 
> Is that comparing a systemd test run with a sysvinit test run?

I think the comparison is relevant, both are bout systemd system (many systemd
tests are present and OK in runtime_core-image-sato_qemuppc_20231017222112
results). However I do not get why it is marked as skipped and not failed:

            "systemd.SystemdJournalTests.test_systemd_boot_time": {
                "duration": 2.3783957958221436,
                "log": "Error when parsing time from boot string",
                "status": "SKIPPED"
            }

Maybe an issue in the corresponding runner ?

> Thanks for the work on the tool so far, this is a lot easier to read than the full reports!
> 
> Ross

Thank you for having taken time to give some feedback !

[1] https://lists.yoctoproject.org/g/automated-testing/message/1216
[2]
https://lore.kernel.org/openembedded-core/20231019095352.25923-1-alexis.lothore@bootlin.com/

-- 
Alexis Lothoré, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com



  reply	other threads:[~2023-10-19 12:27 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-18  6:16 QA notification for completed autobuilder build (yocto-4.3.rc1) Pokybuild User
2023-10-18  6:29 ` [qa-build-notification] " Richard Purdie
2023-10-18 15:32   ` [tsc] " Ross Burton
2023-10-18 19:43     ` Richard Purdie
2023-10-19  8:36 ` [yocto] " Alexis Lothoré
2023-10-19 11:04   ` Ross Burton
2023-10-19 12:28     ` Alexis Lothoré [this message]
2023-10-19 12:55       ` Richard Purdie
2023-10-19 12:23   ` Richard Purdie
2023-10-19 14:06 ` [qa-build-notification] " Tham, Jing Hui
2023-10-19 16:03   ` Richard Purdie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=39978441-6f8d-48be-92db-00cd66e13c00@bootlin.com \
    --to=alexis.lothore@bootlin.com \
    --cc=Ross.Burton@arm.com \
    --cc=richard.purdie@linuxfoundation.org \
    --cc=yocto@lists.yoctoproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox