[lm-sensors] [PATCH] Don't point the user to the ipmisensors driver

* [lm-sensors] [PATCH] Don't point the user to the ipmisensors driver
@ 2011-06-08 13:18 Jean Delvare
  2011-06-08 13:58 ` [lm-sensors] [PATCH] Don't point the user to the ipmisensors Guenter Roeck
                   ` (4 more replies)
  0 siblings, 5 replies; 6+ messages in thread
From: Jean Delvare @ 2011-06-08 13:18 UTC (permalink / raw)
  To: lm-sensors

The development of the ipmisensors driver stalled 5 years ago, the
driver isn't usable, so stop pointing the users to it, it only confuses
them. See https://bugzilla.novell.com/show_bug.cgi?idU8756 for
example.

---
I have this patch in openSUSE for 1.5 year, any objection to me
getting it upstream for everyone's benefit?

 prog/detect/sensors-detect |    9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

--- lm-sensors.orig/prog/detect/sensors-detect	2011-06-08 14:59:16.000000000 +0200
+++ lm-sensors/prog/detect/sensors-detect	2011-06-08 15:12:04.000000000 +0200
@@ -1356,12 +1356,12 @@ use vars qw(@i2c_adapter_names);
 @ipmi_ifs = (
 	{
 		name => "IPMI BMC KCS",
-		driver => "ipmisensors",
+		driver => "to-be-written",	# ipmisensors
 		isa_addrs => [0x0ca0],
 		isa_detect => sub { ipmi_detect(@_); },
 	}, {
 		name => "IPMI BMC SMIC",
-		driver => "ipmisensors",
+		driver => "to-be-written",	# ipmisensors
 		isa_addrs => [0x0ca8],
 		isa_detect => sub { ipmi_detect(@_); },
 	}
@@ -6039,6 +6039,7 @@ sub w83781d_isa_detect
 sub ipmi_from_smbios
 {
 	my ($version, $if, @ipmi_if);
+	my $ipmi_driver = "to-be-written";	# ipmisensors
 
 	return 0 unless check_dmidecode_version();
 
@@ -6074,13 +6075,13 @@ sub ipmi_from_smbios
 						 $if->{type}));
 		}
 		print "Success!\n".
-		      "    (confidence 8, driver `ipmisensors')\n";
+		      "    (confidence 8, driver `$ipmi_driver')\n";
 		my $new_hash = {
 			conf => 8,
 			isa_addr => $if->{addr} || 0,
 			chipname => $if->{type},
 		};
-		add_isa_to_chips_detected("ipmisensors", $new_hash);
+		add_isa_to_chips_detected($ipmi_driver, $new_hash);
 	}
 
 	return scalar @ipmi_if;


-- 
Jean Delvare

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

^ permalink raw reply	[flat|nested] 6+ messages in thread