* Re: [lm-sensors] [PATCH] Don't point the user to the ipmisensors
2011-06-08 13:18 [lm-sensors] [PATCH] Don't point the user to the ipmisensors driver Jean Delvare
@ 2011-06-08 13:58 ` Guenter Roeck
2011-06-08 14:27 ` Phil Pokorny
` (3 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: Guenter Roeck @ 2011-06-08 13:58 UTC (permalink / raw)
To: lm-sensors
On Wed, Jun 08, 2011 at 09:18:43AM -0400, Jean Delvare wrote:
> The development of the ipmisensors driver stalled 5 years ago, the
> driver isn't usable, so stop pointing the users to it, it only confuses
> them. See https://bugzilla.novell.com/show_bug.cgi?idU8756 for
> example.
>
> ---
> I have this patch in openSUSE for 1.5 year, any objection to me
> getting it upstream for everyone's benefit?
>
Makes sense to me. Too bad this driver is not supported, though - I would need it ;).
Guenter
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [lm-sensors] [PATCH] Don't point the user to the ipmisensors
2011-06-08 13:18 [lm-sensors] [PATCH] Don't point the user to the ipmisensors driver Jean Delvare
2011-06-08 13:58 ` [lm-sensors] [PATCH] Don't point the user to the ipmisensors Guenter Roeck
@ 2011-06-08 14:27 ` Phil Pokorny
2011-06-08 14:29 ` Aurelien Jarno
` (2 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: Phil Pokorny @ 2011-06-08 14:27 UTC (permalink / raw)
To: lm-sensors
Is that the same driver as bmcsensors?
--
Philip Pokorny, RHCE
Chief Hardware Architect
PENGUIN COMPUTING, Inc
www.penguincomputing.com
On Jun 8, 2011, at 6:59 AM, Guenter Roeck <guenter.roeck@ericsson.com>
wrote:
> On Wed, Jun 08, 2011 at 09:18:43AM -0400, Jean Delvare wrote:
>> The development of the ipmisensors driver stalled 5 years ago, the
>> driver isn't usable, so stop pointing the users to it, it only
>> confuses
>> them. See https://bugzilla.novell.com/show_bug.cgi?idU8756 for
>> example.
>>
>> ---
>> I have this patch in openSUSE for 1.5 year, any objection to me
>> getting it upstream for everyone's benefit?
>>
> Makes sense to me. Too bad this driver is not supported, though - I
> would need it ;).
>
> Guenter
>
> _______________________________________________
> lm-sensors mailing list
> lm-sensors@lm-sensors.org
> http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [lm-sensors] [PATCH] Don't point the user to the ipmisensors
2011-06-08 13:18 [lm-sensors] [PATCH] Don't point the user to the ipmisensors driver Jean Delvare
2011-06-08 13:58 ` [lm-sensors] [PATCH] Don't point the user to the ipmisensors Guenter Roeck
2011-06-08 14:27 ` Phil Pokorny
@ 2011-06-08 14:29 ` Aurelien Jarno
2011-06-08 14:32 ` Jean Delvare
2011-07-03 11:59 ` Jean Delvare
4 siblings, 0 replies; 6+ messages in thread
From: Aurelien Jarno @ 2011-06-08 14:29 UTC (permalink / raw)
To: lm-sensors
Hi,
On Wed, Jun 08, 2011 at 03:18:43PM +0200, Jean Delvare wrote:
> The development of the ipmisensors driver stalled 5 years ago, the
> driver isn't usable, so stop pointing the users to it, it only confuses
> them. See https://bugzilla.novell.com/show_bug.cgi?idU8756 for
> example.
I think I never tried this driver, but I trust you on this analysis.
> ---
> I have this patch in openSUSE for 1.5 year, any objection to me
> getting it upstream for everyone's benefit?
Given the above, I think it's a good idea.
> prog/detect/sensors-detect | 9 +++++----
> 1 file changed, 5 insertions(+), 4 deletions(-)
>
> --- lm-sensors.orig/prog/detect/sensors-detect 2011-06-08 14:59:16.000000000 +0200
> +++ lm-sensors/prog/detect/sensors-detect 2011-06-08 15:12:04.000000000 +0200
> @@ -1356,12 +1356,12 @@ use vars qw(@i2c_adapter_names);
> @ipmi_ifs = (
> {
> name => "IPMI BMC KCS",
> - driver => "ipmisensors",
> + driver => "to-be-written", # ipmisensors
> isa_addrs => [0x0ca0],
> isa_detect => sub { ipmi_detect(@_); },
> }, {
> name => "IPMI BMC SMIC",
> - driver => "ipmisensors",
> + driver => "to-be-written", # ipmisensors
> isa_addrs => [0x0ca8],
> isa_detect => sub { ipmi_detect(@_); },
> }
> @@ -6039,6 +6039,7 @@ sub w83781d_isa_detect
> sub ipmi_from_smbios
> {
> my ($version, $if, @ipmi_if);
> + my $ipmi_driver = "to-be-written"; # ipmisensors
>
> return 0 unless check_dmidecode_version();
>
> @@ -6074,13 +6075,13 @@ sub ipmi_from_smbios
> $if->{type}));
> }
> print "Success!\n".
> - " (confidence 8, driver `ipmisensors')\n";
> + " (confidence 8, driver `$ipmi_driver')\n";
> my $new_hash = {
> conf => 8,
> isa_addr => $if->{addr} || 0,
> chipname => $if->{type},
> };
> - add_isa_to_chips_detected("ipmisensors", $new_hash);
> + add_isa_to_chips_detected($ipmi_driver, $new_hash);
> }
>
> return scalar @ipmi_if;
>
>
> --
> Jean Delvare
>
--
Aurelien Jarno GPG: 1024D/F1BCDB73
aurelien@aurel32.net http://www.aurel32.net
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [lm-sensors] [PATCH] Don't point the user to the ipmisensors
2011-06-08 13:18 [lm-sensors] [PATCH] Don't point the user to the ipmisensors driver Jean Delvare
` (2 preceding siblings ...)
2011-06-08 14:29 ` Aurelien Jarno
@ 2011-06-08 14:32 ` Jean Delvare
2011-07-03 11:59 ` Jean Delvare
4 siblings, 0 replies; 6+ messages in thread
From: Jean Delvare @ 2011-06-08 14:32 UTC (permalink / raw)
To: lm-sensors
Yes Phil, bmcsensors was the Linux 2.4 driver, impisensors is the same
driver ported to Linux 2.6. Except that the port never got
completed :( And I don't have the hardware so I can't help.
On Wed, 8 Jun 2011 07:27:04 -0700, Phil Pokorny wrote:
> Is that the same driver as bmcsensors?
>
> --
> Philip Pokorny, RHCE
> Chief Hardware Architect
> PENGUIN COMPUTING, Inc
> www.penguincomputing.com
>
> On Jun 8, 2011, at 6:59 AM, Guenter Roeck <guenter.roeck@ericsson.com>
> wrote:
>
> > On Wed, Jun 08, 2011 at 09:18:43AM -0400, Jean Delvare wrote:
> >> The development of the ipmisensors driver stalled 5 years ago, the
> >> driver isn't usable, so stop pointing the users to it, it only
> >> confuses
> >> them. See https://bugzilla.novell.com/show_bug.cgi?idU8756 for
> >> example.
> >>
> >> ---
> >> I have this patch in openSUSE for 1.5 year, any objection to me
> >> getting it upstream for everyone's benefit?
> >>
> > Makes sense to me. Too bad this driver is not supported, though - I
> > would need it ;).
> >
> > Guenter
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [lm-sensors] [PATCH] Don't point the user to the ipmisensors
2011-06-08 13:18 [lm-sensors] [PATCH] Don't point the user to the ipmisensors driver Jean Delvare
` (3 preceding siblings ...)
2011-06-08 14:32 ` Jean Delvare
@ 2011-07-03 11:59 ` Jean Delvare
4 siblings, 0 replies; 6+ messages in thread
From: Jean Delvare @ 2011-07-03 11:59 UTC (permalink / raw)
To: lm-sensors
On Wed, 8 Jun 2011 16:29:06 +0200, Aurelien Jarno wrote:
> On Wed, Jun 08, 2011 at 03:18:43PM +0200, Jean Delvare wrote:
> > The development of the ipmisensors driver stalled 5 years ago, the
> > driver isn't usable, so stop pointing the users to it, it only confuses
> > them. See https://bugzilla.novell.com/show_bug.cgi?idU8756 for
> > example.
>
> I think I never tried this driver, but I trust you on this analysis.
>
> > ---
> > I have this patch in openSUSE for 1.5 year, any objection to me
> > getting it upstream for everyone's benefit?
>
> Given the above, I think it's a good idea.
Applied.
--
Jean Delvare
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
^ permalink raw reply [flat|nested] 6+ messages in thread