Re: [PATCH 1/2] video: s3c-fb: Delete an error message for a failed memory allocation in s3c_fb_prob

From: "Jingoo Han" <jingoohan1@gmail.com>
To: 'SF Markus Elfring' <elfring@users.sourceforge.net>,
	linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org,
	'Bartlomiej Zolnierkiewicz' <b.zolnierkie@samsung.com>
Cc: kernel-janitors@vger.kernel.org, 'LKML' <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/2] video: s3c-fb: Delete an error message for a failed memory allocation in s3c_fb_prob
Date: Mon, 27 Nov 2017 18:06:30 +0000	[thread overview]
Message-ID: <000201d367aa$74511b10$5cf35130$@gmail.com> (raw)
In-Reply-To: <734da0dc-cc64-50f5-7816-bf3f5dd2e9a4@users.sourceforge.net>

On Sunday, November 26, 2017 9:17 AM, SF Markus Elfring wrote:
> 
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Sun, 26 Nov 2017 15:00:16 +0100
> 
> Omit an extra message for a memory allocation failure in this function.
> 
> This issue was detected by using the Coccinelle software.
> 
> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>

Acked-by: Jingoo Han <jingoohan1@gmail.com>

Best regards,
Jingoo Han

> ---
>  drivers/video/fbdev/s3c-fb.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/video/fbdev/s3c-fb.c b/drivers/video/fbdev/s3c-fb.c
> index 5f4f696c2ecf..0914c973cbd9 100644
> --- a/drivers/video/fbdev/s3c-fb.c
> +++ b/drivers/video/fbdev/s3c-fb.c
> @@ -1384,10 +1384,8 @@ static int s3c_fb_probe(struct platform_device
> *pdev)
>  	}
> 
>  	sfb = devm_kzalloc(dev, sizeof(struct s3c_fb), GFP_KERNEL);
> -	if (!sfb) {
> -		dev_err(dev, "no memory for framebuffers\n");
> +	if (!sfb)
>  		return -ENOMEM;
> -	}
> 
>  	dev_dbg(dev, "allocate new framebuffer %p\n", sfb);
> 
> --
> 2.15.0