From: "Steve Wise" <swise-7bPotxP6k4+P2YhJcF5u+vpXobYPEAuW@public.gmane.org>
To: 'Nicholas Krause' <xerofoify-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org,
sean.hefty-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org,
hal.rosenstock-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: RE: [PATCH] infiniband:cxgb4:Fix incorrect return statement in the function c4iw_reject_cr
Date: Thu, 27 Aug 2015 09:14:47 -0500 [thread overview]
Message-ID: <000801d0e0d2$bb99b0b0$32cd1210$@opengridcomputing.com> (raw)
In-Reply-To: <1440634906-16103-1-git-send-email-xerofoify-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> -----Original Message-----
> From: Nicholas Krause [mailto:xerofoify-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org]
> Sent: Wednesday, August 26, 2015 7:22 PM
> To: swise-ut6Up61K2wZBDgjK7y7TUQ@public.gmane.org
> Cc: dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org; sean.hefty-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org; hal.rosenstock-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org; linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org; linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> Subject: [PATCH] infiniband:cxgb4:Fix incorrect return statement in the function c4iw_reject_cr
>
> This fixes the incorrect return statement in the function
> c4iw_reject_cr that returns the value zero directly to instead
> return the variable err as this function can fail when called
> and if so we will incorrectly return success rather then the
> correct status of a failed call to the caller of this particular
> function.
>
> Signed-off-by: Nicholas Krause <xerofoify-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> ---
NAK.
The return code for these cpl handlers indicates if process_work() or other callers needs to free the skb. They are supposed to
return 0.
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: "Steve Wise" <swise@opengridcomputing.com>
To: "'Nicholas Krause'" <xerofoify@gmail.com>
Cc: <dledford@redhat.com>, <sean.hefty@intel.com>,
<hal.rosenstock@gmail.com>, <linux-rdma@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: RE: [PATCH] infiniband:cxgb4:Fix incorrect return statement in the function c4iw_reject_cr
Date: Thu, 27 Aug 2015 09:14:47 -0500 [thread overview]
Message-ID: <000801d0e0d2$bb99b0b0$32cd1210$@opengridcomputing.com> (raw)
In-Reply-To: <1440634906-16103-1-git-send-email-xerofoify@gmail.com>
> -----Original Message-----
> From: Nicholas Krause [mailto:xerofoify@gmail.com]
> Sent: Wednesday, August 26, 2015 7:22 PM
> To: swise@chelsio.com
> Cc: dledford@redhat.com; sean.hefty@intel.com; hal.rosenstock@gmail.com; linux-rdma@vger.kernel.org; linux-kernel@vger.kernel.org
> Subject: [PATCH] infiniband:cxgb4:Fix incorrect return statement in the function c4iw_reject_cr
>
> This fixes the incorrect return statement in the function
> c4iw_reject_cr that returns the value zero directly to instead
> return the variable err as this function can fail when called
> and if so we will incorrectly return success rather then the
> correct status of a failed call to the caller of this particular
> function.
>
> Signed-off-by: Nicholas Krause <xerofoify@gmail.com>
> ---
NAK.
The return code for these cpl handlers indicates if process_work() or other callers needs to free the skb. They are supposed to
return 0.
next parent reply other threads:[~2015-08-27 14:14 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1440634906-16103-1-git-send-email-xerofoify@gmail.com>
[not found] ` <1440634906-16103-1-git-send-email-xerofoify-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2015-08-27 14:14 ` Steve Wise [this message]
2015-08-27 14:14 ` [PATCH] infiniband:cxgb4:Fix incorrect return statement in the function c4iw_reject_cr Steve Wise
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='000801d0e0d2$bb99b0b0$32cd1210$@opengridcomputing.com' \
--to=swise-7bpotxp6k4+p2yhjcf5u+vpxobypeauw@public.gmane.org \
--cc=dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=hal.rosenstock-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=sean.hefty-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
--cc=xerofoify-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.