* RE: [PATCH] infiniband:cxgb4:Fix incorrect return statement in the function c4iw_reject_cr
[not found] <1440634906-16103-1-git-send-email-xerofoify@gmail.com>
@ 2015-08-27 14:14 ` Steve Wise
0 siblings, 0 replies; 2+ messages in thread
From: Steve Wise @ 2015-08-27 14:14 UTC (permalink / raw)
To: 'Nicholas Krause'
Cc: dledford-H+wXaHxf7aLQT0dZR+AlfA,
sean.hefty-ral2JQCrhuEAvxtiuMwx3w,
hal.rosenstock-Re5JQEeQqe8AvxtiuMwx3w,
linux-rdma-u79uwXL29TY76Z2rM5mHXA,
linux-kernel-u79uwXL29TY76Z2rM5mHXA
> -----Original Message-----
> From: Nicholas Krause [mailto:xerofoify-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org]
> Sent: Wednesday, August 26, 2015 7:22 PM
> To: swise-ut6Up61K2wZBDgjK7y7TUQ@public.gmane.org
> Cc: dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org; sean.hefty-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org; hal.rosenstock-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org; linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org; linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> Subject: [PATCH] infiniband:cxgb4:Fix incorrect return statement in the function c4iw_reject_cr
>
> This fixes the incorrect return statement in the function
> c4iw_reject_cr that returns the value zero directly to instead
> return the variable err as this function can fail when called
> and if so we will incorrectly return success rather then the
> correct status of a failed call to the caller of this particular
> function.
>
> Signed-off-by: Nicholas Krause <xerofoify-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> ---
NAK.
The return code for these cpl handlers indicates if process_work() or other callers needs to free the skb. They are supposed to
return 0.
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 2+ messages in thread* RE: [PATCH] infiniband:cxgb4:Fix incorrect return statement in the function c4iw_reject_cr
@ 2015-08-27 14:14 ` Steve Wise
0 siblings, 0 replies; 2+ messages in thread
From: Steve Wise @ 2015-08-27 14:14 UTC (permalink / raw)
To: 'Nicholas Krause'
Cc: dledford, sean.hefty, hal.rosenstock, linux-rdma, linux-kernel
> -----Original Message-----
> From: Nicholas Krause [mailto:xerofoify@gmail.com]
> Sent: Wednesday, August 26, 2015 7:22 PM
> To: swise@chelsio.com
> Cc: dledford@redhat.com; sean.hefty@intel.com; hal.rosenstock@gmail.com; linux-rdma@vger.kernel.org; linux-kernel@vger.kernel.org
> Subject: [PATCH] infiniband:cxgb4:Fix incorrect return statement in the function c4iw_reject_cr
>
> This fixes the incorrect return statement in the function
> c4iw_reject_cr that returns the value zero directly to instead
> return the variable err as this function can fail when called
> and if so we will incorrectly return success rather then the
> correct status of a failed call to the caller of this particular
> function.
>
> Signed-off-by: Nicholas Krause <xerofoify@gmail.com>
> ---
NAK.
The return code for these cpl handlers indicates if process_work() or other callers needs to free the skb. They are supposed to
return 0.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-08-27 14:14 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1440634906-16103-1-git-send-email-xerofoify@gmail.com>
[not found] ` <1440634906-16103-1-git-send-email-xerofoify-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2015-08-27 14:14 ` [PATCH] infiniband:cxgb4:Fix incorrect return statement in the function c4iw_reject_cr Steve Wise
2015-08-27 14:14 ` Steve Wise
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.