Cannot find the submit button after "+2"

Cannot find the submit button after "+2"

[Yong Li]

[-- Attachment #1: Type: text/plain, Size: 280 bytes --]

Hi Brad,

 

On the below code review I submitted, there are "+2" already, but I cannot
find the submit button on the web page,

 

Do I need to apply for other permissions or groups? 

 

https://gerrit.openbmc-project.xyz/#/c/openbmc/intel-ipmi-oem/+/17234/,

 

Thanks,

Yong


[-- Attachment #2: Type: text/html, Size: 2439 bytes --]

Re: Cannot find the submit button after "+2"

[Brad Bishop]

On Thu, May 16, 2019 at 09:46:50AM +0800, Yong Li wrote:
>Hi Brad,
>
>
>
>On the below code review I submitted, there are "+2" already, but I cannot
>find the submit button on the web page,
>
>
>
>Do I need to apply for other permissions or groups?
>
>
>
>https://gerrit.openbmc-project.xyz/#/c/openbmc/intel-ipmi-oem/+/17234/,
>
>
>
>Thanks,
>
>Yong
>

Hi Yong

Whether or not the patch author clicks submit or the maintainer clicks
submit is a matter of maintainer preference.  I prefer to oversee the
merging of changes into the repositories I maintain.  I know that other
maintainers perfer to approve the change but delegate the actual
submission to the patch author (and that is fine).

I'm working on assigning the owner permission to refs/* to the current
repository maintainer for each openbmc repository.  This would allow
each repository maintainer to enable this (or not) as they see fit.

Thanks - brad

RE: Cannot find the submit button after "+2"

[Yong Li]

Thanks Brad! Will contact the maintainers to merge my changes

Thanks,
Yong
-----Original Message-----
From: openbmc <openbmc-bounces+yong.b.li=linux.intel.com@lists.ozlabs.org>
On Behalf Of Brad Bishop
Sent: Monday, May 20, 2019 9:32 PM
To: Yong Li <yong.b.li@linux.intel.com>
Cc: 'OpenBMC Maillist' <openbmc@lists.ozlabs.org>; Li, Yong B
<yong.b.li@intel.com>
Subject: Re: Cannot find the submit button after "+2"

On Thu, May 16, 2019 at 09:46:50AM +0800, Yong Li wrote:
>Hi Brad,
>
>
>
>On the below code review I submitted, there are "+2" already, but I 
>cannot find the submit button on the web page,
>
>
>
>Do I need to apply for other permissions or groups?
>
>
>
>https://gerrit.openbmc-project.xyz/#/c/openbmc/intel-ipmi-oem/+/17234/,
>
>
>
>Thanks,
>
>Yong
>

Hi Yong

Whether or not the patch author clicks submit or the maintainer clicks
submit is a matter of maintainer preference.  I prefer to oversee the
merging of changes into the repositories I maintain.  I know that other
maintainers perfer to approve the change but delegate the actual submission
to the patch author (and that is fine).

I'm working on assigning the owner permission to refs/* to the current
repository maintainer for each openbmc repository.  This would allow each
repository maintainer to enable this (or not) as they see fit.

Thanks - brad