All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Sricharan" <sricharan-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
To: 'Tomasz Figa' <tfiga-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
Cc: 'Will Deacon' <will.deacon-5wv7dgnIgG8@public.gmane.org>,
	"'open list:IOMMU DRIVERS'"
	<iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org>,
	'Laurent Pinchart'
	<laurent.pinchart-ryLnwIuWjnjg/C1BVhZhaw@public.gmane.org>,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Subject: RE: [PATCH 6/8] drivers: platform: Remove call to of_dma_(con/decon)figure_ops
Date: Fri, 12 Aug 2016 21:12:07 +0530	[thread overview]
Message-ID: <000b01d1f4b0$180b7300$48225900$@codeaurora.org> (raw)
In-Reply-To: <CAAFQd5DZ0ZpW2eEm8Bvh8=di6kOgUG4bGY_iTNbVBHsj0KPmeg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>

Hi Tomaz,

>> The dma_ops gets configured for the device generically during
>> the device_attach call. So remove it from the platform bus probe.
>> Similarly remove the deconfigure calls as well, since it is
>> now called form the device_detach path.
>
>Doesn't this patch need to be squashed with previous one to avoid
>breaking things in between by having the of_dma_configure_ops() called
>two times?
>
  okay, i did it this way, for the sake of review. But ya will squash
  it for the next post.

Regards,
 Sricharan

WARNING: multiple messages have this Message-ID (diff)
From: sricharan@codeaurora.org (Sricharan)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 6/8] drivers: platform: Remove call to of_dma_(con/decon)figure_ops
Date: Fri, 12 Aug 2016 21:12:07 +0530	[thread overview]
Message-ID: <000b01d1f4b0$180b7300$48225900$@codeaurora.org> (raw)
In-Reply-To: <CAAFQd5DZ0ZpW2eEm8Bvh8=di6kOgUG4bGY_iTNbVBHsj0KPmeg@mail.gmail.com>

Hi Tomaz,

>> The dma_ops gets configured for the device generically during
>> the device_attach call. So remove it from the platform bus probe.
>> Similarly remove the deconfigure calls as well, since it is
>> now called form the device_detach path.
>
>Doesn't this patch need to be squashed with previous one to avoid
>breaking things in between by having the of_dma_configure_ops() called
>two times?
>
  okay, i did it this way, for the sake of review. But ya will squash
  it for the next post.

Regards,
 Sricharan

  parent reply	other threads:[~2016-08-12 15:42 UTC|newest]

Thread overview: 52+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-08 22:49 [PATCH 0/8] IOMMU Probe deferral support Sricharan R
2016-08-08 22:49 ` Sricharan R
     [not found] ` <1470696550-3416-1-git-send-email-sricharan-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2016-08-08 22:49   ` [PATCH 1/8] arm: dma-mapping: Don't override dma_ops in arch_setup_dma_ops() Sricharan R
2016-08-08 22:49     ` Sricharan R
     [not found]     ` <1470696550-3416-2-git-send-email-sricharan-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2016-09-02  8:16       ` Marek Szyprowski
2016-09-02  8:16         ` Marek Szyprowski
     [not found]         ` <16c9743e-e531-25aa-76f1-8746a6b8ef11-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2016-09-07  6:24           ` Sricharan
2016-09-07  6:24             ` Sricharan
2016-08-08 22:49   ` [PATCH 2/8] of: dma: Move range size workaround to of_dma_get_range() Sricharan R
2016-08-08 22:49     ` Sricharan R
2016-08-08 22:49   ` [PATCH 3/8] of: dma: Make of_dma_deconfigure() public Sricharan R
2016-08-08 22:49     ` Sricharan R
2016-08-08 22:49   ` [PATCH 4/8] of: dma: Split of_configure_dma() into mask and ops configuration Sricharan R
2016-08-08 22:49     ` Sricharan R
     [not found]     ` <1470696550-3416-5-git-send-email-sricharan-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2016-08-12  7:31       ` Tomasz Figa
2016-08-12  7:31         ` Tomasz Figa
     [not found]         ` <CAAFQd5BkpHrF=2=UXFA2mPKe0VQAD3J_XSNrZYHP0br5hw=Gsw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-08-12 15:18           ` Laurent Pinchart
2016-08-12 15:18             ` Laurent Pinchart
2016-08-12 15:45             ` Sricharan
2016-08-12 15:45               ` Sricharan
2016-09-09  6:53       ` Magnus Damm
2016-09-09  6:53         ` Magnus Damm
     [not found]         ` <CANqRtoRVRrP9dc3qc-xSE_Wct2HPznzzi1hdrHeC8h2gA=JcKg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-09-09  9:48           ` Sricharan
2016-09-09  9:48             ` Sricharan
2016-08-08 22:49   ` [PATCH 5/8] drivers: platform: Configure dma operations at probe time Sricharan R
2016-08-08 22:49     ` Sricharan R
     [not found]     ` <1470696550-3416-6-git-send-email-sricharan-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2016-08-16  9:25       ` Laurent Pinchart
2016-08-16  9:25         ` Laurent Pinchart
2016-08-16 12:28         ` Sricharan
2016-08-16 12:28           ` Sricharan
2016-08-08 22:49   ` [PATCH 6/8] drivers: platform: Remove call to of_dma_(con/decon)figure_ops Sricharan R
2016-08-08 22:49     ` Sricharan R
     [not found]     ` <1470696550-3416-7-git-send-email-sricharan-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2016-08-12  7:33       ` Tomasz Figa
2016-08-12  7:33         ` Tomasz Figa
     [not found]         ` <CAAFQd5DZ0ZpW2eEm8Bvh8=di6kOgUG4bGY_iTNbVBHsj0KPmeg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-08-12 15:42           ` Sricharan [this message]
2016-08-12 15:42             ` Sricharan
2016-08-08 22:49   ` [PATCH 7/8] iommu: of: Handle IOMMU lookup failure with deferred probing or error Sricharan R
2016-08-08 22:49     ` Sricharan R
     [not found]     ` <1470696550-3416-8-git-send-email-sricharan-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2016-08-12  7:46       ` Tomasz Figa
2016-08-12  7:46         ` Tomasz Figa
     [not found]         ` <CAAFQd5C8BuOCc5ySw_3tVELDG4S+r_5VyDvOPnBBuVr-6CBfxg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-08-12 15:40           ` Sricharan
2016-08-12 15:40             ` Sricharan
2016-09-02  8:09             ` Marek Szyprowski
2016-09-02  8:09               ` Marek Szyprowski
     [not found]               ` <1c5dde1d-1ffb-d045-c090-032b9f1c7de2-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2016-09-07  6:16                 ` Sricharan
2016-09-07  6:16                   ` Sricharan
2016-09-02 12:52       ` Marek Szyprowski
2016-09-02 12:52         ` Marek Szyprowski
     [not found]         ` <17b1ff0a-6619-cd45-28cd-70bf79bdcc47-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2016-09-07  6:29           ` Sricharan
2016-09-07  6:29             ` Sricharan
2016-08-08 22:49   ` [PATCH 8/8] drivers: iommu: arm-smmu: Set iommu_ops in probe Sricharan R
2016-08-08 22:49     ` Sricharan R

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='000b01d1f4b0$180b7300$48225900$@codeaurora.org' \
    --to=sricharan-sgv2jx0feol9jmxxk+q4oq@public.gmane.org \
    --cc=iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org \
    --cc=laurent.pinchart-ryLnwIuWjnjg/C1BVhZhaw@public.gmane.org \
    --cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
    --cc=tfiga-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org \
    --cc=will.deacon-5wv7dgnIgG8@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.