All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Or Sagi" <ors@tutis.com>
To: "'Dor Laor'" <dor.laor@qumranet.com>,
	"'Alan Cox'" <alan@lxorguk.ukuu.org.uk>
Cc: <kvm-devel@lists.sourceforge.net>, <linux-kernel@vger.kernel.org>
Subject: RE: [kvm-devel] [RFC] Deferred interrupt handling.
Date: Thu, 19 Jul 2007 01:23:09 +0300	[thread overview]
Message-ID: <002601c7c98a$49ab9580$dd02c080$@com> (raw)
In-Reply-To: <64F9B87B6B770947A9F8391472E032160CC16F3C@ehost011-8.exch011.intermedia.net>


> Hope it should work like the following [Please correct me if I'm
> wrong]:
> - Make the device the last irqaction in the list
> - Our dummy handler will always return IRQ_HANDLED in case any other
> previous
>   irqaction did not return such. It will also issue the timer and mask
> the irq in this case.
>   The line is temporarily jammed but not disabled - note_interrupt()
> will not consider
>   our irq unhandled and won't disable it.
>   btw, if I'm not mistaken only after bad 99900/100000 the irq is
> disabled.
> - If the timer pops before the guest acks the irq, the timer handler
> will
>   ack the irq and unmask it. The timer's job is only to prevent
> deadlocks.
> 
> Maybe it's better to code it first then send RFC.

Definitely. We've already agreed that it's correct for the (rare, 
unfortunately) non shared scenario. Let's see how much do we have to bend 
reality to fit once it's in code form.

-- Ors.



WARNING: multiple messages have this Message-ID (diff)
From: "Or Sagi" <ors-DHAoeUZcRjAAvxtiuMwx3w@public.gmane.org>
To: "'Dor Laor'" <dor.laor-atKUWr5tajBWk0Htik3J/w@public.gmane.org>,
	"'Alan Cox'"
	<alan-qBU/x9rampVanCEyBjwyrvXRex20P6io@public.gmane.org>
Cc: kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [RFC] Deferred interrupt handling.
Date: Thu, 19 Jul 2007 01:23:09 +0300	[thread overview]
Message-ID: <002601c7c98a$49ab9580$dd02c080$@com> (raw)
In-Reply-To: <64F9B87B6B770947A9F8391472E032160CC16F3C-yEcIvxbTEBqsx+V+t5oei8rau4O3wl8o3fe8/T/H7NteoWH0uzbU5w@public.gmane.org>


> Hope it should work like the following [Please correct me if I'm
> wrong]:
> - Make the device the last irqaction in the list
> - Our dummy handler will always return IRQ_HANDLED in case any other
> previous
>   irqaction did not return such. It will also issue the timer and mask
> the irq in this case.
>   The line is temporarily jammed but not disabled - note_interrupt()
> will not consider
>   our irq unhandled and won't disable it.
>   btw, if I'm not mistaken only after bad 99900/100000 the irq is
> disabled.
> - If the timer pops before the guest acks the irq, the timer handler
> will
>   ack the irq and unmask it. The timer's job is only to prevent
> deadlocks.
> 
> Maybe it's better to code it first then send RFC.

Definitely. We've already agreed that it's correct for the (rare, 
unfortunately) non shared scenario. Let's see how much do we have to bend 
reality to fit once it's in code form.

-- Ors.



-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/

  parent reply	other threads:[~2007-07-18 22:24 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-07-18  9:53 [RFC] Deferred interrupt handling Or Sagi
2007-07-18  9:53 ` Or Sagi
2007-07-18 11:30 ` Alan Cox
2007-07-18 11:30   ` Alan Cox
2007-07-18 16:36   ` [kvm-devel] " Dor Laor
2007-07-18 16:36     ` Dor Laor
2007-07-18 16:47     ` [kvm-devel] " Alan Cox
2007-07-18 16:47       ` Alan Cox
2007-07-18 16:46       ` [kvm-devel] " Avi Kivity
2007-07-18 16:46         ` Avi Kivity
2007-07-18 16:57         ` [kvm-devel] " Alan Cox
2007-07-18 16:57           ` Alan Cox
2007-07-18 16:57           ` [kvm-devel] " Avi Kivity
2007-07-18 16:57             ` Avi Kivity
2007-07-18 17:14             ` [kvm-devel] " Alan Cox
2007-07-18 17:14               ` Alan Cox
2007-07-18 17:09         ` [kvm-devel] " Dor Laor
2007-07-18 17:09           ` Dor Laor
2007-07-18 17:33           ` [kvm-devel] " Alan Cox
2007-07-18 17:33             ` Alan Cox
2007-07-18 21:29             ` [kvm-devel] " Dor Laor
2007-07-18 21:29               ` Dor Laor
2007-07-18 21:46               ` [kvm-devel] " Alan Cox
2007-07-18 21:46                 ` Alan Cox
2007-07-25 14:18                 ` [kvm-devel] " Pavel Machek
2007-07-25 14:18                   ` Pavel Machek
2007-07-18 22:23               ` Or Sagi [this message]
2007-07-18 22:23                 ` Or Sagi
2007-07-18 19:14         ` [kvm-devel] " Lennart Sorensen
2007-07-18 19:14           ` Lennart Sorensen
2007-07-19  9:23           ` [kvm-devel] " Avi Kivity
2007-07-19  9:23             ` Avi Kivity
2007-07-19 13:17             ` [kvm-devel] " Lennart Sorensen
2007-07-19 13:17               ` Lennart Sorensen
2007-07-19 13:38               ` [kvm-devel] " Avi Kivity
2007-07-19 13:38                 ` Avi Kivity
2007-07-19 16:23                 ` [kvm-devel] " Lennart Sorensen
2007-07-19 16:23                   ` Lennart Sorensen
2007-07-18 15:57 ` Lennart Sorensen
2007-07-18 15:57   ` Lennart Sorensen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='002601c7c98a$49ab9580$dd02c080$@com' \
    --to=ors@tutis.com \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=dor.laor@qumranet.com \
    --cc=kvm-devel@lists.sourceforge.net \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.