From: swise@opengridcomputing.com (Steve Wise)
Subject: [PATCH RFC v2 3/3] nvme-rdma: use rdma_reject_msg() to log connection rejects
Date: Sat, 22 Oct 2016 11:12:11 -0500 [thread overview]
Message-ID: <005601d22c7f$0bd36dc0$237a4940$@opengridcomputing.com> (raw)
In-Reply-To: <20161021122318.GB17325@lst.de>
>
> On Thu, Oct 20, 2016@03:40:29PM -0700, Steve Wise wrote:
> > @@ -1237,18 +1237,22 @@ out_destroy_queue_ib:
> > static int nvme_rdma_conn_rejected(struct nvme_rdma_queue *queue,
> > struct rdma_cm_event *ev)
> > {
> > + struct rdma_cm_id *cm_id = queue->cm_id;
> > + int rdma_status = ev->status;
> > + short nvme_status = -1;
> > +
> > + if (rdma_consumer_reject(cm_id, rdma_status) &&
> > + ev->param.conn.private_data_len) {
> > struct nvme_rdma_cm_rej *rej =
> > (struct nvme_rdma_cm_rej *)ev-
> >param.conn.private_data;
>
> Given the nasty casting issues in the current RDMA/CM API maybe we should
> actually expand the scope of the rdma_consumer_reject helper to include
> the above check, e.g. check that there is a private data len and then
> return a pointer to the private data?
An application could reject and not provide private data, so I think we need
3 helpers (so far):
rdma_reject_msg() - protocol reject reason string
rdma_is_consumer_reject() - true if the peer consumer/ulp rejected
rdma_consumer_reject_data() - ptr to any private data
Sound good?
WARNING: multiple messages have this Message-ID (diff)
From: "Steve Wise" <swise-7bPotxP6k4+P2YhJcF5u+vpXobYPEAuW@public.gmane.org>
To: 'Christoph Hellwig' <hch-jcswGhMUV9g@public.gmane.org>
Cc: dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org,
sean.hefty-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org,
linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
bart.vanassche-XdAiOPVOjttBDgjK7y7TUQ@public.gmane.org,
linux-nvme-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
sagig-NQWnxTmZq1alnMjI0IkVqw@public.gmane.org,
axboe-b10kYP2dOMg@public.gmane.org
Subject: RE: [PATCH RFC v2 3/3] nvme-rdma: use rdma_reject_msg() to log connection rejects
Date: Sat, 22 Oct 2016 11:12:11 -0500 [thread overview]
Message-ID: <005601d22c7f$0bd36dc0$237a4940$@opengridcomputing.com> (raw)
In-Reply-To: <20161021122318.GB17325-jcswGhMUV9g@public.gmane.org>
>
> On Thu, Oct 20, 2016 at 03:40:29PM -0700, Steve Wise wrote:
> > @@ -1237,18 +1237,22 @@ out_destroy_queue_ib:
> > static int nvme_rdma_conn_rejected(struct nvme_rdma_queue *queue,
> > struct rdma_cm_event *ev)
> > {
> > + struct rdma_cm_id *cm_id = queue->cm_id;
> > + int rdma_status = ev->status;
> > + short nvme_status = -1;
> > +
> > + if (rdma_consumer_reject(cm_id, rdma_status) &&
> > + ev->param.conn.private_data_len) {
> > struct nvme_rdma_cm_rej *rej =
> > (struct nvme_rdma_cm_rej *)ev-
> >param.conn.private_data;
>
> Given the nasty casting issues in the current RDMA/CM API maybe we should
> actually expand the scope of the rdma_consumer_reject helper to include
> the above check, e.g. check that there is a private data len and then
> return a pointer to the private data?
An application could reject and not provide private data, so I think we need
3 helpers (so far):
rdma_reject_msg() - protocol reject reason string
rdma_is_consumer_reject() - true if the peer consumer/ulp rejected
rdma_consumer_reject_data() - ptr to any private data
Sound good?
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2016-10-22 16:12 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-20 22:40 [PATCH RFC v2 0/3] connect reject event helpers Steve Wise
2016-10-20 22:40 ` Steve Wise
2016-10-20 22:40 ` [PATCH RFC v2 1/3] rdma_cm: add rdma_reject_msg() helper function Steve Wise
2016-10-20 22:40 ` Steve Wise
2016-10-21 12:12 ` Christoph Hellwig
2016-10-21 12:12 ` Christoph Hellwig
2016-10-21 14:07 ` Steve Wise
2016-10-21 14:07 ` Steve Wise
2016-10-21 21:43 ` Sagi Grimberg
2016-10-21 21:43 ` Sagi Grimberg
2016-10-21 21:51 ` Sagi Grimberg
2016-10-21 21:51 ` Sagi Grimberg
2016-10-20 22:40 ` [PATCH RFC v2 2/3] rdma_cm: add rdma_consumer_reject() " Steve Wise
2016-10-20 22:40 ` Steve Wise
2016-10-21 12:14 ` Christoph Hellwig
2016-10-21 12:14 ` Christoph Hellwig
2016-10-21 14:09 ` Steve Wise
2016-10-21 14:09 ` Steve Wise
2016-10-21 15:50 ` Parav Pandit
2016-10-21 15:50 ` Parav Pandit
2016-10-21 21:45 ` Sagi Grimberg
2016-10-21 21:45 ` Sagi Grimberg
2016-10-22 15:57 ` Steve Wise
2016-10-22 15:57 ` Steve Wise
2016-10-20 22:40 ` [PATCH RFC v2 3/3] nvme-rdma: use rdma_reject_msg() to log connection rejects Steve Wise
2016-10-20 22:40 ` Steve Wise
2016-10-21 12:23 ` Christoph Hellwig
2016-10-21 12:23 ` Christoph Hellwig
2016-10-21 21:48 ` Sagi Grimberg
2016-10-21 21:48 ` Sagi Grimberg
2016-10-22 16:12 ` Steve Wise [this message]
2016-10-22 16:12 ` Steve Wise
[not found] ` <005701d22c7f$0c883ed0$2598bc70$@opengridcomputing.com>
2016-10-24 14:57 ` Steve Wise
2016-10-24 14:57 ` Steve Wise
2016-10-24 15:09 ` 'Christoph Hellwig'
2016-10-24 15:09 ` 'Christoph Hellwig'
2016-10-21 21:53 ` [PATCH RFC v2 0/3] connect reject event helpers Sagi Grimberg
2016-10-21 21:53 ` Sagi Grimberg
2016-10-21 21:58 ` Steve Wise
2016-10-21 21:58 ` Steve Wise
[not found] ` <001701d22be6$4854b8b0$d8fe2a10$@opengridcomputing.com>
2016-10-24 17:44 ` Steve Wise
2016-10-24 17:44 ` Steve Wise
2016-10-24 17:52 ` Chuck Lever
2016-10-24 17:52 ` Chuck Lever
2016-10-24 17:57 ` Steve Wise
2016-10-24 17:57 ` Steve Wise
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='005601d22c7f$0bd36dc0$237a4940$@opengridcomputing.com' \
--to=swise@opengridcomputing.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.