From: swise@opengridcomputing.com (Steve Wise)
Subject: [PATCH RFC v2 2/3] rdma_cm: add rdma_consumer_reject() helper function
Date: Sat, 22 Oct 2016 10:57:28 -0500 [thread overview]
Message-ID: <004501d22c7c$fd3e6fa0$f7bb4ee0$@opengridcomputing.com> (raw)
In-Reply-To: <20161021121428.GB17028@lst.de>
> > --- a/drivers/infiniband/core/cma.c
> > +++ b/drivers/infiniband/core/cma.c
> > @@ -114,6 +114,19 @@ const char *__attribute_const__
> rdma_reject_msg(struct rdma_cm_id *id,
> > }
> > EXPORT_SYMBOL(rdma_reject_msg);
> >
> > +bool rdma_consumer_reject(struct rdma_cm_id *id, int reason)
> > +{
> > + if (rdma_ib_or_roce(id->device, id->port_num))
> > + return ib_consumer_reject(reason);
> > +
> > + if (rdma_protocol_iwarp(id->device, id->port_num))
> > + return iw_consumer_reject(reason);
> > +
> > + /* FIXME should we WARN_ONCE() here? */
> > + return false;
>
> Yes. Also I'd just inline the ib_consumer_reject and iw_consumer_reject
> helpers here.
>
Why is that preferred vs the static inline functions in ib_cm.h and iw_cm.h?
WARNING: multiple messages have this Message-ID (diff)
From: "Steve Wise" <swise-7bPotxP6k4+P2YhJcF5u+vpXobYPEAuW@public.gmane.org>
To: 'Christoph Hellwig' <hch-jcswGhMUV9g@public.gmane.org>
Cc: dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org,
sean.hefty-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org,
linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
bart.vanassche-XdAiOPVOjttBDgjK7y7TUQ@public.gmane.org,
linux-nvme-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
sagig-NQWnxTmZq1alnMjI0IkVqw@public.gmane.org,
axboe-b10kYP2dOMg@public.gmane.org
Subject: RE: [PATCH RFC v2 2/3] rdma_cm: add rdma_consumer_reject() helper function
Date: Sat, 22 Oct 2016 10:57:28 -0500 [thread overview]
Message-ID: <004501d22c7c$fd3e6fa0$f7bb4ee0$@opengridcomputing.com> (raw)
In-Reply-To: <20161021121428.GB17028-jcswGhMUV9g@public.gmane.org>
> > --- a/drivers/infiniband/core/cma.c
> > +++ b/drivers/infiniband/core/cma.c
> > @@ -114,6 +114,19 @@ const char *__attribute_const__
> rdma_reject_msg(struct rdma_cm_id *id,
> > }
> > EXPORT_SYMBOL(rdma_reject_msg);
> >
> > +bool rdma_consumer_reject(struct rdma_cm_id *id, int reason)
> > +{
> > + if (rdma_ib_or_roce(id->device, id->port_num))
> > + return ib_consumer_reject(reason);
> > +
> > + if (rdma_protocol_iwarp(id->device, id->port_num))
> > + return iw_consumer_reject(reason);
> > +
> > + /* FIXME should we WARN_ONCE() here? */
> > + return false;
>
> Yes. Also I'd just inline the ib_consumer_reject and iw_consumer_reject
> helpers here.
>
Why is that preferred vs the static inline functions in ib_cm.h and iw_cm.h?
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2016-10-22 15:57 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-20 22:40 [PATCH RFC v2 0/3] connect reject event helpers Steve Wise
2016-10-20 22:40 ` Steve Wise
2016-10-20 22:40 ` [PATCH RFC v2 1/3] rdma_cm: add rdma_reject_msg() helper function Steve Wise
2016-10-20 22:40 ` Steve Wise
2016-10-21 12:12 ` Christoph Hellwig
2016-10-21 12:12 ` Christoph Hellwig
2016-10-21 14:07 ` Steve Wise
2016-10-21 14:07 ` Steve Wise
2016-10-21 21:43 ` Sagi Grimberg
2016-10-21 21:43 ` Sagi Grimberg
2016-10-21 21:51 ` Sagi Grimberg
2016-10-21 21:51 ` Sagi Grimberg
2016-10-20 22:40 ` [PATCH RFC v2 2/3] rdma_cm: add rdma_consumer_reject() " Steve Wise
2016-10-20 22:40 ` Steve Wise
2016-10-21 12:14 ` Christoph Hellwig
2016-10-21 12:14 ` Christoph Hellwig
2016-10-21 14:09 ` Steve Wise
2016-10-21 14:09 ` Steve Wise
2016-10-21 15:50 ` Parav Pandit
2016-10-21 15:50 ` Parav Pandit
2016-10-21 21:45 ` Sagi Grimberg
2016-10-21 21:45 ` Sagi Grimberg
2016-10-22 15:57 ` Steve Wise [this message]
2016-10-22 15:57 ` Steve Wise
2016-10-20 22:40 ` [PATCH RFC v2 3/3] nvme-rdma: use rdma_reject_msg() to log connection rejects Steve Wise
2016-10-20 22:40 ` Steve Wise
2016-10-21 12:23 ` Christoph Hellwig
2016-10-21 12:23 ` Christoph Hellwig
2016-10-21 21:48 ` Sagi Grimberg
2016-10-21 21:48 ` Sagi Grimberg
2016-10-22 16:12 ` Steve Wise
2016-10-22 16:12 ` Steve Wise
[not found] ` <005701d22c7f$0c883ed0$2598bc70$@opengridcomputing.com>
2016-10-24 14:57 ` Steve Wise
2016-10-24 14:57 ` Steve Wise
2016-10-24 15:09 ` 'Christoph Hellwig'
2016-10-24 15:09 ` 'Christoph Hellwig'
2016-10-21 21:53 ` [PATCH RFC v2 0/3] connect reject event helpers Sagi Grimberg
2016-10-21 21:53 ` Sagi Grimberg
2016-10-21 21:58 ` Steve Wise
2016-10-21 21:58 ` Steve Wise
[not found] ` <001701d22be6$4854b8b0$d8fe2a10$@opengridcomputing.com>
2016-10-24 17:44 ` Steve Wise
2016-10-24 17:44 ` Steve Wise
2016-10-24 17:52 ` Chuck Lever
2016-10-24 17:52 ` Chuck Lever
2016-10-24 17:57 ` Steve Wise
2016-10-24 17:57 ` Steve Wise
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='004501d22c7c$fd3e6fa0$f7bb4ee0$@opengridcomputing.com' \
--to=swise@opengridcomputing.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.