Patch numeric domain names

Patch numeric domain names

[Donald R. Gray Jr]

[-- Attachment #1.1: Type: text/plain, Size: 55 bytes --]

Patch to allow numbers in domain names for cifscreds. 

[-- Attachment #1.2: cifs-utils-all_numeric_domain_names.diff --]
[-- Type: application/octet-stream, Size: 493 bytes --]

diff --git a/cifscreds.c b/cifscreds.c
index f21a47f..5fbf4e8 100644
--- a/cifscreds.c
+++ b/cifscreds.c
@@ -43,7 +43,8 @@
 /* allowed and disallowed characters for user and domain name */
 #define USER_DISALLOWED_CHARS "\\/\"[]:|<>+=;,?*@"
 #define DOMAIN_ALLOWED_CHARS "abcdefghijklmnopqrstuvwxyz" \
-			     "ABCDEFGHIJKLMNOPQRSTUVWXYZ-."
+			     "ABCDEFGHIJKLMNOPQRSTUVWXYZ-." \
+			     "0123456789"
 
 /* destination keyring */
 #define DEST_KEYRING KEY_SPEC_USER_KEYRING

[-- Attachment #2: smime.p7s --]
[-- Type: application/pkcs7-signature, Size: 4995 bytes --]

Re: Patch numeric domain names

[Jeff Layton]

On Thu, 3 Nov 2011 23:03:36 -0400
"Donald R. Gray Jr" <donald.r.gray-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote:

> Patch to allow numbers in domain names for cifscreds. 

According to this msdn page, we should actually be able to allow more
characters than just alphanumerics in NetBIOS domain names:

    http://support.microsoft.com/kb/909264

Would it be better to fix the code to just follow those rules instead?


-- 
Jeff Layton <jlayton-eUNUBHrolfbYtjvyW6yDsg@public.gmane.org>

Re: Patch numeric domain names

[Steve French]

On Fri, Nov 4, 2011 at 8:52 AM, Jeff Layton <jlayton-eUNUBHrolfbYtjvyW6yDsg@public.gmane.org> wrote:
> On Thu, 3 Nov 2011 23:03:36 -0400
> "Donald R. Gray Jr" <donald.r.gray-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote:
>
>> Patch to allow numbers in domain names for cifscreds.
>
> According to this msdn page, we should actually be able to allow more
> characters than just alphanumerics in NetBIOS domain names:
>
>    http://support.microsoft.com/kb/909264
>
> Would it be better to fix the code to just follow those rules instead?

Yes - there are only about 10 restricted characters, and even those
might not be restricted to some non-Windows servers.  It is
reasonable to warn in userspace on some of those, but
risky to forbid certain domain names.


-- 
Thanks,

Steve