* Patch numeric domain names @ 2011-11-04 3:03 Donald R. Gray Jr 2011-11-04 13:52 ` Jeff Layton 0 siblings, 1 reply; 3+ messages in thread From: Donald R. Gray Jr @ 2011-11-04 3:03 UTC (permalink / raw) To: linux-cifs-u79uwXL29TY76Z2rM5mHXA [-- Attachment #1.1: Type: text/plain, Size: 55 bytes --] Patch to allow numbers in domain names for cifscreds. [-- Attachment #1.2: cifs-utils-all_numeric_domain_names.diff --] [-- Type: application/octet-stream, Size: 493 bytes --] diff --git a/cifscreds.c b/cifscreds.c index f21a47f..5fbf4e8 100644 --- a/cifscreds.c +++ b/cifscreds.c @@ -43,7 +43,8 @@ /* allowed and disallowed characters for user and domain name */ #define USER_DISALLOWED_CHARS "\\/\"[]:|<>+=;,?*@" #define DOMAIN_ALLOWED_CHARS "abcdefghijklmnopqrstuvwxyz" \ - "ABCDEFGHIJKLMNOPQRSTUVWXYZ-." + "ABCDEFGHIJKLMNOPQRSTUVWXYZ-." \ + "0123456789" /* destination keyring */ #define DEST_KEYRING KEY_SPEC_USER_KEYRING [-- Attachment #2: smime.p7s --] [-- Type: application/pkcs7-signature, Size: 4995 bytes --] ^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: Patch numeric domain names 2011-11-04 3:03 Patch numeric domain names Donald R. Gray Jr @ 2011-11-04 13:52 ` Jeff Layton [not found] ` <20111104095253.14e7f0a5-9yPaYZwiELC+kQycOl6kW4xkIHaj4LzF@public.gmane.org> 0 siblings, 1 reply; 3+ messages in thread From: Jeff Layton @ 2011-11-04 13:52 UTC (permalink / raw) To: Donald R. Gray Jr; +Cc: linux-cifs-u79uwXL29TY76Z2rM5mHXA On Thu, 3 Nov 2011 23:03:36 -0400 "Donald R. Gray Jr" <donald.r.gray-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote: > Patch to allow numbers in domain names for cifscreds. According to this msdn page, we should actually be able to allow more characters than just alphanumerics in NetBIOS domain names: http://support.microsoft.com/kb/909264 Would it be better to fix the code to just follow those rules instead? -- Jeff Layton <jlayton-eUNUBHrolfbYtjvyW6yDsg@public.gmane.org> ^ permalink raw reply [flat|nested] 3+ messages in thread
[parent not found: <20111104095253.14e7f0a5-9yPaYZwiELC+kQycOl6kW4xkIHaj4LzF@public.gmane.org>]
* Re: Patch numeric domain names [not found] ` <20111104095253.14e7f0a5-9yPaYZwiELC+kQycOl6kW4xkIHaj4LzF@public.gmane.org> @ 2011-11-04 16:20 ` Steve French 0 siblings, 0 replies; 3+ messages in thread From: Steve French @ 2011-11-04 16:20 UTC (permalink / raw) To: Jeff Layton; +Cc: Donald R. Gray Jr, linux-cifs-u79uwXL29TY76Z2rM5mHXA On Fri, Nov 4, 2011 at 8:52 AM, Jeff Layton <jlayton-eUNUBHrolfbYtjvyW6yDsg@public.gmane.org> wrote: > On Thu, 3 Nov 2011 23:03:36 -0400 > "Donald R. Gray Jr" <donald.r.gray-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote: > >> Patch to allow numbers in domain names for cifscreds. > > According to this msdn page, we should actually be able to allow more > characters than just alphanumerics in NetBIOS domain names: > > http://support.microsoft.com/kb/909264 > > Would it be better to fix the code to just follow those rules instead? Yes - there are only about 10 restricted characters, and even those might not be restricted to some non-Windows servers. It is reasonable to warn in userspace on some of those, but risky to forbid certain domain names. -- Thanks, Steve ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-11-04 16:20 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-11-04 3:03 Patch numeric domain names Donald R. Gray Jr
2011-11-04 13:52 ` Jeff Layton
[not found] ` <20111104095253.14e7f0a5-9yPaYZwiELC+kQycOl6kW4xkIHaj4LzF@public.gmane.org>
2011-11-04 16:20 ` Steve French
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.