From: "Sricharan" <sricharan@codeaurora.org>
To: 'Wolfram Sang' <wsa@the-dreams.de>
Cc: devicetree@vger.kernel.org, architt@codeaurora.org,
linux-arm-msm@vger.kernel.org, ntelkar@codeaurora.org,
galak@codeaurora.org, linux-kernel@vger.kernel.org,
andy.gross@linaro.org, linux-i2c@vger.kernel.org,
iivanov@mm-sol.com, agross@codeaurora.org,
dmaengine@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: RE: [PATCH V7 3/6] i2c: qup: Transfer each i2c_msg in i2c_msgs without a stop bit
Date: Fri, 5 Feb 2016 13:30:25 +0530 [thread overview]
Message-ID: <006e01d15feb$4a08d0a0$de1a71e0$@codeaurora.org> (raw)
In-Reply-To: <20160204200903.GE1958@tetsubishi>
Hi Wolfram,
> -----Original Message-----
> From: linux-arm-kernel [mailto:linux-arm-kernel-
> bounces@lists.infradead.org] On Behalf Of Wolfram Sang
> Sent: Friday, February 05, 2016 1:39 AM
> To: Sricharan
> Cc: devicetree@vger.kernel.org; architt@codeaurora.org; linux-arm-
> msm@vger.kernel.org; ntelkar@codeaurora.org; galak@codeaurora.org;
> linux-kernel@vger.kernel.org; andy.gross@linaro.org; linux-
> i2c@vger.kernel.org; iivanov@mm-sol.com; agross@codeaurora.org;
> dmaengine@vger.kernel.org; linux-arm-kernel@lists.infradead.org
> Subject: Re: [PATCH V7 3/6] i2c: qup: Transfer each i2c_msg in i2c_msgs
> without a stop bit
>
> Hi,
>
> > Ah, so what I meant above is there is no 'STOP' bit between each msg
> > in i2c_msgs, but 'REAPEATED_START' still holds true. We are sending
> > 'START' bit for each msg.
> > So these is how each msg in i2c_msg is sent,
> >
> > |------MSG1--------|-----MSG2---------|------MSG3------------|
> >
> > |START|DATA|------|START|DATA|---|START|DATA|STOP|
> >
> > If my commit text does not make this clear, I can reword that ?
>
> OK, now this looks to me perfectly fine: A number of *messages*
> concatenated into one *transfer* by repeated start. That's the way it
should
> be.
>
> So, I'd simply remove these words:
>
> "The QUP i2c hardware has no way to inform that there should not be a
> 'STOP' at the end of transaction. The only way to implement this is to
> coalesce all the i2c_msg in i2c_msgs in to one transaction and transfer
them."
>
> This sounded like the HW needed a special handling, so I was under the
> impression REP_START was broken. However, unless I misunderstood
> something again, this now sounds like the standard case and we can keep
> the commit message simple. If you are okay with that, I can update it
here,
> no need to resend.
>
Yes the above modified commit text looks perfect to be updated and
thanks
for the update as well.
Regards,
Sricharan
WARNING: multiple messages have this Message-ID (diff)
From: sricharan@codeaurora.org (Sricharan)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH V7 3/6] i2c: qup: Transfer each i2c_msg in i2c_msgs without a stop bit
Date: Fri, 5 Feb 2016 13:30:25 +0530 [thread overview]
Message-ID: <006e01d15feb$4a08d0a0$de1a71e0$@codeaurora.org> (raw)
In-Reply-To: <20160204200903.GE1958@tetsubishi>
Hi Wolfram,
> -----Original Message-----
> From: linux-arm-kernel [mailto:linux-arm-kernel-
> bounces at lists.infradead.org] On Behalf Of Wolfram Sang
> Sent: Friday, February 05, 2016 1:39 AM
> To: Sricharan
> Cc: devicetree at vger.kernel.org; architt at codeaurora.org; linux-arm-
> msm at vger.kernel.org; ntelkar at codeaurora.org; galak at codeaurora.org;
> linux-kernel at vger.kernel.org; andy.gross at linaro.org; linux-
> i2c at vger.kernel.org; iivanov at mm-sol.com; agross at codeaurora.org;
> dmaengine at vger.kernel.org; linux-arm-kernel at lists.infradead.org
> Subject: Re: [PATCH V7 3/6] i2c: qup: Transfer each i2c_msg in i2c_msgs
> without a stop bit
>
> Hi,
>
> > Ah, so what I meant above is there is no 'STOP' bit between each msg
> > in i2c_msgs, but 'REAPEATED_START' still holds true. We are sending
> > 'START' bit for each msg.
> > So these is how each msg in i2c_msg is sent,
> >
> > |------MSG1--------|-----MSG2---------|------MSG3------------|
> >
> > |START|DATA|------|START|DATA|---|START|DATA|STOP|
> >
> > If my commit text does not make this clear, I can reword that ?
>
> OK, now this looks to me perfectly fine: A number of *messages*
> concatenated into one *transfer* by repeated start. That's the way it
should
> be.
>
> So, I'd simply remove these words:
>
> "The QUP i2c hardware has no way to inform that there should not be a
> 'STOP' at the end of transaction. The only way to implement this is to
> coalesce all the i2c_msg in i2c_msgs in to one transaction and transfer
them."
>
> This sounded like the HW needed a special handling, so I was under the
> impression REP_START was broken. However, unless I misunderstood
> something again, this now sounds like the standard case and we can keep
> the commit message simple. If you are okay with that, I can update it
here,
> no need to resend.
>
Yes the above modified commit text looks perfect to be updated and
thanks
for the update as well.
Regards,
Sricharan
WARNING: multiple messages have this Message-ID (diff)
From: "Sricharan" <sricharan@codeaurora.org>
To: "'Wolfram Sang'" <wsa@the-dreams.de>
Cc: <devicetree@vger.kernel.org>, <architt@codeaurora.org>,
<linux-arm-msm@vger.kernel.org>, <ntelkar@codeaurora.org>,
<galak@codeaurora.org>, <linux-kernel@vger.kernel.org>,
<andy.gross@linaro.org>, <linux-i2c@vger.kernel.org>,
<iivanov@mm-sol.com>, <agross@codeaurora.org>,
<dmaengine@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>
Subject: RE: [PATCH V7 3/6] i2c: qup: Transfer each i2c_msg in i2c_msgs without a stop bit
Date: Fri, 5 Feb 2016 13:30:25 +0530 [thread overview]
Message-ID: <006e01d15feb$4a08d0a0$de1a71e0$@codeaurora.org> (raw)
In-Reply-To: <20160204200903.GE1958@tetsubishi>
Hi Wolfram,
> -----Original Message-----
> From: linux-arm-kernel [mailto:linux-arm-kernel-
> bounces@lists.infradead.org] On Behalf Of Wolfram Sang
> Sent: Friday, February 05, 2016 1:39 AM
> To: Sricharan
> Cc: devicetree@vger.kernel.org; architt@codeaurora.org; linux-arm-
> msm@vger.kernel.org; ntelkar@codeaurora.org; galak@codeaurora.org;
> linux-kernel@vger.kernel.org; andy.gross@linaro.org; linux-
> i2c@vger.kernel.org; iivanov@mm-sol.com; agross@codeaurora.org;
> dmaengine@vger.kernel.org; linux-arm-kernel@lists.infradead.org
> Subject: Re: [PATCH V7 3/6] i2c: qup: Transfer each i2c_msg in i2c_msgs
> without a stop bit
>
> Hi,
>
> > Ah, so what I meant above is there is no 'STOP' bit between each msg
> > in i2c_msgs, but 'REAPEATED_START' still holds true. We are sending
> > 'START' bit for each msg.
> > So these is how each msg in i2c_msg is sent,
> >
> > |------MSG1--------|-----MSG2---------|------MSG3------------|
> >
> > |START|DATA|------|START|DATA|---|START|DATA|STOP|
> >
> > If my commit text does not make this clear, I can reword that ?
>
> OK, now this looks to me perfectly fine: A number of *messages*
> concatenated into one *transfer* by repeated start. That's the way it
should
> be.
>
> So, I'd simply remove these words:
>
> "The QUP i2c hardware has no way to inform that there should not be a
> 'STOP' at the end of transaction. The only way to implement this is to
> coalesce all the i2c_msg in i2c_msgs in to one transaction and transfer
them."
>
> This sounded like the HW needed a special handling, so I was under the
> impression REP_START was broken. However, unless I misunderstood
> something again, this now sounds like the standard case and we can keep
> the commit message simple. If you are okay with that, I can update it
here,
> no need to resend.
>
Yes the above modified commit text looks perfect to be updated and
thanks
for the update as well.
Regards,
Sricharan
next prev parent reply other threads:[~2016-02-05 8:00 UTC|newest]
Thread overview: 62+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-19 10:02 [PATCH V7 0/6] i2c: qup: Add support for v2 tags and bam dma Sricharan R
2016-01-19 10:02 ` Sricharan R
2016-01-19 10:02 ` [PATCH V7 1/6] i2c: qup: Change qup_wait_writeready function to use for all timeouts Sricharan R
2016-01-19 10:02 ` Sricharan R
2016-01-19 10:02 ` Sricharan R
2016-02-12 18:37 ` Wolfram Sang
2016-02-12 18:37 ` Wolfram Sang
2016-01-19 10:02 ` [PATCH V7 2/6] i2c: qup: Add V2 tags support Sricharan R
2016-01-19 10:02 ` Sricharan R
2016-02-12 18:37 ` Wolfram Sang
2016-02-12 18:37 ` Wolfram Sang
2016-01-19 10:02 ` [PATCH V7 3/6] i2c: qup: Transfer each i2c_msg in i2c_msgs without a stop bit Sricharan R
2016-01-19 10:02 ` Sricharan R
2016-01-24 11:29 ` Wolfram Sang
2016-01-24 11:29 ` Wolfram Sang
2016-01-28 4:57 ` Sricharan
2016-01-28 4:57 ` Sricharan
2016-01-28 4:57 ` Sricharan
2016-02-04 20:09 ` Wolfram Sang
2016-02-04 20:09 ` Wolfram Sang
2016-02-05 8:00 ` Sricharan [this message]
2016-02-05 8:00 ` Sricharan
2016-02-05 8:00 ` Sricharan
2016-02-12 18:38 ` Wolfram Sang
2016-02-12 18:38 ` Wolfram Sang
2016-01-19 10:02 ` [PATCH V7 4/6] i2c: qup: Add bam dma capabilities Sricharan R
2016-01-19 10:02 ` Sricharan R
2016-02-12 18:37 ` Wolfram Sang
2016-02-12 18:37 ` Wolfram Sang
2016-02-12 18:42 ` Wolfram Sang
2016-02-12 18:42 ` Wolfram Sang
2016-02-13 6:58 ` Sricharan
2016-02-13 6:58 ` Sricharan
2016-02-13 6:58 ` Sricharan
2016-02-22 12:24 ` Sricharan
2016-02-22 12:24 ` Sricharan
2016-02-22 12:24 ` Sricharan
2016-02-22 12:32 ` Wolfram Sang
2016-02-22 12:32 ` Wolfram Sang
2016-02-22 13:41 ` Sricharan
2016-02-22 13:41 ` Sricharan
2016-02-22 13:41 ` Sricharan
2016-01-19 10:02 ` [PATCH V7 5/6] dts: msm8974: Add blsp2_bam dma node Sricharan R
2016-01-19 10:02 ` Sricharan R
[not found] ` <1453197766-18976-6-git-send-email-sricharan-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2016-03-25 23:17 ` Bjorn Andersson
2016-03-25 23:17 ` Bjorn Andersson
2016-03-25 23:17 ` Bjorn Andersson
2016-03-26 2:26 ` Andy Gross
2016-03-26 2:26 ` Andy Gross
2016-03-28 12:59 ` Sricharan
2016-03-28 12:59 ` Sricharan
2016-03-28 12:59 ` Sricharan
2016-01-19 10:02 ` [PATCH V7 6/6] dts: msm8974: Add dma channels for blsp2_i2c1 node Sricharan R
2016-01-19 10:02 ` Sricharan R
2016-01-19 10:14 ` [PATCH V7 0/6] i2c: qup: Add support for v2 tags and bam dma Sricharan
2016-01-19 10:14 ` Sricharan
2016-01-19 10:14 ` Sricharan
2016-01-24 11:33 ` Wolfram Sang
2016-01-24 11:33 ` Wolfram Sang
2016-01-28 5:27 ` Sricharan
2016-01-28 5:27 ` Sricharan
2016-01-28 5:27 ` Sricharan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='006e01d15feb$4a08d0a0$de1a71e0$@codeaurora.org' \
--to=sricharan@codeaurora.org \
--cc=agross@codeaurora.org \
--cc=andy.gross@linaro.org \
--cc=architt@codeaurora.org \
--cc=devicetree@vger.kernel.org \
--cc=dmaengine@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=iivanov@mm-sol.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ntelkar@codeaurora.org \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.