All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 01/19] rtc: rtc-mv: remove erroneous __exit annotation
@ 2013-02-28  8:38 Jingoo Han
  2013-02-28  8:39 ` [PATCH 02/19] rtc: rtc-davinci: remove erroneous __init annotation Jingoo Han
                   ` (17 more replies)
  0 siblings, 18 replies; 22+ messages in thread
From: Jingoo Han @ 2013-02-28  8:38 UTC (permalink / raw)
  To: 'Andrew Morton'
  Cc: linux-kernel, 'Alessandro Zummo', rtc-linux,
	'Jingoo Han'

__init/__exit annotations for probe()/remove() are supposed to be
__devinit/__devexit, because __init/__exit for probe()/remove()
are not correct. However, __devinit/__devexit are not used,
because CONFIG_HOTPLUG was removed. Thus, these annotations
should be removed.

Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
 drivers/rtc/rtc-mv.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/rtc/rtc-mv.c b/drivers/rtc/rtc-mv.c
index 57233c8..8cb15d2 100644
--- a/drivers/rtc/rtc-mv.c
+++ b/drivers/rtc/rtc-mv.c
@@ -284,7 +284,7 @@ static int mv_rtc_probe(struct platform_device *pdev)
 	return 0;
 }
 
-static int __exit mv_rtc_remove(struct platform_device *pdev)
+static int mv_rtc_remove(struct platform_device *pdev)
 {
 	struct rtc_plat_data *pdata = platform_get_drvdata(pdev);
 
@@ -303,7 +303,7 @@ static struct of_device_id rtc_mv_of_match_table[] = {
 #endif
 
 static struct platform_driver mv_rtc_driver = {
-	.remove		= __exit_p(mv_rtc_remove),
+	.remove		= mv_rtc_remove,
 	.driver		= {
 		.name	= "rtc-mv",
 		.owner	= THIS_MODULE,
-- 
1.7.2.5



^ permalink raw reply related	[flat|nested] 22+ messages in thread
* Re: [PATCH 01/19] rtc: rtc-mv: remove erroneous __exit annotation
@ 2013-02-28  9:41 Jingoo Han
  0 siblings, 0 replies; 22+ messages in thread
From: Jingoo Han @ 2013-02-28  9:41 UTC (permalink / raw)
  To: 'Andrew Morton'
  Cc: linux-kernel, 'Alessandro Zummo', rtc-linux,
	'Geert Uytterhoeven', 'Jingoo Han'

On Thursday, February 28, 2013 5:38 PM, Jingoo Han wrote:
> 
> __init/__exit annotations for probe()/remove() are supposed to be
> __devinit/__devexit, because __init/__exit for probe()/remove()
> are not correct. However, __devinit/__devexit are not used,
> because CONFIG_HOTPLUG was removed. Thus, these annotations
> should be removed.
> 

Hi Andrew,

As Geert Uytterhoeven mentioned, the patchset is useless
because the drivers I sent for use platform_driver_probe().

Please, abandon all patchset that I sent.
Thank you.


Best regards,
Jingoo Han


> Signed-off-by: Jingoo Han <jg1.han@samsung.com>
> ---
>  drivers/rtc/rtc-mv.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/rtc/rtc-mv.c b/drivers/rtc/rtc-mv.c
> index 57233c8..8cb15d2 100644
> --- a/drivers/rtc/rtc-mv.c
> +++ b/drivers/rtc/rtc-mv.c
> @@ -284,7 +284,7 @@ static int mv_rtc_probe(struct platform_device *pdev)
>  	return 0;
>  }
> 
> -static int __exit mv_rtc_remove(struct platform_device *pdev)
> +static int mv_rtc_remove(struct platform_device *pdev)
>  {
>  	struct rtc_plat_data *pdata = platform_get_drvdata(pdev);
> 
> @@ -303,7 +303,7 @@ static struct of_device_id rtc_mv_of_match_table[] = {
>  #endif
> 
>  static struct platform_driver mv_rtc_driver = {
> -	.remove		= __exit_p(mv_rtc_remove),
> +	.remove		= mv_rtc_remove,
>  	.driver		= {
>  		.name	= "rtc-mv",
>  		.owner	= THIS_MODULE,
> --
> 1.7.2.5



^ permalink raw reply	[flat|nested] 22+ messages in thread
end of thread, other threads:[~2013-02-28  9:41 UTC | newest]

Thread overview: 22+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-02-28  8:38 [PATCH 01/19] rtc: rtc-mv: remove erroneous __exit annotation Jingoo Han
2013-02-28  8:39 ` [PATCH 02/19] rtc: rtc-davinci: remove erroneous __init annotation Jingoo Han
2013-02-28  8:39 ` [PATCH 03/19] rtc: rtc-ds1302: " Jingoo Han
2013-02-28  8:40 ` [PATCH 04/19] rtc: omap: remove erroneous __init/__exit annotations Jingoo Han
2013-02-28  8:40 ` [PATCH 05/19] rtc: rtc-efi: " Jingoo Han
2013-02-28  8:41 ` [PATCH 06/19] rtc: rtc-mc13xxx: " Jingoo Han
2013-02-28  8:41 ` [PATCH 07/19] rtc: rtc-ps3: " Jingoo Han
2013-02-28  8:56   ` Geert Uytterhoeven
2013-02-28  9:36     ` Jingoo Han
2013-02-28  8:41 ` [PATCH 08/19] rtc: rtc-coh901331: " Jingoo Han
2013-02-28  8:42 ` [PATCH 09/19] rtc: rtc-pxa: " Jingoo Han
2013-02-28  8:42 ` [PATCH 10/19] rtc: rtc-rp5c01: " Jingoo Han
2013-02-28  8:43 ` [PATCH 11/19] rtc: rtc-at32ap700x: " Jingoo Han
2013-02-28  8:43 ` [PATCH 12/19] rtc: rtc-ab3100: " Jingoo Han
2013-02-28  8:43 ` [PATCH 13/19] rtc: rtc-at91rm9200: " Jingoo Han
2013-02-28  8:44 ` [PATCH 14/19] rtc: msm6242: " Jingoo Han
2013-02-28  8:44 ` [PATCH 15/19] rtc: rtc-tx4939: " Jingoo Han
2013-02-28  8:45 ` [PATCH 16/19] rtc: rtc-sun4v: " Jingoo Han
2013-02-28  8:45 ` [PATCH 17/19] rtc: rtc-generic: " Jingoo Han
2013-02-28  8:46 ` [PATCH 18/19] rtc: rtc-sh: " Jingoo Han
2013-02-28  8:46 ` [PATCH 19/19] rtc: rtc-starfire: " Jingoo Han
  -- strict thread matches above, loose matches on Subject: below --
2013-02-28  9:41 [PATCH 01/19] rtc: rtc-mv: remove erroneous __exit annotation Jingoo Han

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.