[linux-lvm] Bug in the min and max macros in lvm-snap.c

[linux-lvm] Bug in the min and max macros in lvm-snap.c

[Hostmaster (www)]

[-- Attachment #1: Type: text/plain, Size: 741 bytes --]

Hi,

I'm installing the lvm_1.0.1-rc1 patch to a RedHat install (kernel 2.4.3-12).

After installing the kernel patch, the kernel build was failing on the min and max macros in lvm-snap.c.
It appears the new version changed the min and max macros in the lvm-internal.h header file to include type. However, it appears that the lvm-snap.c min and max are still using the old definition.

Since I'm not intending to use the snap functionality in the near future. I used this for quick workaround, I just added a snapmin and and snapmax macro definition in lvm-internal.h and changed the instances of min and max in the lvm-snap.c to use the new snapmin and snapmax macros. This allows the kernel to build.

Thanks,
David Lightsey


[-- Attachment #2: Type: text/html, Size: 1571 bytes --]

Re: [linux-lvm] Bug in the min and max macros in lvm-snap.c

[José Luis Domingo López]

On Tuesday, 28 August 2001, at 07:57:20 -0600,
Hostmaster (www) wrote:

> Hi,
> 
> I'm installing the lvm_1.0.1-rc1 patch to a RedHat install (kernel 2.4.3-12).
> 
> After installing the kernel patch, the kernel build was failing on the min and max macros in lvm-snap.c.
>
Maybe I'm wrong, but AFAIR Linus changed max and min macros on 2.4.9, so
they are not backwards compatible. As lvm_1.0.1-rc1 was intended for
kernel 2.4.9, I suppose it used those new max/min macros, so LVM 1.0.1-rc1
doesn't work with kernels < 2.4.9.

Check last week's linux kernel mailing list archives to check what people
think about this sudden change :)

--
Jos� Luis Domingo L�pez
Linux Registered User #189436     Debian GNU/Linux Potato (P166 64 MB RAM)
 
jdomingo EN internautas PUNTO org  => � Spam ? Atente a las consecuencias
jdomingo AT internautas DOT   org  => Spam at your own risk

Re: [linux-lvm] Bug in the min and max macros in lvm-snap.c

[Joe Thornber]

On Tue, Aug 28, 2001 at 05:19:09PM +0000, Jos? Luis Domingo L?pez wrote:
> On Tuesday, 28 August 2001, at 07:57:20 -0600,
> Hostmaster (www) wrote:
> 
> > Hi,
> > 
> > I'm installing the lvm_1.0.1-rc1 patch to a RedHat install (kernel 2.4.3-12).
> > 
> > After installing the kernel patch, the kernel build was failing on the min and max macros in lvm-snap.c.
> >
> Maybe I'm wrong, but AFAIR Linus changed max and min macros on 2.4.9, so
> they are not backwards compatible. As lvm_1.0.1-rc1 was intended for
> kernel 2.4.9, I suppose it used those new max/min macros, so LVM 1.0.1-rc1
> doesn't work with kernels < 2.4.9.

It should work with both 2.4.9 kernels and older ones.  I just checked
CVS and the lvm-snap.c looks correct.