[PATCHv2 wpan-tools 1/2] interface: remove twice phy information

[PATCHv2 wpan-tools 1/2] interface: remove twice phy information

[Alexander Aring]

The phy information is already shown in a previous printout and this
code seems that it was never be functional.

Signed-off-by: Alexander Aring <alex.aring@gmail.com>
---
 src/interface.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/src/interface.c b/src/interface.c
index 095753b..904b96e 100644
--- a/src/interface.c
+++ b/src/interface.c
@@ -212,8 +212,6 @@ static int print_iface_handler(struct nl_msg *msg, void *arg)
 		       le16toh(nla_get_u16(tb_msg[NL802154_ATTR_PAN_ID])));
 	if (tb_msg[NL802154_ATTR_IFTYPE])
 		printf("%s\ttype %s\n", indent, iftype_name(nla_get_u32(tb_msg[NL802154_ATTR_IFTYPE])));
-	if (!wpan_phy && tb_msg[NL802154_ATTR_WPAN_PHY])
-		printf("%s\twpan_phy %d\n", indent, nla_get_u32(tb_msg[NL802154_ATTR_WPAN_PHY]));
 	if (tb_msg[NL802154_ATTR_MAX_FRAME_RETRIES])
 		printf("%s\tmax_frame_retries %d\n", indent, nla_get_s8(tb_msg[NL802154_ATTR_MAX_FRAME_RETRIES]));
 	if (tb_msg[NL802154_ATTR_MIN_BE])
-- 
2.2.2

[PATCHv2 wpan-tools 2/2] info: remove unused features argument

[Alexander Aring]

This patch removes an unused argument string for the phy information
call. This is copied from the original iw tool. If we need really such
argument then we can add this later again.

Signed-off-by: Alexander Aring <alex.aring@gmail.com>
---
 src/info.c | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/src/info.c b/src/info.c
index 83f2e3e..e155470 100644
--- a/src/info.c
+++ b/src/info.c
@@ -94,10 +94,6 @@ static int handle_info(struct nl802154_state *state,
 		       int argc, char **argv,
 		       enum id_input id)
 {
-	char *feat_args[] = { "features", "-q" };
-
-	handle_cmd(state, CIB_NONE, 2, feat_args);
-
 	nl_cb_set(cb, NL_CB_VALID, NL_CB_CUSTOM, print_phy_handler, NULL);
 
 	return 0;
-- 
2.2.2

Re: [PATCHv2 wpan-tools 2/2] info: remove unused features argument

[Stefan Schmidt]

Hello.

On 20/01/15 21:02, Alexander Aring wrote:
> This patch removes an unused argument string for the phy information
> call. This is copied from the original iw tool. If we need really such
> argument then we can add this later again.
>
> Signed-off-by: Alexander Aring <alex.aring@gmail.com>
> ---
>   src/info.c | 4 ----
>   1 file changed, 4 deletions(-)
>
> diff --git a/src/info.c b/src/info.c
> index 83f2e3e..e155470 100644
> --- a/src/info.c
> +++ b/src/info.c
> @@ -94,10 +94,6 @@ static int handle_info(struct nl802154_state *state,
>   		       int argc, char **argv,
>   		       enum id_input id)
>   {
> -	char *feat_args[] = { "features", "-q" };
> -
> -	handle_cmd(state, CIB_NONE, 2, feat_args);
> -
>   	nl_cb_set(cb, NL_CB_VALID, NL_CB_CUSTOM, print_phy_handler, NULL);
>
>   	return 0;
>

Reviewed-by: Stefan Schmidt <s.schmidt@samsung.com>

regards
Stefan Schmidt

Re: [PATCHv2 wpan-tools 1/2] interface: remove twice phy information

[Stefan Schmidt]

Hello.

On 20/01/15 21:02, Alexander Aring wrote:
> The phy information is already shown in a previous printout and this
> code seems that it was never be functional.
>
> Signed-off-by: Alexander Aring <alex.aring@gmail.com>
> ---
>   src/interface.c | 2 --
>   1 file changed, 2 deletions(-)
>
> diff --git a/src/interface.c b/src/interface.c
> index 095753b..904b96e 100644
> --- a/src/interface.c
> +++ b/src/interface.c
> @@ -212,8 +212,6 @@ static int print_iface_handler(struct nl_msg *msg,
> void *arg)
>
> le16toh(nla_get_u16(tb_msg[NL802154_ATTR_PAN_ID])));
>   	if (tb_msg[NL802154_ATTR_IFTYPE])
>   		printf("%s\ttype %s\n", indent,
> iftype_name(nla_get_u32(tb_msg[NL802154_ATTR_IFTYPE])));
> -	if (!wpan_phy && tb_msg[NL802154_ATTR_WPAN_PHY])
> -		printf("%s\twpan_phy %d\n", indent,
> nla_get_u32(tb_msg[NL802154_ATTR_WPAN_PHY]));
>   	if (tb_msg[NL802154_ATTR_MAX_FRAME_RETRIES])
>   		printf("%s\tmax_frame_retries %d\n", indent,
> nla_get_s8(tb_msg[NL802154_ATTR_MAX_FRAME_RETRIES]));
>   	if (tb_msg[NL802154_ATTR_MIN_BE])
>

Reviewed-by: Stefan Schmidt <s.schmidt@samsung.com>

regards
Stefan Schmidt