From: "Steve Wise" <swise@opengridcomputing.com>
To: 'Colin King' <colin.king-Z7WLFzj8eWMS+FvcfC7Uqw@public.gmane.org>,
'Steve Wise' <swise-ut6Up61K2wZBDgjK7y7TUQ@public.gmane.org>,
'Doug Ledford' <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
'Jason Gunthorpe' <jgg-uk2M96/98Pc@public.gmane.org>,
linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Cc: kernel-janitors-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
bharat-ut6Up61K2wZBDgjK7y7TUQ@public.gmane.org
Subject: RE: [PATCH] iw_cxgb4: make pointer reg_workq static
Date: Thu, 30 Nov 2017 16:41:50 +0000 [thread overview]
Message-ID: <00fe01d369fa$1f325890$5d9709b0$@opengridcomputing.com> (raw)
In-Reply-To: <20171130133006.19699-1-colin.king-Z7WLFzj8eWMS+FvcfC7Uqw@public.gmane.org>
>
> From: Colin Ian King <colin.king@canonical.com>
>
> The pointer reg_workq is local to the source and does not need to be
> in global scope, so make it static.
>
> Cleans up sparse warning:
> drivers/infiniband/hw/cxgb4/device.c:69:25: warning: symbol 'reg_workq'
> was not declared. Should it be static?
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Looks correct. This fixes a recent commit.
Reviewed-by: Steve Wise <swise@opengridcomputing.com>
Fixes: 1c8f1da5d851 ("iw_cxgb4: Fix possible circular dependency locking warning")
Thanks,
Steve.
WARNING: multiple messages have this Message-ID (diff)
From: "Steve Wise" <swise-7bPotxP6k4+P2YhJcF5u+vpXobYPEAuW@public.gmane.org>
To: 'Colin King' <colin.king-Z7WLFzj8eWMS+FvcfC7Uqw@public.gmane.org>,
'Steve Wise' <swise-ut6Up61K2wZBDgjK7y7TUQ@public.gmane.org>,
'Doug Ledford' <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
'Jason Gunthorpe' <jgg-uk2M96/98Pc@public.gmane.org>,
linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Cc: kernel-janitors-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
bharat-ut6Up61K2wZBDgjK7y7TUQ@public.gmane.org
Subject: RE: [PATCH] iw_cxgb4: make pointer reg_workq static
Date: Thu, 30 Nov 2017 10:41:50 -0600 [thread overview]
Message-ID: <00fe01d369fa$1f325890$5d9709b0$@opengridcomputing.com> (raw)
In-Reply-To: <20171130133006.19699-1-colin.king-Z7WLFzj8eWMS+FvcfC7Uqw@public.gmane.org>
>
> From: Colin Ian King <colin.king-Z7WLFzj8eWMS+FvcfC7Uqw@public.gmane.org>
>
> The pointer reg_workq is local to the source and does not need to be
> in global scope, so make it static.
>
> Cleans up sparse warning:
> drivers/infiniband/hw/cxgb4/device.c:69:25: warning: symbol 'reg_workq'
> was not declared. Should it be static?
>
> Signed-off-by: Colin Ian King <colin.king-Z7WLFzj8eWMS+FvcfC7Uqw@public.gmane.org>
Looks correct. This fixes a recent commit.
Reviewed-by: Steve Wise <swise-7bPotxP6k4+P2YhJcF5u+vpXobYPEAuW@public.gmane.org>
Fixes: 1c8f1da5d851 ("iw_cxgb4: Fix possible circular dependency locking warning")
Thanks,
Steve.
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: "Steve Wise" <swise@opengridcomputing.com>
To: "'Colin King'" <colin.king@canonical.com>,
"'Steve Wise'" <swise@chelsio.com>,
"'Doug Ledford'" <dledford@redhat.com>,
"'Jason Gunthorpe'" <jgg@ziepe.ca>, <linux-rdma@vger.kernel.org>
Cc: <kernel-janitors@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<bharat@chelsio.com>
Subject: RE: [PATCH] iw_cxgb4: make pointer reg_workq static
Date: Thu, 30 Nov 2017 10:41:50 -0600 [thread overview]
Message-ID: <00fe01d369fa$1f325890$5d9709b0$@opengridcomputing.com> (raw)
In-Reply-To: <20171130133006.19699-1-colin.king@canonical.com>
>
> From: Colin Ian King <colin.king@canonical.com>
>
> The pointer reg_workq is local to the source and does not need to be
> in global scope, so make it static.
>
> Cleans up sparse warning:
> drivers/infiniband/hw/cxgb4/device.c:69:25: warning: symbol 'reg_workq'
> was not declared. Should it be static?
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Looks correct. This fixes a recent commit.
Reviewed-by: Steve Wise <swise@opengridcomputing.com>
Fixes: 1c8f1da5d851 ("iw_cxgb4: Fix possible circular dependency locking warning")
Thanks,
Steve.
next prev parent reply other threads:[~2017-11-30 16:41 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-30 13:30 [PATCH] iw_cxgb4: make pointer reg_workq static Colin King
2017-11-30 14:13 ` Leon Romanovsky
2017-11-30 14:13 ` Leon Romanovsky
[not found] ` <20171130133006.19699-1-colin.king-Z7WLFzj8eWMS+FvcfC7Uqw@public.gmane.org>
2017-11-30 16:41 ` Steve Wise [this message]
2017-11-30 16:41 ` Steve Wise
2017-11-30 16:41 ` Steve Wise
2017-12-13 18:19 ` Jason Gunthorpe
2017-12-13 18:19 ` Jason Gunthorpe
2017-12-13 18:19 ` Jason Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='00fe01d369fa$1f325890$5d9709b0$@opengridcomputing.com' \
--to=swise@opengridcomputing.com \
--cc=bharat-ut6Up61K2wZBDgjK7y7TUQ@public.gmane.org \
--cc=colin.king-Z7WLFzj8eWMS+FvcfC7Uqw@public.gmane.org \
--cc=dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=jgg-uk2M96/98Pc@public.gmane.org \
--cc=kernel-janitors-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=swise-ut6Up61K2wZBDgjK7y7TUQ@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.