* [meta-fsl-arm] [linux-2.6.35-r45] amd-gpu : patch proposal / discussion (imx53 + Qt 5.3 + EGLFS) @ 2014-11-12 0:17 Gianluca Cinci 2014-11-12 10:47 ` Daiane Angolini 0 siblings, 1 reply; 13+ messages in thread From: Gianluca Cinci @ 2014-11-12 0:17 UTC (permalink / raw) To: meta-freescale [-- Attachment #1: Type: text/plain, Size: 11499 bytes --] From 768a9f37734a9c6acb02ac1a832127af9f15da1b Mon Sep 17 00:00:00 2001 From: Gianluca Cinci <gianluca.cinci@giuneco.it> Date: Tue, 11 Nov 2014 22:25:17 +0100 Subject: [PATCH] avoid shared memory free issue on application exit --- drivers/mxc/amd-gpu/common/gsl_sharedmem.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/mxc/amd-gpu/common/gsl_sharedmem.c b/drivers/mxc/amd-gpu/common/gsl_sharedmem.c index 51e66f9..2529267 100644 --- a/drivers/mxc/amd-gpu/common/gsl_sharedmem.c +++ b/drivers/mxc/amd-gpu/common/gsl_sharedmem.c @@ -430,6 +430,9 @@ kgsl_sharedmem_free0(gsl_memdesc_t *memdesc, unsigned int pid) } else { + kgsl_hal_freephysical(memdesc->gpuaddr, NULL, NULL); // free the previously allocated memory if + // gpuaddress is present in gsl_linux_map_list + status = GSL_FAILURE; } -- 1.9.1 Hi all, i finally reached to run an Qt 5.3 application on imx53(loco) board (linux 2.6.35-r45) My problem come out when i try to execute a previously killed application: ------------------------------------------------------------------------------------------------------------------------------------ Unable to handle kernel paging request at virtual address 8e011800 pgd = cf550000 [8e011800] *pgd=00000000 Internal error: Oops: 5 [#1] PREEMPT last sysfs file: /sys/devices/system/cpu/online Modules linked in: CPU: 0 Not tainted (2.6.35.3-aep-imx53+gb3912bb #42) PC is at vmalloc_to_page+0x38/0x70 LR is at kgsl_hal_allocphysical+0x38/0x74 pc : [<8010ddfc>] lr : [<80376620>] psr: 20070013 sp : cf5a1e28 ip : 0000cafe fp : 00000000 r10: 8069bf88 r9 : 80620a90 r8 : 8068760c r7 : d0fd6000 r6 : cf6b7200 r5 : 00000044 r4 : 0000002a r3 : 7e011000 r2 : 70000000 r1 : 10000800 r0 : 10000800 Flags: nzCv IRQs on FIQs on Mode SVC_32 ISA ARM Segment user Control: 10c5387d Table: bf550019 DAC: 00000015 Process QSGRenderThread (pid: 1600, stack limit = 0xcf5a02e8) Stack: (0xcf5a1e28 to 0xcf5a2000) 1e20: cf6b7400 cf5a1edc 00000100 000c0000 8069bcf8 00000000 1e40: 00000001 80373568 0000063c 000004fa 00000000 28866154 00044000 800db6ec 1e60: 2888cf65 00000000 00000044 cf6b7200 8063dfa8 8069bcf8 00000001 cf5a1edc 1e80: 00044000 000c0000 cf5a0000 0000005c 2fbd4464 8037362c cf7b9700 cf7b9700 1ea0: cf5a0030 c010f931 8008ffc4 80375c48 00000181 cf550bf0 00000604 29209080 1ec0: 00000a28 cf64fd68 cf738300 00000001 000c0000 00044000 00561cc8 00c16000 1ee0: 00c16000 00044000 00000100 00000000 0000081f 80620d18 cf7b9700 00000000 1f00: 2fbd4464 80128e88 00002000 cf7b9700 cf7b9700 c010f931 00000005 801297dc 1f20: cf645b18 00000000 cf7b9700 00000bf0 00000000 cf7b9700 00000026 00026000 1f40: cf5a0020 00000001 0000000a cf64fb58 cf75dc34 cf5a0010 cf7b9700 000844fb 1f60: cf5a1f50 2fbd4464 cf7b9700 c010f931 00000005 8008ffc4 cf5a0000 0000005c 1f80: 00000000 801298fc 00000005 00000001 2fbd4464 00561cc8 423c7168 00044000 1fa0: 00000036 8008fe40 00561cc8 423c7168 00000005 c010f931 2fbd4464 00000134 1fc0: 00561cc8 423c7168 00044000 00000036 00000001 00000000 0000005c 00000000 1fe0: 423c7084 2fbd4454 423bd2d4 4f9218bc 00070010 00000005 fe023a18 fe023a18 [<8010ddfc>] (vmalloc_to_page+0x38/0x70) from [<80376620>] (kgsl_hal_allocphysical+0x38/0x74) [<80376620>] (kgsl_hal_allocphysical+0x38/0x74) from [<80373568>] (kgsl_sharedmem_alloc0+0x290/0x320) [<80373568>] (kgsl_sharedmem_alloc0+0x290/0x320) from [<8037362c>] (kgsl_sharedmem_alloc+0x34/0x4c) [<8037362c>] (kgsl_sharedmem_alloc+0x34/0x4c) from [<80375c48>] (gsl_kmod_ioctl+0x880/0xe4c) [<80375c48>] (gsl_kmod_ioctl+0x880/0xe4c) from [<80128e88>] (vfs_ioctl+0x7c/0xac) [<80128e88>] (vfs_ioctl+0x7c/0xac) from [<801297dc>] (do_vfs_ioctl+0x484/0x574) [<801297dc>] (do_vfs_ioctl+0x484/0x574) from [<801298fc>] (sys_ioctl+0x30/0x5c) [<801298fc>] (sys_ioctl+0x30/0x5c) from [<8008fe40>] (ret_fast_syscall+0x0/0x30) Code: e5922000 e2621102 e2811b02 e0810100 (e7903003) ---[ end trace b52db45d97dbc59c ]--- ------------------------------------------------------------------------------------------------------------------------------------ Sometimes the system freeze without a kernel dump , and probably this affect also another kind of kernel panic (case of study , posted at the end of this mail) As you can see in the kernel log , the problem come out when a vmalloc_to_page void is invoked. This is because the function try to allocate "numpages" memory pages of size "PAGE_SIZE" based on gpuaddres X. During the for iteration , the void fails and a kernel panic occur. Exploring the driver sources i found this condition inside the kgsl_sharedmem_free0 function: gsl_sharedmem.c: "if (shmem->flags & GSL_FLAGS_INITIALIZED)" That means "if the state of the shared memory is GSL_FLAGS_INIZIALED , a new free memory operation can be executed". This seems to work well during normal running but , when an application is terminated, the state of shared memory changes from GSL_FLAGS_INITIALIZED to GSL_FLAGS_NORMALMODE. This prevent the all unmappping operations to be executed during other states , but also exclude the previously allocated memory to be freed. On application exit the driver invoke the function kgsl_sharedmem_free0 n times as many uncleaned memory blocks are present on list: gsl_kmod_cleanup,c: int del_all_memblocks_from_allocated_list(struct file *fd) (see notes at end (*1) ) But "at this state" , the void kgsl_sharedmem_free0 can't invoke kgsl_hal_freephysical (because the shared memory flags) and returns a GSL_ERROR status without free the memory. The patch avoid this problem by calling the kgsl_hal_freephysical in the else condition. Invoke the kgsl_hal_freephysical is safe , because exploring it , the subroutine: gsl_linux_map.c: void gsl_linux_map_free(unsigned int gpu_addr) cleans the memory only if the gpuaddrr is present inside the gsl_linux_map_list. I think that some consideration can be made about this (and probably this solution can be considered on a better look way...) Finally the step to run a Qt 5.3 application on imx53 if someone has this problem (tested on a framebuffer system) 1) add to local.conf or wherever you want the packages: ---cinematicexperience ---amd-gpu-bin-mx51 (this is usefull because inside the recipe there is the PACKAGES variable that is just setted to include the all libraries needed. The package contains only some test binary of GPU acceleration NOTE :if the egl libraries were not included the Qt 5 application failed to start with EGL Error : Could not create the egl surface: error = 0x3003) 2)apply the patch to kernel 3) build a new image 3) run Qt5_CinematicExperience -platform eglfs During this analysys I didn't find any that conduce to think about some non cleaned blocks during normal execution and also the gsl_sanity_app reach the end with success every time. Best Regards Gianluca Cinci Notes: (*1) : here a kgsl_sharedmem_free (without 0) is called , inside that there is a subcall to kgsl_sharedmem_free0 (*2) : the other kernel message mentioned above: -------------------------------------------------------------- Unhandled fault: external abort on non-linefetch (0x1008) at 0xd0ac0edc Internal error: : 1008 [#1] PREEMPT last sysfs file: /sys/devices/system/cpu/online Modules linked in: CPU: 0 Not tainted (2.6.35.3-11.09.01+yocto+ged51f22 #1) PC is at kgsl_yamato_regread+0xc/0x24 LR is at kgsl_yamato_isr+0x18/0x80 pc : [<80376c2c>] lr : [<80377450>] psr: 60070193 sp : c81dff58 ip : ffffab5e fp : 00000000 r10: 00000000 r9 : c81de000 r8 : 00000000 r7 : 0000000c r6 : 00000000 r5 : 00000000 r4 : 806a0b28 r3 : d0ac0000 r2 : c81dff5c r1 : 000003b7 r0 : 806a0b28 Flags: nZCv IRQs off FIQs on Mode SVC_32 ISA ARM Segment user Control: 10c5387d Table: ba6e4019 DAC: 00000015 Process QSGRenderThread (pid: 1700, stack limit = 0xc81de2e8) Stack: (0xc81dff58 to 0xc81e0000) ff40: 806a0b28 cff48780 ff60: 806a0b28 80373b5c cf263f40 803792dc 803792d0 800e9e50 00000000 80641e3c ff80: 0000000c cf263f40 00000001 800eb8b4 0000000c 00000000 00000001 80090068 ffa0: 20070010 ffffffff d0800000 80090bc8 32681000 01aae330 00003910 00000000 ffc0: 01aac450 4c298b80 002f0498 01aac450 00001850 002f8420 00000000 00000000 ffe0: 32682ec0 3216d934 4bef37e4 4bc6a0b0 20070010 ffffffff 8e38d48b 59ebdc88 [<80376c2c>] (kgsl_yamato_regread+0xc/0x24) from [<80377450>] (kgsl_yamato_isr+) [<80377450>] (kgsl_yamato_isr+0x18/0x80) from [<80373b5c>] (kgsl_intr_isr+0x24/) [<80373b5c>] (kgsl_intr_isr+0x24/0x28) from [<803792dc>] (z430_irq_handler+0xc/) [<803792dc>] (z430_irq_handler+0xc/0x18) from [<800e9e50>] (handle_IRQ_event+0x) [<800e9e50>] (handle_IRQ_event+0x24/0xdc) from [<800eb8b4>] (handle_level_irq+0) [<800eb8b4>] (handle_level_irq+0xd8/0x184) from [<80090068>] (asm_do_IRQ+0x68/0) [<80090068>] (asm_do_IRQ+0x68/0x88) from [<80090bc8>] (__irq_usr+0x48/0xc0) Exception stack(0xc81dffb0 to 0xc81dfff8) ffa0: 32681000 01aae330 00003910 00000000 ffc0: 01aac450 4c298b80 002f0498 01aac450 00001850 002f8420 00000000 00000000 ffe0: 32682ec0 3216d934 4bef37e4 4bc6a0b0 20070010 ffffffff Code: e12fff1e e5903088 f57ff04f f57ff04f (e7933101) ---[ end trace 0efc6cf93f26278e ]--- Kernel panic - not syncing: Fatal exception in interrupt [<80095144>] (unwind_backtrace+0x0/0xe0) from [<804aacfc>] (panic+0x68/0xdc) [<804aacfc>] (panic+0x68/0xdc) from [<80094158>] (die+0x2a8/0x2f8) [<80094158>] (die+0x2a8/0x2f8) from [<8009026c>] (do_DataAbort+0x84/0x98) [<8009026c>] (do_DataAbort+0x84/0x98) from [<8009092c>] (__dabt_svc+0x4c/0x60) Exception stack(0xc81dff10 to 0xc81dff58) ff00: 806a0b28 000003b7 c81dff5c d0ac0000 ff20: 806a0b28 00000000 00000000 0000000c 00000000 c81de000 00000000 00000000 ff40: ffffab5e c81dff58 80377450 80376c2c 60070193 ffffffff [<8009092c>] (__dabt_svc+0x4c/0x60) from [<80376c2c>] (kgsl_yamato_regread+0xc/) [<80376c2c>] (kgsl_yamato_regread+0xc/0x24) from [<80377450>] (kgsl_yamato_isr+) [<80377450>] (kgsl_yamato_isr+0x18/0x80) from [<80373b5c>] (kgsl_intr_isr+0x24/) [<80373b5c>] (kgsl_intr_isr+0x24/0x28) from [<803792dc>] (z430_irq_handler+0xc/) [<803792dc>] (z430_irq_handler+0xc/0x18) from [<800e9e50>] (handle_IRQ_event+0x) [<800e9e50>] (handle_IRQ_event+0x24/0xdc) from [<800eb8b4>] (handle_level_irq+0) [<800eb8b4>] (handle_level_irq+0xd8/0x184) from [<80090068>] (asm_do_IRQ+0x68/0) [<80090068>] (asm_do_IRQ+0x68/0x88) from [<80090bc8>] (__irq_usr+0x48/0xc0) Exception stack(0xc81dffb0 to 0xc81dfff8) ffa0: 32681000 01aae330 00003910 00000000 ffc0: 01aac450 4c298b80 002f0498 01aac450 00001850 002f8420 00000000 00000000 ffe0: 32682ec0 3216d934 4bef37e4 4bc6a0b0 20070010 ffffffff --------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- [-- Attachment #2: Type: text/html, Size: 14352 bytes --] ^ permalink raw reply related [flat|nested] 13+ messages in thread
* Re: [meta-fsl-arm] [linux-2.6.35-r45] amd-gpu : patch proposal / discussion (imx53 + Qt 5.3 + EGLFS) 2014-11-12 0:17 [meta-fsl-arm] [linux-2.6.35-r45] amd-gpu : patch proposal / discussion (imx53 + Qt 5.3 + EGLFS) Gianluca Cinci @ 2014-11-12 10:47 ` Daiane Angolini 2014-11-13 8:22 ` Gianluca Cinci 0 siblings, 1 reply; 13+ messages in thread From: Daiane Angolini @ 2014-11-12 10:47 UTC (permalink / raw) To: Gianluca Cinci; +Cc: meta-freescale@yoctoproject.org On Tue, Nov 11, 2014 at 10:17 PM, Gianluca Cinci <gianluca.cinci@giuneco.it> wrote: > From 768a9f37734a9c6acb02ac1a832127af9f15da1b Mon Sep 17 00:00:00 2001 > From: Gianluca Cinci <gianluca.cinci@giuneco.it> > Date: Tue, 11 Nov 2014 22:25:17 +0100 > Subject: [PATCH] avoid shared memory free issue on application exit I would start the commit subject with "imx: amd-gpu: avoid shared......" > > --- > drivers/mxc/amd-gpu/common/gsl_sharedmem.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/mxc/amd-gpu/common/gsl_sharedmem.c > b/drivers/mxc/amd-gpu/common/gsl_sharedmem.c > index 51e66f9..2529267 100644 > --- a/drivers/mxc/amd-gpu/common/gsl_sharedmem.c > +++ b/drivers/mxc/amd-gpu/common/gsl_sharedmem.c > @@ -430,6 +430,9 @@ kgsl_sharedmem_free0(gsl_memdesc_t *memdesc, unsigned > int pid) > } > else > { > + kgsl_hal_freephysical(memdesc->gpuaddr, NULL, NULL); // free the > previously allocated memory if > + > // gpuaddress is present in gsl_linux_map_list > + > status = GSL_FAILURE; > } > > -- > 1.9.1 > > > Hi all, > i finally reached to run an Qt 5.3 application on imx53(loco) board (linux > 2.6.35-r45) > My problem come out when i try to execute a previously killed application: > ------------------------------------------------------------------------------------------------------------------------------------ > Unable to handle kernel paging request at virtual address 8e011800 > pgd = cf550000 (...) > Finally the step to run a Qt 5.3 application on imx53 if someone has this > problem (tested on a framebuffer system) > > 1) add to local.conf or wherever you want the packages: > ---cinematicexperience > ---amd-gpu-bin-mx51 (this is usefull because inside the recipe there > is the PACKAGES variable that is just setted to include the all libraries > needed. > The package contains only some test > binary of GPU acceleration > NOTE :if the egl libraries were not > included the Qt 5 application failed to start with EGL Error : Could not > create the egl surface: error = 0x3003) > Does it means we have a dependency error? > 2)apply the patch to kernel Would you, please, create a patch for the kernel recipe [1] including your kernel patch for _mx5? [1] http://git.yoctoproject.org/cgit/cgit.cgi/meta-fsl-arm/tree/recipes-kernel/linux/linux-imx_2.6.35.3.bb This is something I would like to test. Daiane > > 3) build a new image > > 3) run Qt5_CinematicExperience -platform eglfs > > During this analysys I didn't find any that conduce to think about some non > cleaned blocks during normal execution and also the gsl_sanity_app reach the > end with success every time. > > > Best Regards > Gianluca Cinci > > Notes: > (*1) : here a kgsl_sharedmem_free (without 0) is called , inside that there > is a subcall to kgsl_sharedmem_free0 > > (*2) : > the other kernel message mentioned above: > -------------------------------------------------------------- > > > Unhandled fault: external abort on non-linefetch (0x1008) at 0xd0ac0edc > Internal error: : 1008 [#1] PREEMPT last sysfs file: > /sys/devices/system/cpu/online Modules linked in: > CPU: 0 Not tainted (2.6.35.3-11.09.01+yocto+ged51f22 #1) > PC is at kgsl_yamato_regread+0xc/0x24 > LR is at kgsl_yamato_isr+0x18/0x80 > pc : [<80376c2c>] lr : [<80377450>] psr: 60070193 > sp : c81dff58 ip : ffffab5e fp : 00000000 > r10: 00000000 r9 : c81de000 r8 : 00000000 > r7 : 0000000c r6 : 00000000 r5 : 00000000 r4 : 806a0b28 > r3 : d0ac0000 r2 : c81dff5c r1 : 000003b7 r0 : 806a0b28 > Flags: nZCv IRQs off FIQs on Mode SVC_32 ISA ARM Segment user > Control: 10c5387d Table: ba6e4019 DAC: 00000015 Process QSGRenderThread > (pid: 1700, stack limit = 0xc81de2e8) > Stack: (0xc81dff58 to 0xc81e0000) > ff40: 806a0b28 > cff48780 > ff60: 806a0b28 80373b5c cf263f40 803792dc 803792d0 800e9e50 00000000 > 80641e3c > ff80: 0000000c cf263f40 00000001 800eb8b4 0000000c 00000000 00000001 > 80090068 > ffa0: 20070010 ffffffff d0800000 80090bc8 32681000 01aae330 00003910 > 00000000 > ffc0: 01aac450 4c298b80 002f0498 01aac450 00001850 002f8420 00000000 > 00000000 > ffe0: 32682ec0 3216d934 4bef37e4 4bc6a0b0 20070010 ffffffff 8e38d48b > 59ebdc88 > [<80376c2c>] (kgsl_yamato_regread+0xc/0x24) from [<80377450>] > (kgsl_yamato_isr+) > [<80377450>] (kgsl_yamato_isr+0x18/0x80) from [<80373b5c>] > (kgsl_intr_isr+0x24/) > [<80373b5c>] (kgsl_intr_isr+0x24/0x28) from [<803792dc>] > (z430_irq_handler+0xc/) > [<803792dc>] (z430_irq_handler+0xc/0x18) from [<800e9e50>] > (handle_IRQ_event+0x) > [<800e9e50>] (handle_IRQ_event+0x24/0xdc) from [<800eb8b4>] > (handle_level_irq+0) > [<800eb8b4>] (handle_level_irq+0xd8/0x184) from [<80090068>] > (asm_do_IRQ+0x68/0) > [<80090068>] (asm_do_IRQ+0x68/0x88) from [<80090bc8>] (__irq_usr+0x48/0xc0) > Exception stack(0xc81dffb0 to 0xc81dfff8) > ffa0: 32681000 01aae330 00003910 > 00000000 > ffc0: 01aac450 4c298b80 002f0498 01aac450 00001850 002f8420 00000000 > 00000000 > ffe0: 32682ec0 3216d934 4bef37e4 4bc6a0b0 20070010 ffffffff > Code: e12fff1e e5903088 f57ff04f f57ff04f (e7933101) ---[ end trace > 0efc6cf93f26278e ]--- > Kernel panic - not syncing: Fatal exception in interrupt [<80095144>] > (unwind_backtrace+0x0/0xe0) from [<804aacfc>] > (panic+0x68/0xdc) > [<804aacfc>] (panic+0x68/0xdc) from [<80094158>] (die+0x2a8/0x2f8) > [<80094158>] (die+0x2a8/0x2f8) > from [<8009026c>] (do_DataAbort+0x84/0x98) [<8009026c>] > (do_DataAbort+0x84/0x98) from [<8009092c>] > (__dabt_svc+0x4c/0x60) > Exception stack(0xc81dff10 to 0xc81dff58) > ff00: 806a0b28 000003b7 c81dff5c > d0ac0000 > ff20: 806a0b28 00000000 00000000 0000000c 00000000 c81de000 00000000 > 00000000 > ff40: ffffab5e c81dff58 80377450 80376c2c 60070193 ffffffff [<8009092c>] > (__dabt_svc+0x4c/0x60) from [<80376c2c>] > (kgsl_yamato_regread+0xc/) > [<80376c2c>] (kgsl_yamato_regread+0xc/0x24) from [<80377450>] > (kgsl_yamato_isr+) > [<80377450>] (kgsl_yamato_isr+0x18/0x80) from [<80373b5c>] > (kgsl_intr_isr+0x24/) > [<80373b5c>] (kgsl_intr_isr+0x24/0x28) from [<803792dc>] > (z430_irq_handler+0xc/) > [<803792dc>] (z430_irq_handler+0xc/0x18) from [<800e9e50>] > (handle_IRQ_event+0x) > [<800e9e50>] (handle_IRQ_event+0x24/0xdc) from [<800eb8b4>] > (handle_level_irq+0) > [<800eb8b4>] (handle_level_irq+0xd8/0x184) from [<80090068>] > (asm_do_IRQ+0x68/0) > [<80090068>] (asm_do_IRQ+0x68/0x88) from [<80090bc8>] (__irq_usr+0x48/0xc0) > Exception stack(0xc81dffb0 to 0xc81dfff8) > ffa0: 32681000 01aae330 00003910 > 00000000 > ffc0: 01aac450 4c298b80 002f0498 01aac450 00001850 002f8420 00000000 > 00000000 > ffe0: 32682ec0 3216d934 4bef37e4 4bc6a0b0 20070010 ffffffff > --------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- > > > > > > > -- > _______________________________________________ > meta-freescale mailing list > meta-freescale@yoctoproject.org > https://lists.yoctoproject.org/listinfo/meta-freescale > ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [meta-fsl-arm] [linux-2.6.35-r45] amd-gpu : patch proposal / discussion (imx53 + Qt 5.3 + EGLFS) 2014-11-12 10:47 ` Daiane Angolini @ 2014-11-13 8:22 ` Gianluca Cinci 2014-11-13 10:18 ` Otavio Salvador 2014-11-13 10:28 ` Daiane Angolini 0 siblings, 2 replies; 13+ messages in thread From: Gianluca Cinci @ 2014-11-13 8:22 UTC (permalink / raw) To: Daiane Angolini; +Cc: meta-freescale@yoctoproject.org [-- Attachment #1: Type: text/plain, Size: 8083 bytes --] Hi Daiane, sure , the patch is attached to this mail (let me know if I must to change it) About the cinematicexperience + eglfs dependecies: With the only inclusion of cinematicexperience the "EGL..." error come out , so i must to add the "amd-gpu-bin-mx51" package to have all the necessary library on my fs. Bests Regards Gianluca On 12/11/2014 11:47, Daiane Angolini wrote: > On Tue, Nov 11, 2014 at 10:17 PM, Gianluca Cinci > <gianluca.cinci@giuneco.it> wrote: >> From 768a9f37734a9c6acb02ac1a832127af9f15da1b Mon Sep 17 00:00:00 2001 >> From: Gianluca Cinci <gianluca.cinci@giuneco.it> >> Date: Tue, 11 Nov 2014 22:25:17 +0100 >> Subject: [PATCH] avoid shared memory free issue on application exit > I would start the commit subject with "imx: amd-gpu: avoid shared......" > > >> --- >> drivers/mxc/amd-gpu/common/gsl_sharedmem.c | 3 +++ >> 1 file changed, 3 insertions(+) >> >> diff --git a/drivers/mxc/amd-gpu/common/gsl_sharedmem.c >> b/drivers/mxc/amd-gpu/common/gsl_sharedmem.c >> index 51e66f9..2529267 100644 >> --- a/drivers/mxc/amd-gpu/common/gsl_sharedmem.c >> +++ b/drivers/mxc/amd-gpu/common/gsl_sharedmem.c >> @@ -430,6 +430,9 @@ kgsl_sharedmem_free0(gsl_memdesc_t *memdesc, unsigned >> int pid) >> } >> else >> { >> + kgsl_hal_freephysical(memdesc->gpuaddr, NULL, NULL); // free the >> previously allocated memory if >> + >> // gpuaddress is present in gsl_linux_map_list >> + >> status = GSL_FAILURE; >> } >> >> -- >> 1.9.1 >> >> >> Hi all, >> i finally reached to run an Qt 5.3 application on imx53(loco) board (linux >> 2.6.35-r45) >> My problem come out when i try to execute a previously killed application: >> ------------------------------------------------------------------------------------------------------------------------------------ >> Unable to handle kernel paging request at virtual address 8e011800 >> pgd = cf550000 > (...) >> Finally the step to run a Qt 5.3 application on imx53 if someone has this >> problem (tested on a framebuffer system) >> >> 1) add to local.conf or wherever you want the packages: >> ---cinematicexperience >> ---amd-gpu-bin-mx51 (this is usefull because inside the recipe there >> is the PACKAGES variable that is just setted to include the all libraries >> needed. >> The package contains only some test >> binary of GPU acceleration >> NOTE :if the egl libraries were not >> included the Qt 5 application failed to start with EGL Error : Could not >> create the egl surface: error = 0x3003) >> > Does it means we have a dependency error? > > > >> 2)apply the patch to kernel > Would you, please, create a patch for the kernel recipe [1] including > your kernel patch for _mx5? > > [1] http://git.yoctoproject.org/cgit/cgit.cgi/meta-fsl-arm/tree/recipes-kernel/linux/linux-imx_2.6.35.3.bb > > This is something I would like to test. > > > Daiane >> 3) build a new image >> >> 3) run Qt5_CinematicExperience -platform eglfs >> >> During this analysys I didn't find any that conduce to think about some non >> cleaned blocks during normal execution and also the gsl_sanity_app reach the >> end with success every time. >> >> >> Best Regards >> Gianluca Cinci >> >> Notes: >> (*1) : here a kgsl_sharedmem_free (without 0) is called , inside that there >> is a subcall to kgsl_sharedmem_free0 >> >> (*2) : >> the other kernel message mentioned above: >> -------------------------------------------------------------- >> >> >> Unhandled fault: external abort on non-linefetch (0x1008) at 0xd0ac0edc >> Internal error: : 1008 [#1] PREEMPT last sysfs file: >> /sys/devices/system/cpu/online Modules linked in: >> CPU: 0 Not tainted (2.6.35.3-11.09.01+yocto+ged51f22 #1) >> PC is at kgsl_yamato_regread+0xc/0x24 >> LR is at kgsl_yamato_isr+0x18/0x80 >> pc : [<80376c2c>] lr : [<80377450>] psr: 60070193 >> sp : c81dff58 ip : ffffab5e fp : 00000000 >> r10: 00000000 r9 : c81de000 r8 : 00000000 >> r7 : 0000000c r6 : 00000000 r5 : 00000000 r4 : 806a0b28 >> r3 : d0ac0000 r2 : c81dff5c r1 : 000003b7 r0 : 806a0b28 >> Flags: nZCv IRQs off FIQs on Mode SVC_32 ISA ARM Segment user >> Control: 10c5387d Table: ba6e4019 DAC: 00000015 Process QSGRenderThread >> (pid: 1700, stack limit = 0xc81de2e8) >> Stack: (0xc81dff58 to 0xc81e0000) >> ff40: 806a0b28 >> cff48780 >> ff60: 806a0b28 80373b5c cf263f40 803792dc 803792d0 800e9e50 00000000 >> 80641e3c >> ff80: 0000000c cf263f40 00000001 800eb8b4 0000000c 00000000 00000001 >> 80090068 >> ffa0: 20070010 ffffffff d0800000 80090bc8 32681000 01aae330 00003910 >> 00000000 >> ffc0: 01aac450 4c298b80 002f0498 01aac450 00001850 002f8420 00000000 >> 00000000 >> ffe0: 32682ec0 3216d934 4bef37e4 4bc6a0b0 20070010 ffffffff 8e38d48b >> 59ebdc88 >> [<80376c2c>] (kgsl_yamato_regread+0xc/0x24) from [<80377450>] >> (kgsl_yamato_isr+) >> [<80377450>] (kgsl_yamato_isr+0x18/0x80) from [<80373b5c>] >> (kgsl_intr_isr+0x24/) >> [<80373b5c>] (kgsl_intr_isr+0x24/0x28) from [<803792dc>] >> (z430_irq_handler+0xc/) >> [<803792dc>] (z430_irq_handler+0xc/0x18) from [<800e9e50>] >> (handle_IRQ_event+0x) >> [<800e9e50>] (handle_IRQ_event+0x24/0xdc) from [<800eb8b4>] >> (handle_level_irq+0) >> [<800eb8b4>] (handle_level_irq+0xd8/0x184) from [<80090068>] >> (asm_do_IRQ+0x68/0) >> [<80090068>] (asm_do_IRQ+0x68/0x88) from [<80090bc8>] (__irq_usr+0x48/0xc0) >> Exception stack(0xc81dffb0 to 0xc81dfff8) >> ffa0: 32681000 01aae330 00003910 >> 00000000 >> ffc0: 01aac450 4c298b80 002f0498 01aac450 00001850 002f8420 00000000 >> 00000000 >> ffe0: 32682ec0 3216d934 4bef37e4 4bc6a0b0 20070010 ffffffff >> Code: e12fff1e e5903088 f57ff04f f57ff04f (e7933101) ---[ end trace >> 0efc6cf93f26278e ]--- >> Kernel panic - not syncing: Fatal exception in interrupt [<80095144>] >> (unwind_backtrace+0x0/0xe0) from [<804aacfc>] >> (panic+0x68/0xdc) >> [<804aacfc>] (panic+0x68/0xdc) from [<80094158>] (die+0x2a8/0x2f8) >> [<80094158>] (die+0x2a8/0x2f8) >> from [<8009026c>] (do_DataAbort+0x84/0x98) [<8009026c>] >> (do_DataAbort+0x84/0x98) from [<8009092c>] >> (__dabt_svc+0x4c/0x60) >> Exception stack(0xc81dff10 to 0xc81dff58) >> ff00: 806a0b28 000003b7 c81dff5c >> d0ac0000 >> ff20: 806a0b28 00000000 00000000 0000000c 00000000 c81de000 00000000 >> 00000000 >> ff40: ffffab5e c81dff58 80377450 80376c2c 60070193 ffffffff [<8009092c>] >> (__dabt_svc+0x4c/0x60) from [<80376c2c>] >> (kgsl_yamato_regread+0xc/) >> [<80376c2c>] (kgsl_yamato_regread+0xc/0x24) from [<80377450>] >> (kgsl_yamato_isr+) >> [<80377450>] (kgsl_yamato_isr+0x18/0x80) from [<80373b5c>] >> (kgsl_intr_isr+0x24/) >> [<80373b5c>] (kgsl_intr_isr+0x24/0x28) from [<803792dc>] >> (z430_irq_handler+0xc/) >> [<803792dc>] (z430_irq_handler+0xc/0x18) from [<800e9e50>] >> (handle_IRQ_event+0x) >> [<800e9e50>] (handle_IRQ_event+0x24/0xdc) from [<800eb8b4>] >> (handle_level_irq+0) >> [<800eb8b4>] (handle_level_irq+0xd8/0x184) from [<80090068>] >> (asm_do_IRQ+0x68/0) >> [<80090068>] (asm_do_IRQ+0x68/0x88) from [<80090bc8>] (__irq_usr+0x48/0xc0) >> Exception stack(0xc81dffb0 to 0xc81dfff8) >> ffa0: 32681000 01aae330 00003910 >> 00000000 >> ffc0: 01aac450 4c298b80 002f0498 01aac450 00001850 002f8420 00000000 >> 00000000 >> ffe0: 32682ec0 3216d934 4bef37e4 4bc6a0b0 20070010 ffffffff >> --------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- >> >> >> >> >> >> >> -- >> _______________________________________________ >> meta-freescale mailing list >> meta-freescale@yoctoproject.org >> https://lists.yoctoproject.org/listinfo/meta-freescale >> [-- Attachment #2: imx-amd-gpu-avoid-shared-memory-free-issue.patch --] [-- Type: text/x-patch, Size: 2402 bytes --] From 3201b3740bd6c81e7077845bda605fd5043b0e6a Mon Sep 17 00:00:00 2001 From: gianluca <gianluca@giuneco.it> Date: Thu, 13 Nov 2014 00:11:51 +0100 Subject: [meta-fsl-arm][PATCH] imx: amd-gpu: avoid shared memory free issue on application exit Signed-off-by: gianluca <gianluca@giuneco.it> --- .../avoid-shared-memory-free-issue.patch | 26 ++++++++++++++++++++++ recipes-kernel/linux/linux-imx_2.6.35.3.bb | 1 + 2 files changed, 27 insertions(+) create mode 100644 recipes-kernel/linux/linux-imx-2.6.35.3/avoid-shared-memory-free-issue.patch diff --git a/recipes-kernel/linux/linux-imx-2.6.35.3/avoid-shared-memory-free-issue.patch b/recipes-kernel/linux/linux-imx-2.6.35.3/avoid-shared-memory-free-issue.patch new file mode 100644 index 0000000..a109cc0 --- /dev/null +++ b/recipes-kernel/linux/linux-imx-2.6.35.3/avoid-shared-memory-free-issue.patch @@ -0,0 +1,26 @@ +From 768a9f37734a9c6acb02ac1a832127af9f15da1b Mon Sep 17 00:00:00 2001 +From: gianluca <gianluca@giuneco.it> +Date: Tue, 11 Nov 2014 22:25:17 +0100 +Subject: [PATCH] avoid shared memory free issue on application exit + +--- + drivers/mxc/amd-gpu/common/gsl_sharedmem.c | 3 +++ + 1 file changed, 3 insertions(+) + +diff --git a/drivers/mxc/amd-gpu/common/gsl_sharedmem.c b/drivers/mxc/amd-gpu/common/gsl_sharedmem.c +index 51e66f9..2529267 100644 +--- a/drivers/mxc/amd-gpu/common/gsl_sharedmem.c ++++ b/drivers/mxc/amd-gpu/common/gsl_sharedmem.c +@@ -430,6 +430,9 @@ kgsl_sharedmem_free0(gsl_memdesc_t *memdesc, unsigned int pid) + } + else + { ++ kgsl_hal_freephysical(memdesc->gpuaddr, NULL, NULL); // free the previously allocated memory if ++ // gpuaddress is present in gsl_linux_map_list ++ + status = GSL_FAILURE; + } + +-- +1.9.1 + diff --git a/recipes-kernel/linux/linux-imx_2.6.35.3.bb b/recipes-kernel/linux/linux-imx_2.6.35.3.bb index bfc56b7..ad1f10b 100644 --- a/recipes-kernel/linux/linux-imx_2.6.35.3.bb +++ b/recipes-kernel/linux/linux-imx_2.6.35.3.bb @@ -19,6 +19,7 @@ SRCBRANCH = "imx_2.6.35_maintain" SRC_URI += "file://NFS-Fix-nfsroot-support.patch \ file://NFS-allow-nfs-root-mount-to-use-alternate-rpc-ports.patch \ file://perf-avoid-use-sysroot-headers.patch \ + file://avoid-shared-memory-free-issue.patch \ " SRC_URI_append_mx28 = " \ -- 1.9.1 ^ permalink raw reply related [flat|nested] 13+ messages in thread
* Re: [meta-fsl-arm] [linux-2.6.35-r45] amd-gpu : patch proposal / discussion (imx53 + Qt 5.3 + EGLFS) 2014-11-13 8:22 ` Gianluca Cinci @ 2014-11-13 10:18 ` Otavio Salvador 2014-11-17 13:13 ` Gianluca Cinci 2014-11-13 10:28 ` Daiane Angolini 1 sibling, 1 reply; 13+ messages in thread From: Otavio Salvador @ 2014-11-13 10:18 UTC (permalink / raw) To: Gianluca Cinci; +Cc: meta-freescale@yoctoproject.org On Thu, Nov 13, 2014 at 6:22 AM, Gianluca Cinci <gianluca.cinci@giuneco.it> wrote: > sure , the patch is attached to this mail (let me know if I must to change > it) I think Daiane meant for you to include the patch in the kernel recipe so we could test / review it for inclusion. > About the cinematicexperience + eglfs dependecies: > With the only inclusion of cinematicexperience the "EGL..." error come out > , so i must to add the "amd-gpu-bin-mx51" package to have all the necessary > library on my fs. Could you use strace to see which library it is trying to load and missing? -- Otavio Salvador O.S. Systems http://www.ossystems.com.br http://code.ossystems.com.br Mobile: +55 (53) 9981-7854 Mobile: +1 (347) 903-9750 ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [meta-fsl-arm] [linux-2.6.35-r45] amd-gpu : patch proposal / discussion (imx53 + Qt 5.3 + EGLFS) 2014-11-13 10:18 ` Otavio Salvador @ 2014-11-17 13:13 ` Gianluca Cinci 0 siblings, 0 replies; 13+ messages in thread From: Gianluca Cinci @ 2014-11-17 13:13 UTC (permalink / raw) To: Otavio Salvador; +Cc: meta-freescale@yoctoproject.org On 13/11/2014 11:18, Otavio Salvador wrote: > On Thu, Nov 13, 2014 at 6:22 AM, Gianluca Cinci > <gianluca.cinci@giuneco.it> wrote: >> sure , the patch is attached to this mail (let me know if I must to change >> it) > I think Daiane meant for you to include the patch in the kernel recipe > so we could test / review it for inclusion. > >> About the cinematicexperience + eglfs dependecies: >> With the only inclusion of cinematicexperience the "EGL..." error come out >> , so i must to add the "amd-gpu-bin-mx51" package to have all the necessary >> library on my fs. > Could you use strace to see which library it is trying to load and missing? > Hi Otavio i made some much accurate tests and I can't notice the previously mentioned problem (EGL....Error surface) , probably a miss configuration in my cooked image recipe. But , i found this behaviour :(this are the basic steps) 1) cooked fsl-image-multimedia-full and add only the cinamaticexperience: CORE_IMAGE_EXTRA_INSTALL += " \ packagegroup-fsl-gstreamer-full \ cinematicexperience \ " 2) ~# Qt5_CinematicExperience -platform eglfs This application failed to start because it could not find or load the Qt platform plugin "eglfs". Reinstalling the application may fix this problem. Aborted 3) root@aepimx53:~# opkg install qtbase-plugins 4) root@aepimx53:~# Qt5_CinematicExperience -platform eglfs QFontDatabase: Cannot find font directory /usr/lib/fonts - is Qt installed correctly? Aborted 5) opkg install qtbase-fonts -> resolvs the last missing qtbase dependencies and QtCinematicExperience runs. If you want to investigate about the EGL... surface error , I can try to reproduce the problem again by removing the egls libraries. I'll send the kernel and sources patch early to Daiane and meta-freescale about the amd-gpu driver Best Regards Gianluca ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [meta-fsl-arm] [linux-2.6.35-r45] amd-gpu : patch proposal / discussion (imx53 + Qt 5.3 + EGLFS) 2014-11-13 8:22 ` Gianluca Cinci 2014-11-13 10:18 ` Otavio Salvador @ 2014-11-13 10:28 ` Daiane Angolini 2014-11-18 8:54 ` Gianluca Cinci 1 sibling, 1 reply; 13+ messages in thread From: Daiane Angolini @ 2014-11-13 10:28 UTC (permalink / raw) To: Gianluca Cinci; +Cc: meta-freescale@yoctoproject.org On Thu, Nov 13, 2014 at 6:22 AM, Gianluca Cinci <gianluca.cinci@giuneco.it> wrote: > Hi Daiane, > sure , the patch is attached to this mail (let me know if I must to change > it) Thanks, when send a patch to meta-freescale, please use git send email (I think you did this the first time, right? I copied your patch at the end of this reply, because I have some comments. I cannot comment properly on the gpu code itself, so I would expect someone else to also comment on the patch. > About the cinematicexperience + eglfs dependecies: > With the only inclusion of cinematicexperience the "EGL..." error come out > , so i must to add the "amd-gpu-bin-mx51" package to have all the necessary > library on my fs. Oh, and please, do not top-post. > > Bests Regards > Gianluca > your patch: (I added 2 comments inline) From 3201b3740bd6c81e7077845bda605fd5043b0e6a Mon Sep 17 00:00:00 2001 From: gianluca <gianluca@giuneco.it> Date: Thu, 13 Nov 2014 00:11:51 +0100 Subject: [meta-fsl-arm][PATCH] imx: amd-gpu: avoid shared memory free issue on application exit [Daiane] For this subject please use something like: [meta-fsl-arm][PATCH v2]linux-imx (2.6.35.3): Fix amd-gpu to avoid shared memory free issue. use as example: http://git.yoctoproject.org/cgit/cgit.cgi/meta-fsl-arm/log/recipes-kernel/linux/linux-imx_2.6.35.3.bb Signed-off-by: gianluca <gianluca@giuneco.it> --- .../avoid-shared-memory-free-issue.patch | 26 ++++++++++++++++++++++ recipes-kernel/linux/linux-imx_2.6.35.3.bb | 1 + 2 files changed, 27 insertions(+) create mode 100644 recipes-kernel/linux/linux-imx-2.6.35.3/avoid-shared-memory-free-issue.patch diff --git a/recipes-kernel/linux/linux-imx-2.6.35.3/avoid-shared-memory-free-issue.patch b/recipes-kernel/linux/linux-imx-2.6.35.3/avoid-shared-memory-free-issue.patch new file mode 100644 index 0000000..a109cc0 --- /dev/null +++ b/recipes-kernel/linux/linux-imx-2.6.35.3/avoid-shared-memory-free-issue.patch @@ -0,0 +1,26 @@ +From 768a9f37734a9c6acb02ac1a832127af9f15da1b Mon Sep 17 00:00:00 2001 +From: gianluca <gianluca@giuneco.it> +Date: Tue, 11 Nov 2014 22:25:17 +0100 +Subject: [PATCH] avoid shared memory free issue on application exit [Daiane] For this subject use: [PATCH] imx: amd-gpu: avoid shared memory free issue on application and add the tag Upstream-Status, use as example http://www.openembedded.org/wiki/Commit_Patch_Message_Guidelines#Patch_Header_Recommendations + +--- + drivers/mxc/amd-gpu/common/gsl_sharedmem.c | 3 +++ + 1 file changed, 3 insertions(+) + +diff --git a/drivers/mxc/amd-gpu/common/gsl_sharedmem.c b/drivers/mxc/amd-gpu/common/gsl_sharedmem.c +index 51e66f9..2529267 100644 +--- a/drivers/mxc/amd-gpu/common/gsl_sharedmem.c ++++ b/drivers/mxc/amd-gpu/common/gsl_sharedmem.c +@@ -430,6 +430,9 @@ kgsl_sharedmem_free0(gsl_memdesc_t *memdesc, unsigned int pid) + } + else + { ++ kgsl_hal_freephysical(memdesc->gpuaddr, NULL, NULL); // free the previously allocated memory if ++ // gpuaddress is present in gsl_linux_map_list ++ + status = GSL_FAILURE; + } + +-- +1.9.1 + diff --git a/recipes-kernel/linux/linux-imx_2.6.35.3.bb b/recipes-kernel/linux/linux-imx_2.6.35.3.bb index bfc56b7..ad1f10b 100644 --- a/recipes-kernel/linux/linux-imx_2.6.35.3.bb +++ b/recipes-kernel/linux/linux-imx_2.6.35.3.bb @@ -19,6 +19,7 @@ SRCBRANCH = "imx_2.6.35_maintain" SRC_URI += "file://NFS-Fix-nfsroot-support.patch \ file://NFS-allow-nfs-root-mount-to-use-alternate-rpc-ports.patch \ file://perf-avoid-use-sysroot-headers.patch \ + file://avoid-shared-memory-free-issue.patch \ " SRC_URI_append_mx28 = " \ -- 1.9.1 Daiane ^ permalink raw reply related [flat|nested] 13+ messages in thread
* Re: [meta-fsl-arm] [linux-2.6.35-r45] amd-gpu : patch proposal / discussion (imx53 + Qt 5.3 + EGLFS) 2014-11-13 10:28 ` Daiane Angolini @ 2014-11-18 8:54 ` Gianluca Cinci 2014-11-18 10:39 ` Simone 2014-11-19 15:29 ` Daiane Angolini 0 siblings, 2 replies; 13+ messages in thread From: Gianluca Cinci @ 2014-11-18 8:54 UTC (permalink / raw) To: Daiane Angolini; +Cc: meta-freescale@yoctoproject.org Hi Daiane, On 13/11/2014 11:28, Daiane Angolini wrote: > On Thu, Nov 13, 2014 at 6:22 AM, Gianluca Cinci > <gianluca.cinci@giuneco.it> wrote: >> Hi Daiane, >> sure , the patch is attached to this mail (let me know if I must to change >> it) > Thanks, when send a patch to meta-freescale, please use git send email > (I think you did this the first time, right? yes , I hope the patch is properly formatted... Best Regards Gianluca > > I copied your patch at the end of this reply, because I have some comments. > > I cannot comment properly on the gpu code itself, so I would expect > someone else to also comment on the patch. > > >> About the cinematicexperience + eglfs dependecies: >> With the only inclusion of cinematicexperience the "EGL..." error come out >> , so i must to add the "amd-gpu-bin-mx51" package to have all the necessary >> library on my fs. > > Oh, and please, do not top-post. > >> Bests Regards >> Gianluca >> > your patch: > (I added 2 comments inline) > > > From 3201b3740bd6c81e7077845bda605fd5043b0e6a Mon Sep 17 00:00:00 2001 > From: gianluca <gianluca@giuneco.it> > Date: Thu, 13 Nov 2014 00:11:51 +0100 > Subject: [meta-fsl-arm][PATCH] imx: amd-gpu: avoid shared memory free issue on > application exit > > [Daiane] > For this subject please use something like: > > [meta-fsl-arm][PATCH v2]linux-imx (2.6.35.3): Fix amd-gpu to avoid > shared memory free issue. > > use as example: > http://git.yoctoproject.org/cgit/cgit.cgi/meta-fsl-arm/log/recipes-kernel/linux/linux-imx_2.6.35.3.bb > > > Signed-off-by: gianluca <gianluca@giuneco.it> > --- > .../avoid-shared-memory-free-issue.patch | 26 ++++++++++++++++++++++ > recipes-kernel/linux/linux-imx_2.6.35.3.bb | 1 + > 2 files changed, 27 insertions(+) > create mode 100644 > recipes-kernel/linux/linux-imx-2.6.35.3/avoid-shared-memory-free-issue.patch > > diff --git a/recipes-kernel/linux/linux-imx-2.6.35.3/avoid-shared-memory-free-issue.patch > b/recipes-kernel/linux/linux-imx-2.6.35.3/avoid-shared-memory-free-issue.patch > new file mode 100644 > index 0000000..a109cc0 > --- /dev/null > +++ b/recipes-kernel/linux/linux-imx-2.6.35.3/avoid-shared-memory-free-issue.patch > @@ -0,0 +1,26 @@ > +From 768a9f37734a9c6acb02ac1a832127af9f15da1b Mon Sep 17 00:00:00 2001 > +From: gianluca <gianluca@giuneco.it> > +Date: Tue, 11 Nov 2014 22:25:17 +0100 > +Subject: [PATCH] avoid shared memory free issue on application exit > > [Daiane] > > For this subject use: > [PATCH] imx: amd-gpu: avoid shared memory free issue on application > > and add the tag Upstream-Status, use as example > http://www.openembedded.org/wiki/Commit_Patch_Message_Guidelines#Patch_Header_Recommendations > > > + > +--- > + drivers/mxc/amd-gpu/common/gsl_sharedmem.c | 3 +++ > + 1 file changed, 3 insertions(+) > + > +diff --git a/drivers/mxc/amd-gpu/common/gsl_sharedmem.c > b/drivers/mxc/amd-gpu/common/gsl_sharedmem.c > +index 51e66f9..2529267 100644 > +--- a/drivers/mxc/amd-gpu/common/gsl_sharedmem.c > ++++ b/drivers/mxc/amd-gpu/common/gsl_sharedmem.c > +@@ -430,6 +430,9 @@ kgsl_sharedmem_free0(gsl_memdesc_t *memdesc, > unsigned int pid) > + } > + else > + { > ++ kgsl_hal_freephysical(memdesc->gpuaddr, NULL, NULL); // free the > previously allocated memory if > ++ // gpuaddress is present in gsl_linux_map_list > ++ > + status = GSL_FAILURE; > + } > + > +-- > +1.9.1 > + > diff --git a/recipes-kernel/linux/linux-imx_2.6.35.3.bb > b/recipes-kernel/linux/linux-imx_2.6.35.3.bb > index bfc56b7..ad1f10b 100644 > --- a/recipes-kernel/linux/linux-imx_2.6.35.3.bb > +++ b/recipes-kernel/linux/linux-imx_2.6.35.3.bb > @@ -19,6 +19,7 @@ SRCBRANCH = "imx_2.6.35_maintain" > SRC_URI += "file://NFS-Fix-nfsroot-support.patch \ > file://NFS-allow-nfs-root-mount-to-use-alternate-rpc-ports.patch \ > file://perf-avoid-use-sysroot-headers.patch \ > + file://avoid-shared-memory-free-issue.patch \ > " > > > SRC_URI_append_mx28 = " \ ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [meta-fsl-arm] [linux-2.6.35-r45] amd-gpu : patch proposal / discussion (imx53 + Qt 5.3 + EGLFS) 2014-11-18 8:54 ` Gianluca Cinci @ 2014-11-18 10:39 ` Simone 2014-11-18 11:05 ` Gianluca Cinci 2014-11-19 15:29 ` Daiane Angolini 1 sibling, 1 reply; 13+ messages in thread From: Simone @ 2014-11-18 10:39 UTC (permalink / raw) To: 'Gianluca Cinci', 'Daiane Angolini'; +Cc: meta-freescale Hello Gianluca/Daiane, I tested this patch at my side and I can confirm that it work properly. Still have some other troubles with qt5 effects visualization, but the hang condition on application exit seems to be finally solved. Thanks Best Regards Simone -----Messaggio originale----- Da: meta-freescale-bounces@yoctoproject.org [mailto:meta-freescale-bounces@yoctoproject.org] Per conto di Gianluca Cinci Inviato: martedì 18 novembre 2014 09:54 A: Daiane Angolini Cc: meta-freescale@yoctoproject.org Oggetto: Re: [meta-freescale] [meta-fsl-arm] [linux-2.6.35-r45] amd-gpu : patch proposal / discussion (imx53 + Qt 5.3 + EGLFS) Hi Daiane, On 13/11/2014 11:28, Daiane Angolini wrote: > On Thu, Nov 13, 2014 at 6:22 AM, Gianluca Cinci > <gianluca.cinci@giuneco.it> wrote: >> Hi Daiane, >> sure , the patch is attached to this mail (let me know if I must to >> change >> it) > Thanks, when send a patch to meta-freescale, please use git send email > (I think you did this the first time, right? yes , I hope the patch is properly formatted... Best Regards Gianluca > > I copied your patch at the end of this reply, because I have some comments. > > I cannot comment properly on the gpu code itself, so I would expect > someone else to also comment on the patch. > > >> About the cinematicexperience + eglfs dependecies: >> With the only inclusion of cinematicexperience the "EGL..." error >> come out , so i must to add the "amd-gpu-bin-mx51" package to have >> all the necessary library on my fs. > > Oh, and please, do not top-post. > >> Bests Regards >> Gianluca >> > your patch: > (I added 2 comments inline) > > > From 3201b3740bd6c81e7077845bda605fd5043b0e6a Mon Sep 17 00:00:00 > 2001 > From: gianluca <gianluca@giuneco.it> > Date: Thu, 13 Nov 2014 00:11:51 +0100 > Subject: [meta-fsl-arm][PATCH] imx: amd-gpu: avoid shared memory free issue on > application exit > > [Daiane] > For this subject please use something like: > > [meta-fsl-arm][PATCH v2]linux-imx (2.6.35.3): Fix amd-gpu to avoid > shared memory free issue. > > use as example: > http://git.yoctoproject.org/cgit/cgit.cgi/meta-fsl-arm/log/recipes-ker > nel/linux/linux-imx_2.6.35.3.bb > > > Signed-off-by: gianluca <gianluca@giuneco.it> > --- > .../avoid-shared-memory-free-issue.patch | 26 ++++++++++++++++++++++ > recipes-kernel/linux/linux-imx_2.6.35.3.bb | 1 + > 2 files changed, 27 insertions(+) > create mode 100644 > recipes-kernel/linux/linux-imx-2.6.35.3/avoid-shared-memory-free-issue > .patch > > diff --git > a/recipes-kernel/linux/linux-imx-2.6.35.3/avoid-shared-memory-free-iss > ue.patch > b/recipes-kernel/linux/linux-imx-2.6.35.3/avoid-shared-memory-free-iss > ue.patch > new file mode 100644 > index 0000000..a109cc0 > --- /dev/null > +++ b/recipes-kernel/linux/linux-imx-2.6.35.3/avoid-shared-memory-free > +++ -issue.patch > @@ -0,0 +1,26 @@ > +From 768a9f37734a9c6acb02ac1a832127af9f15da1b Mon Sep 17 00:00:00 > +2001 > +From: gianluca <gianluca@giuneco.it> > +Date: Tue, 11 Nov 2014 22:25:17 +0100 > +Subject: [PATCH] avoid shared memory free issue on application exit > > [Daiane] > > For this subject use: > [PATCH] imx: amd-gpu: avoid shared memory free issue on application > > and add the tag Upstream-Status, use as example > http://www.openembedded.org/wiki/Commit_Patch_Message_Guidelines#Patch > _Header_Recommendations > > > + > +--- > + drivers/mxc/amd-gpu/common/gsl_sharedmem.c | 3 +++ > + 1 file changed, 3 insertions(+) > + > +diff --git a/drivers/mxc/amd-gpu/common/gsl_sharedmem.c > b/drivers/mxc/amd-gpu/common/gsl_sharedmem.c > +index 51e66f9..2529267 100644 > +--- a/drivers/mxc/amd-gpu/common/gsl_sharedmem.c > ++++ b/drivers/mxc/amd-gpu/common/gsl_sharedmem.c > +@@ -430,6 +430,9 @@ kgsl_sharedmem_free0(gsl_memdesc_t *memdesc, > unsigned int pid) > + } > + else > + { > ++ kgsl_hal_freephysical(memdesc->gpuaddr, NULL, NULL); // free the > previously allocated memory if > ++ // gpuaddress is present in gsl_linux_map_list > ++ > + status = GSL_FAILURE; > + } > + > +-- > +1.9.1 > + > diff --git a/recipes-kernel/linux/linux-imx_2.6.35.3.bb > b/recipes-kernel/linux/linux-imx_2.6.35.3.bb > index bfc56b7..ad1f10b 100644 > --- a/recipes-kernel/linux/linux-imx_2.6.35.3.bb > +++ b/recipes-kernel/linux/linux-imx_2.6.35.3.bb > @@ -19,6 +19,7 @@ SRCBRANCH = "imx_2.6.35_maintain" > SRC_URI += "file://NFS-Fix-nfsroot-support.patch \ > file://NFS-allow-nfs-root-mount-to-use-alternate-rpc-ports.patch \ > file://perf-avoid-use-sysroot-headers.patch \ > + file://avoid-shared-memory-free-issue.patch \ > " > > > SRC_URI_append_mx28 = " \ -- _______________________________________________ meta-freescale mailing list meta-freescale@yoctoproject.org https://lists.yoctoproject.org/listinfo/meta-freescale ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [meta-fsl-arm] [linux-2.6.35-r45] amd-gpu : patch proposal / discussion (imx53 + Qt 5.3 + EGLFS) 2014-11-18 10:39 ` Simone @ 2014-11-18 11:05 ` Gianluca Cinci 2014-11-18 13:57 ` Simone 0 siblings, 1 reply; 13+ messages in thread From: Gianluca Cinci @ 2014-11-18 11:05 UTC (permalink / raw) To: Simone, 'Daiane Angolini'; +Cc: meta-freescale Hi Simone, if you talk about the CinematicExperience's "fog" ; same "problem" here . Just disable the first effect on the list and you can see all the DVD's cases , I not investigate about that aspect.. I create a script that runs all the amd-gpu-bin-mx51 applications; tested in continue run for 3 days and all is went ok. Gianluca On 18/11/2014 11:39, Simone wrote: > Hello Gianluca/Daiane, > I tested this patch at my side and I can confirm that it work properly. > Still have some other troubles with qt5 effects visualization, but the hang > condition on application exit seems to be finally solved. > > Thanks > Best Regards > Simone > > > > > -----Messaggio originale----- > Da: meta-freescale-bounces@yoctoproject.org > [mailto:meta-freescale-bounces@yoctoproject.org] Per conto di Gianluca Cinci > Inviato: martedì 18 novembre 2014 09:54 > A: Daiane Angolini > Cc: meta-freescale@yoctoproject.org > Oggetto: Re: [meta-freescale] [meta-fsl-arm] [linux-2.6.35-r45] amd-gpu : > patch proposal / discussion (imx53 + Qt 5.3 + EGLFS) > > Hi Daiane, > > On 13/11/2014 11:28, Daiane Angolini wrote: >> On Thu, Nov 13, 2014 at 6:22 AM, Gianluca Cinci >> <gianluca.cinci@giuneco.it> wrote: >>> Hi Daiane, >>> sure , the patch is attached to this mail (let me know if I must to >>> change >>> it) >> Thanks, when send a patch to meta-freescale, please use git send email >> (I think you did this the first time, right? > yes , I hope the patch is properly formatted... > > Best Regards > Gianluca > >> I copied your patch at the end of this reply, because I have some > comments. >> I cannot comment properly on the gpu code itself, so I would expect >> someone else to also comment on the patch. >> >> >>> About the cinematicexperience + eglfs dependecies: >>> With the only inclusion of cinematicexperience the "EGL..." error >>> come out , so i must to add the "amd-gpu-bin-mx51" package to have >>> all the necessary library on my fs. >> Oh, and please, do not top-post. >> >>> Bests Regards >>> Gianluca >>> >> your patch: >> (I added 2 comments inline) >> >> >> From 3201b3740bd6c81e7077845bda605fd5043b0e6a Mon Sep 17 00:00:00 >> 2001 >> From: gianluca <gianluca@giuneco.it> >> Date: Thu, 13 Nov 2014 00:11:51 +0100 >> Subject: [meta-fsl-arm][PATCH] imx: amd-gpu: avoid shared memory free > issue on >> application exit >> >> [Daiane] >> For this subject please use something like: >> >> [meta-fsl-arm][PATCH v2]linux-imx (2.6.35.3): Fix amd-gpu to avoid >> shared memory free issue. >> >> use as example: >> http://git.yoctoproject.org/cgit/cgit.cgi/meta-fsl-arm/log/recipes-ker >> nel/linux/linux-imx_2.6.35.3.bb >> >> >> Signed-off-by: gianluca <gianluca@giuneco.it> >> --- >> .../avoid-shared-memory-free-issue.patch | 26 > ++++++++++++++++++++++ >> recipes-kernel/linux/linux-imx_2.6.35.3.bb | 1 + >> 2 files changed, 27 insertions(+) >> create mode 100644 >> recipes-kernel/linux/linux-imx-2.6.35.3/avoid-shared-memory-free-issue >> .patch >> >> diff --git >> a/recipes-kernel/linux/linux-imx-2.6.35.3/avoid-shared-memory-free-iss >> ue.patch >> b/recipes-kernel/linux/linux-imx-2.6.35.3/avoid-shared-memory-free-iss >> ue.patch >> new file mode 100644 >> index 0000000..a109cc0 >> --- /dev/null >> +++ b/recipes-kernel/linux/linux-imx-2.6.35.3/avoid-shared-memory-free >> +++ -issue.patch >> @@ -0,0 +1,26 @@ >> +From 768a9f37734a9c6acb02ac1a832127af9f15da1b Mon Sep 17 00:00:00 >> +2001 >> +From: gianluca <gianluca@giuneco.it> >> +Date: Tue, 11 Nov 2014 22:25:17 +0100 >> +Subject: [PATCH] avoid shared memory free issue on application exit >> >> [Daiane] >> >> For this subject use: >> [PATCH] imx: amd-gpu: avoid shared memory free issue on application >> >> and add the tag Upstream-Status, use as example >> http://www.openembedded.org/wiki/Commit_Patch_Message_Guidelines#Patch >> _Header_Recommendations >> >> >> + >> +--- >> + drivers/mxc/amd-gpu/common/gsl_sharedmem.c | 3 +++ >> + 1 file changed, 3 insertions(+) >> + >> +diff --git a/drivers/mxc/amd-gpu/common/gsl_sharedmem.c >> b/drivers/mxc/amd-gpu/common/gsl_sharedmem.c >> +index 51e66f9..2529267 100644 >> +--- a/drivers/mxc/amd-gpu/common/gsl_sharedmem.c >> ++++ b/drivers/mxc/amd-gpu/common/gsl_sharedmem.c >> +@@ -430,6 +430,9 @@ kgsl_sharedmem_free0(gsl_memdesc_t *memdesc, >> unsigned int pid) >> + } >> + else >> + { >> ++ kgsl_hal_freephysical(memdesc->gpuaddr, NULL, NULL); // free the >> previously allocated memory if >> ++ // gpuaddress is present in gsl_linux_map_list >> ++ >> + status = GSL_FAILURE; >> + } >> + >> +-- >> +1.9.1 >> + >> diff --git a/recipes-kernel/linux/linux-imx_2.6.35.3.bb >> b/recipes-kernel/linux/linux-imx_2.6.35.3.bb >> index bfc56b7..ad1f10b 100644 >> --- a/recipes-kernel/linux/linux-imx_2.6.35.3.bb >> +++ b/recipes-kernel/linux/linux-imx_2.6.35.3.bb >> @@ -19,6 +19,7 @@ SRCBRANCH = "imx_2.6.35_maintain" >> SRC_URI += "file://NFS-Fix-nfsroot-support.patch \ >> > file://NFS-allow-nfs-root-mount-to-use-alternate-rpc-ports.patch \ >> file://perf-avoid-use-sysroot-headers.patch \ >> + file://avoid-shared-memory-free-issue.patch \ >> " >> >> >> SRC_URI_append_mx28 = " \ > -- > _______________________________________________ > meta-freescale mailing list > meta-freescale@yoctoproject.org > https://lists.yoctoproject.org/listinfo/meta-freescale > ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [meta-fsl-arm] [linux-2.6.35-r45] amd-gpu : patch proposal / discussion (imx53 + Qt 5.3 + EGLFS) 2014-11-18 11:05 ` Gianluca Cinci @ 2014-11-18 13:57 ` Simone 2014-11-18 14:45 ` Gianluca Cinci 0 siblings, 1 reply; 13+ messages in thread From: Simone @ 2014-11-18 13:57 UTC (permalink / raw) To: 'Gianluca Cinci', 'Daiane Angolini'; +Cc: meta-freescale Hello Gianluca, The problem is not the fog itself, but the lighting effect (on CinematicExperience demo). But I can confirm that disabling this effect all the DVD cases become visible. Also the information layer (the button in the upper/right corner, which open a layer with undulating content) it's very ugly and not visible. I think that for these points we need some help from Freescale... Simone -----Messaggio originale----- Da: Gianluca Cinci [mailto:gianluca.cinci@giuneco.it] Inviato: martedì 18 novembre 2014 12:06 A: Simone; 'Daiane Angolini' Cc: meta-freescale@yoctoproject.org Oggetto: Re: R: [meta-freescale] [meta-fsl-arm] [linux-2.6.35-r45] amd-gpu : patch proposal / discussion (imx53 + Qt 5.3 + EGLFS) Hi Simone, if you talk about the CinematicExperience's "fog" ; same "problem" here . Just disable the first effect on the list and you can see all the DVD's cases , I not investigate about that aspect.. I create a script that runs all the amd-gpu-bin-mx51 applications; tested in continue run for 3 days and all is went ok. Gianluca On 18/11/2014 11:39, Simone wrote: > Hello Gianluca/Daiane, > I tested this patch at my side and I can confirm that it work properly. > Still have some other troubles with qt5 effects visualization, but the > hang condition on application exit seems to be finally solved. > > Thanks > Best Regards > Simone > > > > > -----Messaggio originale----- > Da: meta-freescale-bounces@yoctoproject.org > [mailto:meta-freescale-bounces@yoctoproject.org] Per conto di Gianluca > Cinci > Inviato: martedì 18 novembre 2014 09:54 > A: Daiane Angolini > Cc: meta-freescale@yoctoproject.org > Oggetto: Re: [meta-freescale] [meta-fsl-arm] [linux-2.6.35-r45] amd-gpu : > patch proposal / discussion (imx53 + Qt 5.3 + EGLFS) > > Hi Daiane, > > On 13/11/2014 11:28, Daiane Angolini wrote: >> On Thu, Nov 13, 2014 at 6:22 AM, Gianluca Cinci >> <gianluca.cinci@giuneco.it> wrote: >>> Hi Daiane, >>> sure , the patch is attached to this mail (let me know if I must to >>> change >>> it) >> Thanks, when send a patch to meta-freescale, please use git send >> email (I think you did this the first time, right? > yes , I hope the patch is properly formatted... > > Best Regards > Gianluca > >> I copied your patch at the end of this reply, because I have some > comments. >> I cannot comment properly on the gpu code itself, so I would expect >> someone else to also comment on the patch. >> >> >>> About the cinematicexperience + eglfs dependecies: >>> With the only inclusion of cinematicexperience the "EGL..." error >>> come out , so i must to add the "amd-gpu-bin-mx51" package to have >>> all the necessary library on my fs. >> Oh, and please, do not top-post. >> >>> Bests Regards >>> Gianluca >>> >> your patch: >> (I added 2 comments inline) >> >> >> From 3201b3740bd6c81e7077845bda605fd5043b0e6a Mon Sep 17 00:00:00 >> 2001 >> From: gianluca <gianluca@giuneco.it> >> Date: Thu, 13 Nov 2014 00:11:51 +0100 >> Subject: [meta-fsl-arm][PATCH] imx: amd-gpu: avoid shared memory free > issue on >> application exit >> >> [Daiane] >> For this subject please use something like: >> >> [meta-fsl-arm][PATCH v2]linux-imx (2.6.35.3): Fix amd-gpu to avoid >> shared memory free issue. >> >> use as example: >> http://git.yoctoproject.org/cgit/cgit.cgi/meta-fsl-arm/log/recipes-ke >> r >> nel/linux/linux-imx_2.6.35.3.bb >> >> >> Signed-off-by: gianluca <gianluca@giuneco.it> >> --- >> .../avoid-shared-memory-free-issue.patch | 26 > ++++++++++++++++++++++ >> recipes-kernel/linux/linux-imx_2.6.35.3.bb | 1 + >> 2 files changed, 27 insertions(+) >> create mode 100644 >> recipes-kernel/linux/linux-imx-2.6.35.3/avoid-shared-memory-free-issu >> e >> .patch >> >> diff --git >> a/recipes-kernel/linux/linux-imx-2.6.35.3/avoid-shared-memory-free-is >> s >> ue.patch >> b/recipes-kernel/linux/linux-imx-2.6.35.3/avoid-shared-memory-free-is >> s >> ue.patch >> new file mode 100644 >> index 0000000..a109cc0 >> --- /dev/null >> +++ b/recipes-kernel/linux/linux-imx-2.6.35.3/avoid-shared-memory-fre >> +++ e >> +++ -issue.patch >> @@ -0,0 +1,26 @@ >> +From 768a9f37734a9c6acb02ac1a832127af9f15da1b Mon Sep 17 00:00:00 >> +2001 >> +From: gianluca <gianluca@giuneco.it> >> +Date: Tue, 11 Nov 2014 22:25:17 +0100 >> +Subject: [PATCH] avoid shared memory free issue on application exit >> >> [Daiane] >> >> For this subject use: >> [PATCH] imx: amd-gpu: avoid shared memory free issue on application >> >> and add the tag Upstream-Status, use as example >> http://www.openembedded.org/wiki/Commit_Patch_Message_Guidelines#Patc >> h >> _Header_Recommendations >> >> >> + >> +--- >> + drivers/mxc/amd-gpu/common/gsl_sharedmem.c | 3 +++ >> + 1 file changed, 3 insertions(+) >> + >> +diff --git a/drivers/mxc/amd-gpu/common/gsl_sharedmem.c >> b/drivers/mxc/amd-gpu/common/gsl_sharedmem.c >> +index 51e66f9..2529267 100644 >> +--- a/drivers/mxc/amd-gpu/common/gsl_sharedmem.c >> ++++ b/drivers/mxc/amd-gpu/common/gsl_sharedmem.c >> +@@ -430,6 +430,9 @@ kgsl_sharedmem_free0(gsl_memdesc_t *memdesc, >> unsigned int pid) >> + } >> + else >> + { >> ++ kgsl_hal_freephysical(memdesc->gpuaddr, NULL, NULL); // free the >> previously allocated memory if >> ++ // gpuaddress is present in gsl_linux_map_list >> ++ >> + status = GSL_FAILURE; >> + } >> + >> +-- >> +1.9.1 >> + >> diff --git a/recipes-kernel/linux/linux-imx_2.6.35.3.bb >> b/recipes-kernel/linux/linux-imx_2.6.35.3.bb >> index bfc56b7..ad1f10b 100644 >> --- a/recipes-kernel/linux/linux-imx_2.6.35.3.bb >> +++ b/recipes-kernel/linux/linux-imx_2.6.35.3.bb >> @@ -19,6 +19,7 @@ SRCBRANCH = "imx_2.6.35_maintain" >> SRC_URI += "file://NFS-Fix-nfsroot-support.patch \ >> > file://NFS-allow-nfs-root-mount-to-use-alternate-rpc-ports.patch \ >> file://perf-avoid-use-sysroot-headers.patch \ >> + file://avoid-shared-memory-free-issue.patch \ >> " >> >> >> SRC_URI_append_mx28 = " \ > -- > _______________________________________________ > meta-freescale mailing list > meta-freescale@yoctoproject.org > https://lists.yoctoproject.org/listinfo/meta-freescale > ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [meta-fsl-arm] [linux-2.6.35-r45] amd-gpu : patch proposal / discussion (imx53 + Qt 5.3 + EGLFS) 2014-11-18 13:57 ` Simone @ 2014-11-18 14:45 ` Gianluca Cinci 2014-11-18 17:23 ` Simone 0 siblings, 1 reply; 13+ messages in thread From: Gianluca Cinci @ 2014-11-18 14:45 UTC (permalink / raw) To: Simone, 'Daiane Angolini'; +Cc: meta-freescale@yoctoproject.org Hi Simone, yes , the "problem" concern the lightning effects (not the fog sorry) , and i saw the upper left corner ugly window (but i also notice that this demo is "customized" for rasperry-pi). Do you think we have this problem on all applications where lightning effects are implemented or this is a sporadic behaviour? Gianluca ________________________________________ Da: Simone <cjb.sw.nospam@gmail.com> Inviato: martedì 18 novembre 2014 14.57 A: Gianluca Cinci; 'Daiane Angolini' Cc: meta-freescale@yoctoproject.org Oggetto: R: R: [meta-freescale] [meta-fsl-arm] [linux-2.6.35-r45] amd-gpu : patch proposal / discussion (imx53 + Qt 5.3 + EGLFS) Hello Gianluca, The problem is not the fog itself, but the lighting effect (on CinematicExperience demo). But I can confirm that disabling this effect all the DVD cases become visible. Also the information layer (the button in the upper/right corner, which open a layer with undulating content) it's very ugly and not visible. I think that for these points we need some help from Freescale... Simone -----Messaggio originale----- Da: Gianluca Cinci [mailto:gianluca.cinci@giuneco.it] Inviato: martedì 18 novembre 2014 12:06 A: Simone; 'Daiane Angolini' Cc: meta-freescale@yoctoproject.org Oggetto: Re: R: [meta-freescale] [meta-fsl-arm] [linux-2.6.35-r45] amd-gpu : patch proposal / discussion (imx53 + Qt 5.3 + EGLFS) Hi Simone, if you talk about the CinematicExperience's "fog" ; same "problem" here . Just disable the first effect on the list and you can see all the DVD's cases , I not investigate about that aspect.. I create a script that runs all the amd-gpu-bin-mx51 applications; tested in continue run for 3 days and all is went ok. Gianluca On 18/11/2014 11:39, Simone wrote: > Hello Gianluca/Daiane, > I tested this patch at my side and I can confirm that it work properly. > Still have some other troubles with qt5 effects visualization, but the > hang condition on application exit seems to be finally solved. > > Thanks > Best Regards > Simone > > > > > -----Messaggio originale----- > Da: meta-freescale-bounces@yoctoproject.org > [mailto:meta-freescale-bounces@yoctoproject.org] Per conto di Gianluca > Cinci > Inviato: martedì 18 novembre 2014 09:54 > A: Daiane Angolini > Cc: meta-freescale@yoctoproject.org > Oggetto: Re: [meta-freescale] [meta-fsl-arm] [linux-2.6.35-r45] amd-gpu : > patch proposal / discussion (imx53 + Qt 5.3 + EGLFS) > > Hi Daiane, > > On 13/11/2014 11:28, Daiane Angolini wrote: >> On Thu, Nov 13, 2014 at 6:22 AM, Gianluca Cinci >> <gianluca.cinci@giuneco.it> wrote: >>> Hi Daiane, >>> sure , the patch is attached to this mail (let me know if I must to >>> change >>> it) >> Thanks, when send a patch to meta-freescale, please use git send >> email (I think you did this the first time, right? > yes , I hope the patch is properly formatted... > > Best Regards > Gianluca > >> I copied your patch at the end of this reply, because I have some > comments. >> I cannot comment properly on the gpu code itself, so I would expect >> someone else to also comment on the patch. >> >> >>> About the cinematicexperience + eglfs dependecies: >>> With the only inclusion of cinematicexperience the "EGL..." error >>> come out , so i must to add the "amd-gpu-bin-mx51" package to have >>> all the necessary library on my fs. >> Oh, and please, do not top-post. >> >>> Bests Regards >>> Gianluca >>> >> your patch: >> (I added 2 comments inline) >> >> >> From 3201b3740bd6c81e7077845bda605fd5043b0e6a Mon Sep 17 00:00:00 >> 2001 >> From: gianluca <gianluca@giuneco.it> >> Date: Thu, 13 Nov 2014 00:11:51 +0100 >> Subject: [meta-fsl-arm][PATCH] imx: amd-gpu: avoid shared memory free > issue on >> application exit >> >> [Daiane] >> For this subject please use something like: >> >> [meta-fsl-arm][PATCH v2]linux-imx (2.6.35.3): Fix amd-gpu to avoid >> shared memory free issue. >> >> use as example: >> http://git.yoctoproject.org/cgit/cgit.cgi/meta-fsl-arm/log/recipes-ke >> r >> nel/linux/linux-imx_2.6.35.3.bb >> >> >> Signed-off-by: gianluca <gianluca@giuneco.it> >> --- >> .../avoid-shared-memory-free-issue.patch | 26 > ++++++++++++++++++++++ >> recipes-kernel/linux/linux-imx_2.6.35.3.bb | 1 + >> 2 files changed, 27 insertions(+) >> create mode 100644 >> recipes-kernel/linux/linux-imx-2.6.35.3/avoid-shared-memory-free-issu >> e >> .patch >> >> diff --git >> a/recipes-kernel/linux/linux-imx-2.6.35.3/avoid-shared-memory-free-is >> s >> ue.patch >> b/recipes-kernel/linux/linux-imx-2.6.35.3/avoid-shared-memory-free-is >> s >> ue.patch >> new file mode 100644 >> index 0000000..a109cc0 >> --- /dev/null >> +++ b/recipes-kernel/linux/linux-imx-2.6.35.3/avoid-shared-memory-fre >> +++ e >> +++ -issue.patch >> @@ -0,0 +1,26 @@ >> +From 768a9f37734a9c6acb02ac1a832127af9f15da1b Mon Sep 17 00:00:00 >> +2001 >> +From: gianluca <gianluca@giuneco.it> >> +Date: Tue, 11 Nov 2014 22:25:17 +0100 >> +Subject: [PATCH] avoid shared memory free issue on application exit >> >> [Daiane] >> >> For this subject use: >> [PATCH] imx: amd-gpu: avoid shared memory free issue on application >> >> and add the tag Upstream-Status, use as example >> http://www.openembedded.org/wiki/Commit_Patch_Message_Guidelines#Patc >> h >> _Header_Recommendations >> >> >> + >> +--- >> + drivers/mxc/amd-gpu/common/gsl_sharedmem.c | 3 +++ >> + 1 file changed, 3 insertions(+) >> + >> +diff --git a/drivers/mxc/amd-gpu/common/gsl_sharedmem.c >> b/drivers/mxc/amd-gpu/common/gsl_sharedmem.c >> +index 51e66f9..2529267 100644 >> +--- a/drivers/mxc/amd-gpu/common/gsl_sharedmem.c >> ++++ b/drivers/mxc/amd-gpu/common/gsl_sharedmem.c >> +@@ -430,6 +430,9 @@ kgsl_sharedmem_free0(gsl_memdesc_t *memdesc, >> unsigned int pid) >> + } >> + else >> + { >> ++ kgsl_hal_freephysical(memdesc->gpuaddr, NULL, NULL); // free the >> previously allocated memory if >> ++ // gpuaddress is present in gsl_linux_map_list >> ++ >> + status = GSL_FAILURE; >> + } >> + >> +-- >> +1.9.1 >> + >> diff --git a/recipes-kernel/linux/linux-imx_2.6.35.3.bb >> b/recipes-kernel/linux/linux-imx_2.6.35.3.bb >> index bfc56b7..ad1f10b 100644 >> --- a/recipes-kernel/linux/linux-imx_2.6.35.3.bb >> +++ b/recipes-kernel/linux/linux-imx_2.6.35.3.bb >> @@ -19,6 +19,7 @@ SRCBRANCH = "imx_2.6.35_maintain" >> SRC_URI += "file://NFS-Fix-nfsroot-support.patch \ >> > file://NFS-allow-nfs-root-mount-to-use-alternate-rpc-ports.patch \ >> file://perf-avoid-use-sysroot-headers.patch \ >> + file://avoid-shared-memory-free-issue.patch \ >> " >> >> >> SRC_URI_append_mx28 = " \ > -- > _______________________________________________ > meta-freescale mailing list > meta-freescale@yoctoproject.org > https://lists.yoctoproject.org/listinfo/meta-freescale > ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [meta-fsl-arm] [linux-2.6.35-r45] amd-gpu : patch proposal / discussion (imx53 + Qt 5.3 + EGLFS) 2014-11-18 14:45 ` Gianluca Cinci @ 2014-11-18 17:23 ` Simone 0 siblings, 0 replies; 13+ messages in thread From: Simone @ 2014-11-18 17:23 UTC (permalink / raw) To: 'Gianluca Cinci', 'Daiane Angolini'; +Cc: meta-freescale Hello Gianluca, This demo isn't customized for Raspberry Pi, since is Qt based and not hardware/dependent. I think yes, (from what I can see) for sure we will have problems in Qt applications that use: CurtainEffect, FastBlur, Lightning. Ciao Simone -----Messaggio originale----- Da: Gianluca Cinci [mailto:gianluca.cinci@giuneco.it] Inviato: martedì 18 novembre 2014 15:46 A: Simone; 'Daiane Angolini' Cc: meta-freescale@yoctoproject.org Oggetto: RE: R: [meta-freescale] [meta-fsl-arm] [linux-2.6.35-r45] amd-gpu : patch proposal / discussion (imx53 + Qt 5.3 + EGLFS) Hi Simone, yes , the "problem" concern the lightning effects (not the fog sorry) , and i saw the upper left corner ugly window (but i also notice that this demo is "customized" for rasperry-pi). Do you think we have this problem on all applications where lightning effects are implemented or this is a sporadic behaviour? Gianluca ________________________________________ Da: Simone <cjb.sw.nospam@gmail.com> Inviato: martedì 18 novembre 2014 14.57 A: Gianluca Cinci; 'Daiane Angolini' Cc: meta-freescale@yoctoproject.org Oggetto: R: R: [meta-freescale] [meta-fsl-arm] [linux-2.6.35-r45] amd-gpu : patch proposal / discussion (imx53 + Qt 5.3 + EGLFS) Hello Gianluca, The problem is not the fog itself, but the lighting effect (on CinematicExperience demo). But I can confirm that disabling this effect all the DVD cases become visible. Also the information layer (the button in the upper/right corner, which open a layer with undulating content) it's very ugly and not visible. I think that for these points we need some help from Freescale... Simone -----Messaggio originale----- Da: Gianluca Cinci [mailto:gianluca.cinci@giuneco.it] Inviato: martedì 18 novembre 2014 12:06 A: Simone; 'Daiane Angolini' Cc: meta-freescale@yoctoproject.org Oggetto: Re: R: [meta-freescale] [meta-fsl-arm] [linux-2.6.35-r45] amd-gpu : patch proposal / discussion (imx53 + Qt 5.3 + EGLFS) Hi Simone, if you talk about the CinematicExperience's "fog" ; same "problem" here . Just disable the first effect on the list and you can see all the DVD's cases , I not investigate about that aspect.. I create a script that runs all the amd-gpu-bin-mx51 applications; tested in continue run for 3 days and all is went ok. Gianluca On 18/11/2014 11:39, Simone wrote: > Hello Gianluca/Daiane, > I tested this patch at my side and I can confirm that it work properly. > Still have some other troubles with qt5 effects visualization, but the > hang condition on application exit seems to be finally solved. > > Thanks > Best Regards > Simone > > > > > -----Messaggio originale----- > Da: meta-freescale-bounces@yoctoproject.org > [mailto:meta-freescale-bounces@yoctoproject.org] Per conto di Gianluca > Cinci > Inviato: martedì 18 novembre 2014 09:54 > A: Daiane Angolini > Cc: meta-freescale@yoctoproject.org > Oggetto: Re: [meta-freescale] [meta-fsl-arm] [linux-2.6.35-r45] amd-gpu : > patch proposal / discussion (imx53 + Qt 5.3 + EGLFS) > > Hi Daiane, > > On 13/11/2014 11:28, Daiane Angolini wrote: >> On Thu, Nov 13, 2014 at 6:22 AM, Gianluca Cinci >> <gianluca.cinci@giuneco.it> wrote: >>> Hi Daiane, >>> sure , the patch is attached to this mail (let me know if I must to >>> change >>> it) >> Thanks, when send a patch to meta-freescale, please use git send >> email (I think you did this the first time, right? > yes , I hope the patch is properly formatted... > > Best Regards > Gianluca > >> I copied your patch at the end of this reply, because I have some > comments. >> I cannot comment properly on the gpu code itself, so I would expect >> someone else to also comment on the patch. >> >> >>> About the cinematicexperience + eglfs dependecies: >>> With the only inclusion of cinematicexperience the "EGL..." error >>> come out , so i must to add the "amd-gpu-bin-mx51" package to have >>> all the necessary library on my fs. >> Oh, and please, do not top-post. >> >>> Bests Regards >>> Gianluca >>> >> your patch: >> (I added 2 comments inline) >> >> >> From 3201b3740bd6c81e7077845bda605fd5043b0e6a Mon Sep 17 00:00:00 >> 2001 >> From: gianluca <gianluca@giuneco.it> >> Date: Thu, 13 Nov 2014 00:11:51 +0100 >> Subject: [meta-fsl-arm][PATCH] imx: amd-gpu: avoid shared memory free > issue on >> application exit >> >> [Daiane] >> For this subject please use something like: >> >> [meta-fsl-arm][PATCH v2]linux-imx (2.6.35.3): Fix amd-gpu to avoid >> shared memory free issue. >> >> use as example: >> http://git.yoctoproject.org/cgit/cgit.cgi/meta-fsl-arm/log/recipes-ke >> r >> nel/linux/linux-imx_2.6.35.3.bb >> >> >> Signed-off-by: gianluca <gianluca@giuneco.it> >> --- >> .../avoid-shared-memory-free-issue.patch | 26 > ++++++++++++++++++++++ >> recipes-kernel/linux/linux-imx_2.6.35.3.bb | 1 + >> 2 files changed, 27 insertions(+) >> create mode 100644 >> recipes-kernel/linux/linux-imx-2.6.35.3/avoid-shared-memory-free-issu >> e >> .patch >> >> diff --git >> a/recipes-kernel/linux/linux-imx-2.6.35.3/avoid-shared-memory-free-is >> s >> ue.patch >> b/recipes-kernel/linux/linux-imx-2.6.35.3/avoid-shared-memory-free-is >> s >> ue.patch >> new file mode 100644 >> index 0000000..a109cc0 >> --- /dev/null >> +++ b/recipes-kernel/linux/linux-imx-2.6.35.3/avoid-shared-memory-fre >> +++ e >> +++ -issue.patch >> @@ -0,0 +1,26 @@ >> +From 768a9f37734a9c6acb02ac1a832127af9f15da1b Mon Sep 17 00:00:00 >> +2001 >> +From: gianluca <gianluca@giuneco.it> >> +Date: Tue, 11 Nov 2014 22:25:17 +0100 >> +Subject: [PATCH] avoid shared memory free issue on application exit >> >> [Daiane] >> >> For this subject use: >> [PATCH] imx: amd-gpu: avoid shared memory free issue on application >> >> and add the tag Upstream-Status, use as example >> http://www.openembedded.org/wiki/Commit_Patch_Message_Guidelines#Patc >> h >> _Header_Recommendations >> >> >> + >> +--- >> + drivers/mxc/amd-gpu/common/gsl_sharedmem.c | 3 +++ >> + 1 file changed, 3 insertions(+) >> + >> +diff --git a/drivers/mxc/amd-gpu/common/gsl_sharedmem.c >> b/drivers/mxc/amd-gpu/common/gsl_sharedmem.c >> +index 51e66f9..2529267 100644 >> +--- a/drivers/mxc/amd-gpu/common/gsl_sharedmem.c >> ++++ b/drivers/mxc/amd-gpu/common/gsl_sharedmem.c >> +@@ -430,6 +430,9 @@ kgsl_sharedmem_free0(gsl_memdesc_t *memdesc, >> unsigned int pid) >> + } >> + else >> + { >> ++ kgsl_hal_freephysical(memdesc->gpuaddr, NULL, NULL); // free the >> previously allocated memory if >> ++ // gpuaddress is present in gsl_linux_map_list >> ++ >> + status = GSL_FAILURE; >> + } >> + >> +-- >> +1.9.1 >> + >> diff --git a/recipes-kernel/linux/linux-imx_2.6.35.3.bb >> b/recipes-kernel/linux/linux-imx_2.6.35.3.bb >> index bfc56b7..ad1f10b 100644 >> --- a/recipes-kernel/linux/linux-imx_2.6.35.3.bb >> +++ b/recipes-kernel/linux/linux-imx_2.6.35.3.bb >> @@ -19,6 +19,7 @@ SRCBRANCH = "imx_2.6.35_maintain" >> SRC_URI += "file://NFS-Fix-nfsroot-support.patch \ >> > file://NFS-allow-nfs-root-mount-to-use-alternate-rpc-ports.patch \ >> file://perf-avoid-use-sysroot-headers.patch \ >> + file://avoid-shared-memory-free-issue.patch \ >> " >> >> >> SRC_URI_append_mx28 = " \ > -- > _______________________________________________ > meta-freescale mailing list > meta-freescale@yoctoproject.org > https://lists.yoctoproject.org/listinfo/meta-freescale > ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [meta-fsl-arm] [linux-2.6.35-r45] amd-gpu : patch proposal / discussion (imx53 + Qt 5.3 + EGLFS) 2014-11-18 8:54 ` Gianluca Cinci 2014-11-18 10:39 ` Simone @ 2014-11-19 15:29 ` Daiane Angolini 1 sibling, 0 replies; 13+ messages in thread From: Daiane Angolini @ 2014-11-19 15:29 UTC (permalink / raw) To: Gianluca Cinci; +Cc: meta-freescale@yoctoproject.org On Tue, Nov 18, 2014 at 6:54 AM, Gianluca Cinci <gianluca.cinci@giuneco.it> wrote: > Hi Daiane, > > On 13/11/2014 11:28, Daiane Angolini wrote: >> >> On Thu, Nov 13, 2014 at 6:22 AM, Gianluca Cinci >> <gianluca.cinci@giuneco.it> wrote: >>> >>> Hi Daiane, >>> sure , the patch is attached to this mail (let me know if I must to >>> change >>> it) >> >> Thanks, when send a patch to meta-freescale, please use git send email >> (I think you did this the first time, right? > > yes , I hope the patch is properly formatted... I´m sorry for my delay, I may have missed some point about this discussion, however I remember I commented at least 2 things about your patch format. One was the missing Upstream-Status, and the other one was the subject. The subject is up-to you, but the Upstream Status is not optional, please, add this tag to your added patch (this way we can keep control of what is missing to be upstreamed) > > Best Regards > Gianluca > > >> From 3201b3740bd6c81e7077845bda605fd5043b0e6a Mon Sep 17 00:00:00 2001 >> From: gianluca <gianluca@giuneco.it> >> Date: Thu, 13 Nov 2014 00:11:51 +0100 >> Subject: [meta-fsl-arm][PATCH] imx: amd-gpu: avoid shared memory free >> issue on >> application exit >> >> [Daiane] >> For this subject please use something like: >> >> [meta-fsl-arm][PATCH v2]linux-imx (2.6.35.3): Fix amd-gpu to avoid >> shared memory free issue. >> >> use as example: >> >> http://git.yoctoproject.org/cgit/cgit.cgi/meta-fsl-arm/log/recipes-kernel/linux/linux-imx_2.6.35.3.bb >> b/recipes-kernel/linux/linux-imx-2.6.35.3/avoid-shared-memory-free-issue.patch >> @@ -0,0 +1,26 @@ >> +From 768a9f37734a9c6acb02ac1a832127af9f15da1b Mon Sep 17 00:00:00 2001 >> +From: gianluca <gianluca@giuneco.it> >> +Date: Tue, 11 Nov 2014 22:25:17 +0100 >> +Subject: [PATCH] avoid shared memory free issue on application exit >> >> [Daiane] >> >> For this subject use: >> [PATCH] imx: amd-gpu: avoid shared memory free issue on application >> >> and add the tag Upstream-Status, use as example >> >> http://www.openembedded.org/wiki/Commit_Patch_Message_Guidelines#Patch_Header_Recommendations Best Regards, Daiane ^ permalink raw reply [flat|nested] 13+ messages in thread
end of thread, other threads:[~2014-11-19 15:29 UTC | newest] Thread overview: 13+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2014-11-12 0:17 [meta-fsl-arm] [linux-2.6.35-r45] amd-gpu : patch proposal / discussion (imx53 + Qt 5.3 + EGLFS) Gianluca Cinci 2014-11-12 10:47 ` Daiane Angolini 2014-11-13 8:22 ` Gianluca Cinci 2014-11-13 10:18 ` Otavio Salvador 2014-11-17 13:13 ` Gianluca Cinci 2014-11-13 10:28 ` Daiane Angolini 2014-11-18 8:54 ` Gianluca Cinci 2014-11-18 10:39 ` Simone 2014-11-18 11:05 ` Gianluca Cinci 2014-11-18 13:57 ` Simone 2014-11-18 14:45 ` Gianluca Cinci 2014-11-18 17:23 ` Simone 2014-11-19 15:29 ` Daiane Angolini
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.