From: Kukjin Kim <kgene@kernel.org>
To: 'Tomasz Figa' <tomasz.figa@gmail.com>, linux-samsung-soc@vger.kernel.org
Cc: linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, 'Arnd Bergmann' <arnd@arndb.de>,
'Olof Johansson' <olof@lixom.net>,
'Marek Szyprowski' <m.szyprowski@samsung.com>
Subject: RE: [PATCH] ARM: dts: s3c64xx: Enable PWM node by default
Date: Mon, 22 Sep 2014 21:03:28 +0900 [thread overview]
Message-ID: <019301cfd65d$39bc5460$ad34fd20$@kernel.org> (raw)
In-Reply-To: <1411387317-4837-1-git-send-email-tomasz.figa@gmail.com>
Tomasz Figa wrote:
>
> The PWM block is required for system clock source so it must be always
> enabled. This patch fixes boot issues on SMDK6410 which did not have the
> node enabled explicitly for other purposes.
>
> Fixes: eeb93d02c5d8 ("clocksource: of: Respect device tree node status")
> Signed-off-by: Tomasz Figa <tomasz.figa@gmail.com>
> ---
> arch/arm/boot/dts/s3c6410-mini6410.dts | 4 ----
> arch/arm/boot/dts/s3c64xx.dtsi | 1 -
> 2 files changed, 5 deletions(-)
>
> diff --git a/arch/arm/boot/dts/s3c6410-mini6410.dts b/arch/arm/boot/dts/s3c6410-mini6410.dts
> index a171cdd26b7f..42c2bcdf2626 100644
> --- a/arch/arm/boot/dts/s3c6410-mini6410.dts
> +++ b/arch/arm/boot/dts/s3c6410-mini6410.dts
> @@ -252,10 +252,6 @@
> status = "okay";
> };
>
> -&pwm {
> - status = "okay";
> -};
> -
> &pinctrl0 {
> gpio_leds: gpio-leds {
> samsung,pins = "gpk-4", "gpk-5", "gpk-6", "gpk-7";
> diff --git a/arch/arm/boot/dts/s3c64xx.dtsi b/arch/arm/boot/dts/s3c64xx.dtsi
> index 05c717ad1edd..196fe6ea205d 100644
> --- a/arch/arm/boot/dts/s3c64xx.dtsi
> +++ b/arch/arm/boot/dts/s3c64xx.dtsi
> @@ -239,7 +239,6 @@
> clocks = <&clocks PCLK_PWM>;
> samsung,pwm-outputs = <0>, <1>;
> #pwm-cells = <3>;
> - status = "disabled";
> };
>
> pinctrl0: pinctrl@7f008000 {
> --
> 2.1.0
Looks good, will apply.
Thanks,
Kukjin
WARNING: multiple messages have this Message-ID (diff)
From: kgene@kernel.org (Kukjin Kim)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: dts: s3c64xx: Enable PWM node by default
Date: Mon, 22 Sep 2014 21:03:28 +0900 [thread overview]
Message-ID: <019301cfd65d$39bc5460$ad34fd20$@kernel.org> (raw)
In-Reply-To: <1411387317-4837-1-git-send-email-tomasz.figa@gmail.com>
Tomasz Figa wrote:
>
> The PWM block is required for system clock source so it must be always
> enabled. This patch fixes boot issues on SMDK6410 which did not have the
> node enabled explicitly for other purposes.
>
> Fixes: eeb93d02c5d8 ("clocksource: of: Respect device tree node status")
> Signed-off-by: Tomasz Figa <tomasz.figa@gmail.com>
> ---
> arch/arm/boot/dts/s3c6410-mini6410.dts | 4 ----
> arch/arm/boot/dts/s3c64xx.dtsi | 1 -
> 2 files changed, 5 deletions(-)
>
> diff --git a/arch/arm/boot/dts/s3c6410-mini6410.dts b/arch/arm/boot/dts/s3c6410-mini6410.dts
> index a171cdd26b7f..42c2bcdf2626 100644
> --- a/arch/arm/boot/dts/s3c6410-mini6410.dts
> +++ b/arch/arm/boot/dts/s3c6410-mini6410.dts
> @@ -252,10 +252,6 @@
> status = "okay";
> };
>
> -&pwm {
> - status = "okay";
> -};
> -
> &pinctrl0 {
> gpio_leds: gpio-leds {
> samsung,pins = "gpk-4", "gpk-5", "gpk-6", "gpk-7";
> diff --git a/arch/arm/boot/dts/s3c64xx.dtsi b/arch/arm/boot/dts/s3c64xx.dtsi
> index 05c717ad1edd..196fe6ea205d 100644
> --- a/arch/arm/boot/dts/s3c64xx.dtsi
> +++ b/arch/arm/boot/dts/s3c64xx.dtsi
> @@ -239,7 +239,6 @@
> clocks = <&clocks PCLK_PWM>;
> samsung,pwm-outputs = <0>, <1>;
> #pwm-cells = <3>;
> - status = "disabled";
> };
>
> pinctrl0: pinctrl at 7f008000 {
> --
> 2.1.0
Looks good, will apply.
Thanks,
Kukjin
next prev parent reply other threads:[~2014-09-22 12:03 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-22 12:01 [PATCH] ARM: dts: s3c64xx: Enable PWM node by default Tomasz Figa
2014-09-22 12:01 ` Tomasz Figa
2014-09-22 12:03 ` Kukjin Kim [this message]
2014-09-22 12:03 ` Kukjin Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='019301cfd65d$39bc5460$ad34fd20$@kernel.org' \
--to=kgene@kernel.org \
--cc=arnd@arndb.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=olof@lixom.net \
--cc=tomasz.figa@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.