* [PATCH] ARM: dts: s3c64xx: Enable PWM node by default
@ 2014-09-22 12:01 ` Tomasz Figa
0 siblings, 0 replies; 4+ messages in thread
From: Tomasz Figa @ 2014-09-22 12:01 UTC (permalink / raw)
To: linux-samsung-soc
Cc: linux-arm-kernel, linux-kernel, Kukjin Kim, Arnd Bergmann,
Olof Johansson, Marek Szyprowski, Tomasz Figa
The PWM block is required for system clock source so it must be always
enabled. This patch fixes boot issues on SMDK6410 which did not have the
node enabled explicitly for other purposes.
Fixes: eeb93d02c5d8 ("clocksource: of: Respect device tree node status")
Signed-off-by: Tomasz Figa <tomasz.figa@gmail.com>
---
arch/arm/boot/dts/s3c6410-mini6410.dts | 4 ----
arch/arm/boot/dts/s3c64xx.dtsi | 1 -
2 files changed, 5 deletions(-)
diff --git a/arch/arm/boot/dts/s3c6410-mini6410.dts b/arch/arm/boot/dts/s3c6410-mini6410.dts
index a171cdd26b7f..42c2bcdf2626 100644
--- a/arch/arm/boot/dts/s3c6410-mini6410.dts
+++ b/arch/arm/boot/dts/s3c6410-mini6410.dts
@@ -252,10 +252,6 @@
status = "okay";
};
-&pwm {
- status = "okay";
-};
-
&pinctrl0 {
gpio_leds: gpio-leds {
samsung,pins = "gpk-4", "gpk-5", "gpk-6", "gpk-7";
diff --git a/arch/arm/boot/dts/s3c64xx.dtsi b/arch/arm/boot/dts/s3c64xx.dtsi
index 05c717ad1edd..196fe6ea205d 100644
--- a/arch/arm/boot/dts/s3c64xx.dtsi
+++ b/arch/arm/boot/dts/s3c64xx.dtsi
@@ -239,7 +239,6 @@
clocks = <&clocks PCLK_PWM>;
samsung,pwm-outputs = <0>, <1>;
#pwm-cells = <3>;
- status = "disabled";
};
pinctrl0: pinctrl@7f008000 {
--
2.1.0
^ permalink raw reply related [flat|nested] 4+ messages in thread* [PATCH] ARM: dts: s3c64xx: Enable PWM node by default
@ 2014-09-22 12:01 ` Tomasz Figa
0 siblings, 0 replies; 4+ messages in thread
From: Tomasz Figa @ 2014-09-22 12:01 UTC (permalink / raw)
To: linux-arm-kernel
The PWM block is required for system clock source so it must be always
enabled. This patch fixes boot issues on SMDK6410 which did not have the
node enabled explicitly for other purposes.
Fixes: eeb93d02c5d8 ("clocksource: of: Respect device tree node status")
Signed-off-by: Tomasz Figa <tomasz.figa@gmail.com>
---
arch/arm/boot/dts/s3c6410-mini6410.dts | 4 ----
arch/arm/boot/dts/s3c64xx.dtsi | 1 -
2 files changed, 5 deletions(-)
diff --git a/arch/arm/boot/dts/s3c6410-mini6410.dts b/arch/arm/boot/dts/s3c6410-mini6410.dts
index a171cdd26b7f..42c2bcdf2626 100644
--- a/arch/arm/boot/dts/s3c6410-mini6410.dts
+++ b/arch/arm/boot/dts/s3c6410-mini6410.dts
@@ -252,10 +252,6 @@
status = "okay";
};
-&pwm {
- status = "okay";
-};
-
&pinctrl0 {
gpio_leds: gpio-leds {
samsung,pins = "gpk-4", "gpk-5", "gpk-6", "gpk-7";
diff --git a/arch/arm/boot/dts/s3c64xx.dtsi b/arch/arm/boot/dts/s3c64xx.dtsi
index 05c717ad1edd..196fe6ea205d 100644
--- a/arch/arm/boot/dts/s3c64xx.dtsi
+++ b/arch/arm/boot/dts/s3c64xx.dtsi
@@ -239,7 +239,6 @@
clocks = <&clocks PCLK_PWM>;
samsung,pwm-outputs = <0>, <1>;
#pwm-cells = <3>;
- status = "disabled";
};
pinctrl0: pinctrl at 7f008000 {
--
2.1.0
^ permalink raw reply related [flat|nested] 4+ messages in thread* RE: [PATCH] ARM: dts: s3c64xx: Enable PWM node by default
2014-09-22 12:01 ` Tomasz Figa
@ 2014-09-22 12:03 ` Kukjin Kim
-1 siblings, 0 replies; 4+ messages in thread
From: Kukjin Kim @ 2014-09-22 12:03 UTC (permalink / raw)
To: 'Tomasz Figa', linux-samsung-soc
Cc: linux-arm-kernel, linux-kernel, 'Arnd Bergmann',
'Olof Johansson', 'Marek Szyprowski'
Tomasz Figa wrote:
>
> The PWM block is required for system clock source so it must be always
> enabled. This patch fixes boot issues on SMDK6410 which did not have the
> node enabled explicitly for other purposes.
>
> Fixes: eeb93d02c5d8 ("clocksource: of: Respect device tree node status")
> Signed-off-by: Tomasz Figa <tomasz.figa@gmail.com>
> ---
> arch/arm/boot/dts/s3c6410-mini6410.dts | 4 ----
> arch/arm/boot/dts/s3c64xx.dtsi | 1 -
> 2 files changed, 5 deletions(-)
>
> diff --git a/arch/arm/boot/dts/s3c6410-mini6410.dts b/arch/arm/boot/dts/s3c6410-mini6410.dts
> index a171cdd26b7f..42c2bcdf2626 100644
> --- a/arch/arm/boot/dts/s3c6410-mini6410.dts
> +++ b/arch/arm/boot/dts/s3c6410-mini6410.dts
> @@ -252,10 +252,6 @@
> status = "okay";
> };
>
> -&pwm {
> - status = "okay";
> -};
> -
> &pinctrl0 {
> gpio_leds: gpio-leds {
> samsung,pins = "gpk-4", "gpk-5", "gpk-6", "gpk-7";
> diff --git a/arch/arm/boot/dts/s3c64xx.dtsi b/arch/arm/boot/dts/s3c64xx.dtsi
> index 05c717ad1edd..196fe6ea205d 100644
> --- a/arch/arm/boot/dts/s3c64xx.dtsi
> +++ b/arch/arm/boot/dts/s3c64xx.dtsi
> @@ -239,7 +239,6 @@
> clocks = <&clocks PCLK_PWM>;
> samsung,pwm-outputs = <0>, <1>;
> #pwm-cells = <3>;
> - status = "disabled";
> };
>
> pinctrl0: pinctrl@7f008000 {
> --
> 2.1.0
Looks good, will apply.
Thanks,
Kukjin
^ permalink raw reply [flat|nested] 4+ messages in thread* [PATCH] ARM: dts: s3c64xx: Enable PWM node by default
@ 2014-09-22 12:03 ` Kukjin Kim
0 siblings, 0 replies; 4+ messages in thread
From: Kukjin Kim @ 2014-09-22 12:03 UTC (permalink / raw)
To: linux-arm-kernel
Tomasz Figa wrote:
>
> The PWM block is required for system clock source so it must be always
> enabled. This patch fixes boot issues on SMDK6410 which did not have the
> node enabled explicitly for other purposes.
>
> Fixes: eeb93d02c5d8 ("clocksource: of: Respect device tree node status")
> Signed-off-by: Tomasz Figa <tomasz.figa@gmail.com>
> ---
> arch/arm/boot/dts/s3c6410-mini6410.dts | 4 ----
> arch/arm/boot/dts/s3c64xx.dtsi | 1 -
> 2 files changed, 5 deletions(-)
>
> diff --git a/arch/arm/boot/dts/s3c6410-mini6410.dts b/arch/arm/boot/dts/s3c6410-mini6410.dts
> index a171cdd26b7f..42c2bcdf2626 100644
> --- a/arch/arm/boot/dts/s3c6410-mini6410.dts
> +++ b/arch/arm/boot/dts/s3c6410-mini6410.dts
> @@ -252,10 +252,6 @@
> status = "okay";
> };
>
> -&pwm {
> - status = "okay";
> -};
> -
> &pinctrl0 {
> gpio_leds: gpio-leds {
> samsung,pins = "gpk-4", "gpk-5", "gpk-6", "gpk-7";
> diff --git a/arch/arm/boot/dts/s3c64xx.dtsi b/arch/arm/boot/dts/s3c64xx.dtsi
> index 05c717ad1edd..196fe6ea205d 100644
> --- a/arch/arm/boot/dts/s3c64xx.dtsi
> +++ b/arch/arm/boot/dts/s3c64xx.dtsi
> @@ -239,7 +239,6 @@
> clocks = <&clocks PCLK_PWM>;
> samsung,pwm-outputs = <0>, <1>;
> #pwm-cells = <3>;
> - status = "disabled";
> };
>
> pinctrl0: pinctrl at 7f008000 {
> --
> 2.1.0
Looks good, will apply.
Thanks,
Kukjin
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2014-09-22 12:03 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-09-22 12:01 [PATCH] ARM: dts: s3c64xx: Enable PWM node by default Tomasz Figa
2014-09-22 12:01 ` Tomasz Figa
2014-09-22 12:03 ` Kukjin Kim
2014-09-22 12:03 ` Kukjin Kim
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.